[PULL 0/3] Optional fixes for 9.1.0-rc4

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [PULL 0/3] Optional fixes for 9.1.0-rc4
@ 2024-08-26  9:43 Thomas Huth
  2024-08-26  9:43 ` [PULL 1/3] gitlab-ci: Replace build_script -> step_script in Cirrus jobs Thomas Huth
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Thomas Huth @ 2024-08-26  9:43 UTC (permalink / raw)
  To: qemu-devel, Richard Henderson

 Hi Richard,

since it seems like we're going to have RC4, here are some minor
fixes that could still be included.

The following changes since commit f259e4cb8a8b4ef5463326fc214a7d8d7703d5de:

  Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging (2024-08-24 08:09:27 +1000)

are available in the Git repository at:

  https://gitlab.com/thuth/qemu.git tags/pull-request-2024-08-26

for you to fetch changes up to aee07f2563d27167935ae3557a9f435937eb3f9f:

  tests/qtest: Delete previous boot file (2024-08-26 10:58:11 +0200)

----------------------------------------------------------------
* Disable the broken qtests in the MSYS2 CI job
* Replace deprecated keyword in the Cirrus-CI scripts
* Fix a simple leak in the migration-test qtest

----------------------------------------------------------------
Akihiko Odaki (1):
      tests/qtest: Delete previous boot file

Philippe Mathieu-Daudé (1):
      gitlab-ci: Replace build_script -> step_script in Cirrus jobs

Thomas Huth (1):
      .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job

 tests/qtest/migration-test.c  | 18 +++++++++++-------
 .gitlab-ci.d/cirrus/build.yml |  2 +-
 .gitlab-ci.d/windows.yml      | 26 ++------------------------
 3 files changed, 14 insertions(+), 32 deletions(-)



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PULL 1/3] gitlab-ci: Replace build_script -> step_script in Cirrus jobs
  2024-08-26  9:43 [PULL 0/3] Optional fixes for 9.1.0-rc4 Thomas Huth
@ 2024-08-26  9:43 ` Thomas Huth
  2024-08-26  9:43 ` [PULL 2/3] .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job Thomas Huth
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2024-08-26  9:43 UTC (permalink / raw)
  To: qemu-devel, Richard Henderson

From: Philippe Mathieu-Daudé <philmd@linaro.org>

Long due upgrade, see [1]:

  In GitLab Runner 13.2 a translation for step_script to
  build_script was added to the custom executor. In 14.0
  the build_script stage will be replaced with step_script.

We are using GitLab 17 [2]!

This removes the following warning:

  WARNING: Starting with version 17.0 the 'build_script'
  stage will be replaced with 'step_script':
  https://gitlab.com/groups/gitlab-org/-/epics/6112

[1] https://about.gitlab.com/releases/2021/05/22/gitlab-13-12-released/#remove-translation-from-stepscript-to-buildscript-in-custom-executor
[2] https://about.gitlab.com/releases/2024/05/16/gitlab-17-0-released/

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240816213203.18350-1-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.d/cirrus/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
index 43dd52dd19..102cdbd8b1 100644
--- a/.gitlab-ci.d/cirrus/build.yml
+++ b/.gitlab-ci.d/cirrus/build.yml
@@ -26,7 +26,7 @@ build_task:
     - git clone --depth 100 "$CI_REPOSITORY_URL" .
     - git fetch origin "$CI_COMMIT_REF_NAME"
     - git reset --hard "$CI_COMMIT_SHA"
-  build_script:
+  step_script:
     - mkdir build
     - cd build
     - ../configure --enable-werror $CONFIGURE_ARGS
-- 
2.46.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PULL 2/3] .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job
  2024-08-26  9:43 [PULL 0/3] Optional fixes for 9.1.0-rc4 Thomas Huth
  2024-08-26  9:43 ` [PULL 1/3] gitlab-ci: Replace build_script -> step_script in Cirrus jobs Thomas Huth
@ 2024-08-26  9:43 ` Thomas Huth
  2024-08-26  9:43 ` [PULL 3/3] tests/qtest: Delete previous boot file Thomas Huth
  2024-08-26 21:06 ` [PULL 0/3] Optional fixes for 9.1.0-rc4 Richard Henderson
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2024-08-26  9:43 UTC (permalink / raw)
  To: qemu-devel, Richard Henderson

The qtests are broken since a while in the MSYS2 job in the gitlab-CI,
likely due to some changes in the MSYS2 environment. So far nobody has
neither a clue what's going wrong here, nor an idea how to fix this
(in fact most QEMU developers even don't have a Windows environment
available for properly analyzing this problem), so we should disable the
qtests here for the time being to get at least test coverage again
for the remaining tests that are run here.

Since we already get compile-test coverage for the system emulation
in the cross-win64-system job, and since the MSYS2 job is one of the
longest running jobs in our CI (it takes more than 1 hour to complete),
let's seize the opportunity and also cut the run time by disabling
the system emulation completely here, including the libraries that
are only useful for system emulation. In case somebody ever figures
out the failure of the qtests on MSYS2, we can revert this patch
to get everything back.

Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240820170142.55324-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.d/windows.yml | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)

diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
index a83f23a786..759e9a76b5 100644
--- a/.gitlab-ci.d/windows.yml
+++ b/.gitlab-ci.d/windows.yml
@@ -17,12 +17,7 @@ msys2-64bit:
     # This feature doesn't (currently) work with PowerShell, it stops
     # the echo'ing of commands being run and doesn't show any timing
     FF_SCRIPT_SECTIONS: 0
-    # do not remove "--without-default-devices"!
-    # commit 9f8e6cad65a6 ("gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices"
-    # changed to compile QEMU with the --without-default-devices switch
-    # for this job, because otherwise the build could not complete within
-    # the project timeout.
-    CONFIGURE_ARGS:  --target-list=sparc-softmmu --without-default-devices -Ddebug=false -Doptimization=0
+    CONFIGURE_ARGS: --disable-system --enable-tools -Ddebug=false -Doptimization=0
     # The Windows git is a bit older so override the default
     GIT_FETCH_EXTRA_FLAGS: --no-tags --prune --quiet
   artifacts:
@@ -81,33 +76,16 @@ msys2-64bit:
       bison diffutils flex
       git grep make sed
       mingw-w64-x86_64-binutils
-      mingw-w64-x86_64-capstone
       mingw-w64-x86_64-ccache
       mingw-w64-x86_64-curl
-      mingw-w64-x86_64-cyrus-sasl
-      mingw-w64-x86_64-dtc
       mingw-w64-x86_64-gcc
       mingw-w64-x86_64-glib2
-      mingw-w64-x86_64-gnutls
-      mingw-w64-x86_64-gtk3
-      mingw-w64-x86_64-libgcrypt
-      mingw-w64-x86_64-libjpeg-turbo
       mingw-w64-x86_64-libnfs
-      mingw-w64-x86_64-libpng
       mingw-w64-x86_64-libssh
-      mingw-w64-x86_64-libtasn1
-      mingw-w64-x86_64-libusb
-      mingw-w64-x86_64-lzo2
-      mingw-w64-x86_64-nettle
       mingw-w64-x86_64-ninja
       mingw-w64-x86_64-pixman
       mingw-w64-x86_64-pkgconf
       mingw-w64-x86_64-python
-      mingw-w64-x86_64-SDL2
-      mingw-w64-x86_64-SDL2_image
-      mingw-w64-x86_64-snappy
-      mingw-w64-x86_64-spice
-      mingw-w64-x86_64-usbredir
       mingw-w64-x86_64-zstd"
   - Write-Output "Running build at $(Get-Date -Format u)"
   - $env:CHERE_INVOKING = 'yes'  # Preserve the current working directory
@@ -120,7 +98,7 @@ msys2-64bit:
   - mkdir build
   - cd build
   - ..\msys64\usr\bin\bash -lc "ccache --zero-stats"
-  - ..\msys64\usr\bin\bash -lc "../configure --enable-fdt=system $CONFIGURE_ARGS"
+  - ..\msys64\usr\bin\bash -lc "../configure $CONFIGURE_ARGS"
   - ..\msys64\usr\bin\bash -lc "make"
   - ..\msys64\usr\bin\bash -lc "make check MTESTARGS='$TEST_ARGS' || { cat meson-logs/testlog.txt; exit 1; } ;"
   - ..\msys64\usr\bin\bash -lc "ccache --show-stats"
-- 
2.46.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PULL 3/3] tests/qtest: Delete previous boot file
  2024-08-26  9:43 [PULL 0/3] Optional fixes for 9.1.0-rc4 Thomas Huth
  2024-08-26  9:43 ` [PULL 1/3] gitlab-ci: Replace build_script -> step_script in Cirrus jobs Thomas Huth
  2024-08-26  9:43 ` [PULL 2/3] .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job Thomas Huth
@ 2024-08-26  9:43 ` Thomas Huth
  2024-08-26 21:06 ` [PULL 0/3] Optional fixes for 9.1.0-rc4 Richard Henderson
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2024-08-26  9:43 UTC (permalink / raw)
  To: qemu-devel, Richard Henderson

From: Akihiko Odaki <akihiko.odaki@daynix.com>

A test run may create boot files several times. Delete the previous boot
file before creating a new one.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20240823-san-v4-7-a24c6dfa4ceb@daynix.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/migration-test.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 70b606b888..6c06100d91 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -144,12 +144,23 @@ static char *bootpath;
 #include "tests/migration/ppc64/a-b-kernel.h"
 #include "tests/migration/s390x/a-b-bios.h"
 
+static void bootfile_delete(void)
+{
+    unlink(bootpath);
+    g_free(bootpath);
+    bootpath = NULL;
+}
+
 static void bootfile_create(char *dir, bool suspend_me)
 {
     const char *arch = qtest_get_arch();
     unsigned char *content;
     size_t len;
 
+    if (bootpath) {
+        bootfile_delete();
+    }
+
     bootpath = g_strdup_printf("%s/bootsect", dir);
     if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
         /* the assembled x86 boot sector should be exactly one sector large */
@@ -177,13 +188,6 @@ static void bootfile_create(char *dir, bool suspend_me)
     fclose(bootfile);
 }
 
-static void bootfile_delete(void)
-{
-    unlink(bootpath);
-    g_free(bootpath);
-    bootpath = NULL;
-}
-
 /*
  * Wait for some output in the serial output file,
  * we get an 'A' followed by an endless string of 'B's
-- 
2.46.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PULL 0/3] Optional fixes for 9.1.0-rc4
  2024-08-26  9:43 [PULL 0/3] Optional fixes for 9.1.0-rc4 Thomas Huth
                   ` (2 preceding siblings ...)
  2024-08-26  9:43 ` [PULL 3/3] tests/qtest: Delete previous boot file Thomas Huth
@ 2024-08-26 21:06 ` Richard Henderson
  3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2024-08-26 21:06 UTC (permalink / raw)
  To: Thomas Huth, qemu-devel

On 8/26/24 19:43, Thomas Huth wrote:
>   Hi Richard,
> 
> since it seems like we're going to have RC4, here are some minor
> fixes that could still be included.
> 
> The following changes since commit f259e4cb8a8b4ef5463326fc214a7d8d7703d5de:
> 
>    Merge tag 'pull-trivial-patches' ofhttps://gitlab.com/mjt0k/qemu into staging (2024-08-24 08:09:27 +1000)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/thuth/qemu.git tags/pull-request-2024-08-26
> 
> for you to fetch changes up to aee07f2563d27167935ae3557a9f435937eb3f9f:
> 
>    tests/qtest: Delete previous boot file (2024-08-26 10:58:11 +0200)
> 
> ----------------------------------------------------------------
> * Disable the broken qtests in the MSYS2 CI job
> * Replace deprecated keyword in the Cirrus-CI scripts
> * Fix a simple leak in the migration-test qtest


Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/9.1 as appropriate.

r~


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-08-26 21:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26  9:43 [PULL 0/3] Optional fixes for 9.1.0-rc4 Thomas Huth
2024-08-26  9:43 ` [PULL 1/3] gitlab-ci: Replace build_script -> step_script in Cirrus jobs Thomas Huth
2024-08-26  9:43 ` [PULL 2/3] .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job Thomas Huth
2024-08-26  9:43 ` [PULL 3/3] tests/qtest: Delete previous boot file Thomas Huth
2024-08-26 21:06 ` [PULL 0/3] Optional fixes for 9.1.0-rc4 Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).