From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
pkrempa@redhat.com, "Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
armbru@redhat.com, "Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [PATCH v3 0/2] qdev-monitor: avoid QemuOpts in QMP device_add()
Date: Tue, 27 Aug 2024 15:27:49 -0400 [thread overview]
Message-ID: <20240827192751.948633-1-stefanha@redhat.com> (raw)
v3:
- Duplicate drain_call_rcu() into hmp_device_add() because moving it into
qdev_device_add_from_qdict turned out to be unsafe.
v2:
- Rename Patch 1 to indicate that we're avoiding QemuOpts rather than doing a
full conversion to QAPI. Also mention that 'gen': false is still being used.
[Markus]
- Add Patch 2 to address a TODO comment suggesting that
qemu_create_cli_devices() should call qmp_device_add(). [Markus]
- Move drain_call_rcu() into qdev_device_add_from_qdict() to avoid code
duplication. [Markus]
This series enables non-scalar parameter parsing in device_add (e.g.
virtio-blk-pci,iothread-vq-mapping=). Stop converting from QDict to QemuOpts
and back again as this loses type information and cannot represent non-scalars.
Stefan Hajnoczi (2):
qdev-monitor: avoid QemuOpts in QMP device_add
vl: use qmp_device_add() in qemu_create_cli_devices()
system/qdev-monitor.c | 44 ++++++++++++++++++++++++++++---------------
system/vl.c | 14 ++++----------
2 files changed, 33 insertions(+), 25 deletions(-)
--
2.46.0
next reply other threads:[~2024-08-27 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 19:27 Stefan Hajnoczi [this message]
2024-08-27 19:27 ` [PATCH v3 1/2] qdev-monitor: avoid QemuOpts in QMP device_add Stefan Hajnoczi
2024-08-28 14:19 ` Daniel P. Berrangé
2024-08-30 7:29 ` Markus Armbruster
2024-11-06 10:55 ` Kevin Wolf
2024-08-27 19:27 ` [PATCH v3 2/2] vl: use qmp_device_add() in qemu_create_cli_devices() Stefan Hajnoczi
2024-08-28 14:20 ` Daniel P. Berrangé
2024-11-06 10:58 ` [PATCH v3 0/2] qdev-monitor: avoid QemuOpts in QMP device_add() Kevin Wolf
2024-11-14 16:05 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827192751.948633-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).