From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54E04C54EE3 for ; Wed, 28 Aug 2024 11:48:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sjH8m-0005OD-0x; Wed, 28 Aug 2024 07:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjH8l-0005Nj-4F for qemu-devel@nongnu.org; Wed, 28 Aug 2024 07:47:07 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjH8j-00056h-9G for qemu-devel@nongnu.org; Wed, 28 Aug 2024 07:47:06 -0400 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wv2cK2XLQz6J7rT; Wed, 28 Aug 2024 19:43:45 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 84D34140B67; Wed, 28 Aug 2024 19:47:01 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 12:47:01 +0100 Date: Wed, 28 Aug 2024 12:47:00 +0100 To: CC: , , , , , , , Fan Ni Subject: Re: [PATCH 1/2] hw/mem/cxl_type3: Fix More flag setting for dynamic capacity event records Message-ID: <20240828124700.0000151d@Huawei.com> In-Reply-To: <20240827164304.88876-2-nifan.cxl@gmail.com> References: <20240827164304.88876-1-nifan.cxl@gmail.com> <20240827164304.88876-2-nifan.cxl@gmail.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, 27 Aug 2024 09:40:04 -0700 nifan.cxl@gmail.com wrote: > From: Fan Ni > > Per cxl spec r3.1, for multiple dynamic capacity event records grouped via > the More flag, the last record in the sequence should clear the More flag. > > Before the change, the More flag of the event record is cleared before > the loop of inserting records into the event log, which will leave the flag > always set once it is set in the loop. > > Signed-off-by: Fan Ni Oops. I'll queue this up, though not sure I'll get a fixes series out this week so it might only hit after the QEMU release. Jonathan > --- > hw/mem/cxl_type3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c > index d648192ab9..e616801c81 100644 > --- a/hw/mem/cxl_type3.c > +++ b/hw/mem/cxl_type3.c > @@ -2060,11 +2060,11 @@ static void qmp_cxl_process_dynamic_capacity_prescriptive(const char *path, > stw_le_p(&dCap.host_id, hid); > /* only valid for DC_REGION_CONFIG_UPDATED event */ > dCap.updated_region_id = 0; > - dCap.flags = 0; > for (i = 0; i < num_extents; i++) { > memcpy(&dCap.dynamic_capacity_extent, &extents[i], > sizeof(CXLDCExtentRaw)); > > + dCap.flags = 0; > if (i < num_extents - 1) { > /* Set "More" flag */ > dCap.flags |= BIT(0);