From: Pavel Pisa <pisa@fel.cvut.cz>
To: Doug Brown <doug@schmorgal.com>
Cc: Francisco Iglesias <francisco.iglesias@amd.com>,
Jason Wang <jasowang@redhat.com>, Paolo Bonzini <bonzini@gnu.org>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 1/7] hw/net/can/xlnx-versal-canfd: Fix interrupt level
Date: Thu, 29 Aug 2024 15:08:00 +0200 [thread overview]
Message-ID: <202408291508.00537.pisa@fel.cvut.cz> (raw)
In-Reply-To: <20240827034927.66659-2-doug@schmorgal.com>
On Tuesday 27 of August 2024 05:49:21 Doug Brown wrote:
> The interrupt level should be 0 or 1. The existing code was using the
> interrupt flags to determine the level. In the only machine currently
> supported (xlnx-versal-virt), the GICv3 was masking off all bits except
> bit 0 when applying it, resulting in the IRQ never being delivered.
>
> Signed-off-by: Doug Brown <doug@schmorgal.com>
> Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com>
Reviewed-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
--
Pavel Pisa
phone: +420 603531357
e-mail: pisa@cmp.felk.cvut.cz
Department of Control Engineering FEE CVUT
Karlovo namesti 13, 121 35, Prague 2
university: http://control.fel.cvut.cz/
personal: http://cmp.felk.cvut.cz/~pisa
social: https://social.kernel.org/ppisa
projects: https://www.openhub.net/accounts/ppisa
CAN related:http://canbus.pages.fel.cvut.cz/
RISC-V education: https://comparch.edu.cvut.cz/
Open Technologies Research Education and Exchange Services
https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
next prev parent reply other threads:[~2024-08-29 13:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 3:49 [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes Doug Brown
2024-08-27 3:49 ` [PATCH v2 1/7] hw/net/can/xlnx-versal-canfd: Fix interrupt level Doug Brown
2024-08-29 13:08 ` Pavel Pisa [this message]
2024-08-27 3:49 ` [PATCH v2 2/7] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check Doug Brown
2024-08-29 13:09 ` Pavel Pisa
2024-08-27 3:49 ` [PATCH v2 3/7] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers Doug Brown
2024-08-29 13:11 ` Pavel Pisa
2024-08-27 3:49 ` [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly Doug Brown
2024-08-29 13:13 ` Pavel Pisa
2024-08-27 3:49 ` [PATCH v2 5/7] hw/net/can/xlnx-versal-canfd: Fix byte ordering Doug Brown
2024-08-29 13:15 ` Pavel Pisa
2024-08-27 3:49 ` [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions Doug Brown
2024-08-29 13:17 ` Pavel Pisa
2024-09-04 23:33 ` Francisco Iglesias
2024-08-27 3:49 ` [PATCH v2 7/7] hw/net/can/xlnx-versal-canfd: Fix FIFO issues Doug Brown
2024-08-29 13:24 ` Pavel Pisa
2024-08-30 0:11 ` Doug Brown
2024-09-06 16:35 ` Francisco Iglesias
2024-09-06 14:36 ` [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes Peter Maydell
2024-09-06 15:48 ` Francisco Iglesias
2024-09-09 13:55 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408291508.00537.pisa@fel.cvut.cz \
--to=pisa@fel.cvut.cz \
--cc=bonzini@gnu.org \
--cc=doug@schmorgal.com \
--cc=francisco.iglesias@amd.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).