From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 531F7C83F16 for ; Thu, 29 Aug 2024 13:09:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sjesi-0002Hy-JI; Thu, 29 Aug 2024 09:08:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjesh-0002HF-0k for qemu-devel@nongnu.org; Thu, 29 Aug 2024 09:08:07 -0400 Received: from smtpx.feld.cvut.cz ([147.32.210.153] helo=smtpx.fel.cvut.cz) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1sjesd-0004xL-JJ for qemu-devel@nongnu.org; Thu, 29 Aug 2024 09:08:06 -0400 Received: from localhost (unknown [192.168.200.27]) by smtpx.fel.cvut.cz (Postfix) with ESMTP id CFEC139D6C; Thu, 29 Aug 2024 15:07:57 +0200 (CEST) X-Virus-Scanned: IMAP STYX AMAVIS Received: from smtpx.fel.cvut.cz ([192.168.200.2]) by localhost (cerokez-250.feld.cvut.cz [192.168.200.27]) (amavis, port 10060) with ESMTP id imRQovtThQzF; Thu, 29 Aug 2024 15:07:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fel.cvut.cz; s=felmail; t=1724936875; bh=MS+HAijVI95lz0e6SLIAjIVuMoSuJ0MkS1S0AmAIoOQ=; h=From:To:Subject:Date:Cc:References:In-Reply-To:From; b=VIR8pEiQPuYHdRHCWiRWIUoYXhICdm1H/Akn81f42+fIP04INRfJTvezJ7vNsWkYV I3VENdR6m84EkQoEd7M/0h2VdFmHzcgdhNjx5XZIaAy63tetYCoShN93My+ARponbj yLj+fhjmb1zr3E67UenbldLqY1Mqj/s3fDshE6Rz8TFeT47mBBkHxBSBgqgwph07BR 1aBHHsMRPO28b8jYrKDLuq0mU7RiFJo1bq3QqiwN2udEMqPWYVp756dQ9x9VjtOMPK VQS22Q94Gg0By2r0LaxJofqwVuikuW/l6lRh9TUERJHfbeuYA3vwgz8rCYSH8yL93w Q29hYqNjx+8AA== Received: from [147.32.86.193] (unknown [147.32.86.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pisa) by smtpx.fel.cvut.cz (Postfix) with ESMTPSA id 3E4F539F68; Thu, 29 Aug 2024 15:07:55 +0200 (CEST) From: Pavel Pisa To: Doug Brown Subject: Re: [PATCH v2 1/7] hw/net/can/xlnx-versal-canfd: Fix interrupt level Date: Thu, 29 Aug 2024 15:08:00 +0200 User-Agent: KMail/1.9.10 Cc: Francisco Iglesias , Jason Wang , Paolo Bonzini , qemu-devel@nongnu.org, Peter Maydell References: <20240827034927.66659-1-doug@schmorgal.com> <20240827034927.66659-2-doug@schmorgal.com> In-Reply-To: <20240827034927.66659-2-doug@schmorgal.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <202408291508.00537.pisa@fel.cvut.cz> Received-SPF: pass client-ip=147.32.210.153; envelope-from=pisa@fel.cvut.cz; helo=smtpx.fel.cvut.cz X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-1.084, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tuesday 27 of August 2024 05:49:21 Doug Brown wrote: > The interrupt level should be 0 or 1. The existing code was using the > interrupt flags to determine the level. In the only machine currently > supported (xlnx-versal-virt), the GICv3 was masking off all bits except > bit 0 when applying it, resulting in the IRQ never being delivered. > > Signed-off-by: Doug Brown > Reviewed-by: Francisco Iglesias Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: pisa@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Prague 2 university: http://control.fel.cvut.cz/ personal: http://cmp.felk.cvut.cz/~pisa social: https://social.kernel.org/ppisa projects: https://www.openhub.net/accounts/ppisa CAN related:http://canbus.pages.fel.cvut.cz/ RISC-V education: https://comparch.edu.cvut.cz/ Open Technologies Research Education and Exchange Services https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home