From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>
Cc: <quic_llindhol@quicinc.com>, <peter.maydell@linaro.org>,
<marcin.juszkiewicz@linaro.org>, <qemu-devel@nongnu.org>,
<linux-cxl@vger.kernel.org>, <qemu-arm@nongnu.org>,
<chenbaozi@phytium.com.cn>, <wangyinfeng@phytium.com.cn>,
<shuyiqi@phytium.com.cn>
Subject: Re: [RFC PATCH 0/2] Sbsa-ref CXL Enablement
Date: Fri, 30 Aug 2024 12:18:29 +0100 [thread overview]
Message-ID: <20240830121829.00005d79@Huawei.com> (raw)
In-Reply-To: <20240830041557.600607-1-wangyuquan1236@phytium.com.cn>
On Fri, 30 Aug 2024 12:15:55 +0800
Yuquan Wang <wangyuquan1236@phytium.com.cn> wrote:
> RFC because
> - Many contents are ported from Jonathan' patch on qemu virt design
>
> - Bring plenty of PCDs values and modifying the original PCIE values
>
> - Less experience and not particularly confident in ACPI area so this might be
> stupidly broken in a way I've not considered.
Hi Yuquan,
So an opening question for you. What do you want to use this for?
If the aim is to do full software stack verification, I'd be tempted to
make a slightly more complex setup from the start and have at least
2 CXL host bridges so that you can enable interleaving + probably 2 or
3 CFMWS so that you can test that interleaving.
Even then it won't meet my requirements which is to stress the software
stack but then that's not the aim of sbsa ref so fair enough.
What you have here looks good to me in general, just superficial
suggestions in the various patches.
Thanks,
Jonathan
prev parent reply other threads:[~2024-08-30 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 4:15 [RFC PATCH 0/2] Sbsa-ref CXL Enablement Yuquan Wang
2024-08-30 4:15 ` [RFC PATCH 1/2] hw/arm/sbsa-ref: Enable CXL Host Bridge by pxb-cxl Yuquan Wang
2024-08-30 9:52 ` Jonathan Cameron via
2024-09-09 10:05 ` Marcin Juszkiewicz
2024-10-24 10:10 ` Yuquan Wang
2024-08-30 4:15 ` [RFC PATCH 2/2] hw/arm/sbsa-ref: Support CXL Fixed Memory Window Yuquan Wang
2024-08-30 10:23 ` Jonathan Cameron via
2024-08-30 11:18 ` Jonathan Cameron via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830121829.00005d79@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=chenbaozi@phytium.com.cn \
--cc=linux-cxl@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=shuyiqi@phytium.com.cn \
--cc=wangyinfeng@phytium.com.cn \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).