From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EB81CA0ED3 for ; Mon, 2 Sep 2024 05:50:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1skzwq-0007SA-BD; Mon, 02 Sep 2024 01:49:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skzwn-0007Pr-Kq; Mon, 02 Sep 2024 01:49:53 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skzwl-0003sF-FF; Mon, 02 Sep 2024 01:49:53 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 481CR3Qu014836; Mon, 2 Sep 2024 05:49:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=pp1; bh=+rl105i1zApPYavmnKj17bx74VZ AR8P/5W7Vha4SEAs=; b=eLbM0B6fRRvVKye4xqQXP/NBNyhEtR4dKhhfJw0Bxlz f0x5k1PInTYJJ8TSAWkRByoYi5XXc0vrzuXpT5lh5dIjVhC4ehi3o3M6qOYBG/hL 1kr95mMMT2Dz8OlQqBLPL5cSNth5grFt9trutRn1g7Asmbs0FnnXl8frSQhmbYNE Wq8oeJwly5gO2VQAN5YUsEowm7PQZzr18z24DiiAq8Ea/ns9oz60vl42QDjH3bIB FY2Q0IPURgUD7Ym+xcfOz5MT9iDBEE4b53qU0725ypCrLLSkKJ5+un6fwod6q660 dtomhJRCEf2ACSZhyV7WtRiFmrEfOXNUGryRn5+cUfw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41btty77sx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2024 05:49:39 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4825ndYY016798; Mon, 2 Sep 2024 05:49:39 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41btty77sv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2024 05:49:39 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48248KCN000941; Mon, 2 Sep 2024 05:49:38 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 41cf0mmnxs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2024 05:49:38 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4825nZZH57344266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 2 Sep 2024 05:49:35 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CE9F20040; Mon, 2 Sep 2024 05:49:35 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26E6720043; Mon, 2 Sep 2024 05:49:33 +0000 (GMT) Received: from li-e7e2bd4c-2dae-11b2-a85c-bfd29497117c.ibm.com (unknown [9.195.47.119]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 2 Sep 2024 05:49:32 +0000 (GMT) Date: Mon, 2 Sep 2024 11:19:28 +0530 From: Amit Machhiwal To: Aditya Gupta Cc: Mahesh J Salgaonkar , Madhavan Srinivasan , Nicholas Piggin , =?utf-8?Q?C=C3=A9dric?= Le Goater , Harsh Prateek Bora , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Subject: Re: [PATCH v6 RESEND 0/5] Power11 support for QEMU [PSeries] Message-ID: <20240902111703.0faafa80-d0-amachhiw@linux.ibm.com> Mail-Followup-To: Aditya Gupta , Mahesh J Salgaonkar , Madhavan Srinivasan , Nicholas Piggin , =?utf-8?Q?C=C3=A9dric?= Le Goater , Harsh Prateek Bora , qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20240731055022.696051-1-adityag@linux.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240731055022.696051-1-adityag@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: djet6HbkZmqx_fD-sFiBcmL9Vn9nrJmA X-Proofpoint-ORIG-GUID: 6vdBbGgKB2tMtNrx41I4KGGuZoMd9p18 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-09-01_06,2024-08-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_spam_definite policy=outbound score=100 clxscore=1015 mlxlogscore=-999 suspectscore=0 mlxscore=100 bulkscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 spamscore=100 adultscore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2409020045 Received-SPF: pass client-ip=148.163.158.5; envelope-from=amachhiw@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2024/07/31 11:20 AM, Aditya Gupta wrote: > Overview > ============ > > Split "Power11 support for QEMU" into 2 patch series: pseries & powernv. > > This patch series is for pseries support for Power11. > > As Power11 core is same as Power10, hence much of the code has been reused from > Power10. > > Power11 was added in Linux in: > commit c2ed087ed35c ("powerpc: Add Power11 architected and raw mode") > > Git Tree for Testing > ==================== > > QEMU: https://github.com/adi-g15-ibm/qemu/tree/p11-v6-pseries > > Has been tested with following cases: > * '-M pseries' / '-M pseries -cpu Power11' > I could boot a Power11 pseries KVM guest with this patch series applied which does not work without it. Command Used: qemu-system-ppc64 -m 4G -smp 4 -nographic -drive file=/root/testing/debian-12-generic-ppc64el.qcow2,format=qcow2 -accel tcg -cpu Power11 Tested-by: Amit Machhiwal > * '-smp' option tested > * with compat mode: 'max-cpu-compat=power10' and 'max-cpu-compat=power9' > * with/without device 'virtio-scsi-pci' > * with/without -kernel and -drive with qcow_file > > Linux with Power11 support: https://github.com/torvalds/linux, since v6.9-rc1 > > Changelog > ========= > v6 RESEND: > + added my initials instead of PMM in patch #1 description > > v6: > + reorganised patches such that Power11 introduction is at end, and > cleanups and fixes is done before > + patch #1: renamed macros from POWER_* to PCC_* > + patch #2: rename 'logical_pvr' to 'spapr_logical_pvr' to better convey > the context > > v5: > + split patch series into pseries+powernv > + patch #1: apply harsh's patch to reduce duplication > + patch #2: simplified, by removing duplication > + patch #3: update docs, according to harsh's suggestion > + patch #4: no functional change, #define used for P9 & P10 pcr_supported > + patch #5: no change > > v4: > + patch #5: fix memory leak in pnv_chip_power10_quad_realize > - no change in other patches > > v3: > + patch #1: version power11 as power11_v2.0 > + patch #2: split target hw/pseries code into patch #2 > + patch #3,#4: fix regression due to Power10 and Power11 having same PCR > + patch #5: create pnv_chip_power11_dt_populate and split pnv_chip_power10_common_realize as per review > + patch #6-#11: no change > - remove commit to make Power11 as default > > v2: > + split powernv patch into homer,lpc,occ,psi,sbe > + reduce code duplication by reusing power10 code > + make power11 as default > + rebase on qemu upstream/master > + add more information in commit descriptions > + update docs > + update skiboot.lid > > > Aditya Gupta (4): > target/ppc: Introduce 'PowerPCCPUClass::spapr_logical_pvr' > target/ppc: Fix regression due to Power10 and Power11 having same PCR > target/ppc: Add Power11 DD2.0 processor > ppc/pseries: Add Power11 cpu type > > Harsh Prateek Bora (1): > target/ppc: Reduce code duplication across Power9/10 init code > > docs/system/ppc/pseries.rst | 17 +++- > hw/ppc/spapr_cpu_core.c | 1 + > target/ppc/compat.c | 11 +++ > target/ppc/cpu-models.c | 3 + > target/ppc/cpu-models.h | 3 + > target/ppc/cpu.h | 3 + > target/ppc/cpu_init.c | 188 +++++++++++++++--------------------- > target/ppc/cpu_init.h | 92 ++++++++++++++++++ > 8 files changed, 205 insertions(+), 113 deletions(-) > create mode 100644 target/ppc/cpu_init.h > > -- > 2.45.2 > >