qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ani Sinha <anisinha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
Cc: Ani Sinha <anisinha@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [PATCH 2/2] kvm/i386: do not initialize identity_base variable
Date: Tue,  3 Sep 2024 18:11:43 +0530	[thread overview]
Message-ID: <20240903124143.39345-3-anisinha@redhat.com> (raw)
In-Reply-To: <20240903124143.39345-1-anisinha@redhat.com>

identity_base variable is first initialzied to address 0xfffbc000 and then
kvm_vm_set_identity_map_addr() overrides this value to address 0xfeffc000.
The initial address to which the variable was initialized was never used. Clean
it up.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
 target/i386/kvm/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 574c62c21a..c8face0eeb 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -3187,7 +3187,7 @@ static void kvm_vm_enable_energy_msrs(KVMState *s)
 
 int kvm_arch_init(MachineState *ms, KVMState *s)
 {
-    uint64_t identity_base = 0xfffbc000;
+    uint64_t identity_base;
     int ret;
     struct utsname utsname;
     Error *local_err = NULL;
-- 
2.42.0



  parent reply	other threads:[~2024-09-03 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 12:41 [PATCH 0/2] kvm/i386: Some code refactoring and cleanups for kvm_arch_init Ani Sinha
2024-09-03 12:41 ` [PATCH 1/2] kvm/i386: refactor kvm_arch_init and split it into smaller functions Ani Sinha
2024-09-03 12:41 ` Ani Sinha [this message]
2024-09-04 12:31 ` [PATCH 0/2] kvm/i386: Some code refactoring and cleanups for kvm_arch_init Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903124143.39345-3-anisinha@redhat.com \
    --to=anisinha@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).