From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, andrew@codeconstruct.com.au,
andrew@daynix.com, arei.gonglei@huawei.com, berrange@redhat.com,
berto@igalia.com, borntraeger@linux.ibm.com, clg@kaod.org,
david@redhat.com, den@openvz.org, eblake@redhat.com,
eduardo@habkost.net, farman@linux.ibm.com, farosas@suse.de,
hreitz@redhat.com, idryomov@gmail.com, iii@linux.ibm.com,
jamin_lin@aspeedtech.com, jasowang@redhat.com, joel@jms.id.au,
jsnow@redhat.com, kwolf@redhat.com, leetroy@gmail.com,
marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com,
michael.roth@amd.com, mst@redhat.com, mtosatti@redhat.com,
nsg@linux.ibm.com, pasic@linux.ibm.com, pbonzini@redhat.com,
peter.maydell@linaro.org, peterx@redhat.com, philmd@linaro.org,
pizhenwei@bytedance.com, pl@dlhnet.de,
richard.henderson@linaro.org, stefanha@redhat.com,
steven_lee@aspeedtech.com, thuth@redhat.com,
vsementsov@yandex-team.ru, wangyanan55@huawei.com,
yuri.benditovich@daynix.com, zhao1.liu@intel.com,
qemu-block@nongnu.org, qemu-arm@nongnu.org,
qemu-s390x@nongnu.org, kvm@vger.kernel.org, avihaih@nvidia.com
Subject: [PATCH v2 19/19] qapi/vfio: Rename VfioMigrationState to Qapi*, and drop prefix
Date: Wed, 4 Sep 2024 13:18:36 +0200 [thread overview]
Message-ID: <20240904111836.3273842-20-armbru@redhat.com> (raw)
In-Reply-To: <20240904111836.3273842-1-armbru@redhat.com>
QAPI's 'prefix' feature can make the connection between enumeration
type and its constants less than obvious. It's best used with
restraint.
VfioMigrationState has a 'prefix' that overrides the generated
enumeration constants' prefix to QAPI_VFIO_MIGRATION_STATE.
We could simply drop 'prefix', but then the enumeration constants
would look as if they came from kernel header linux/vfio.h.
Rename the type to QapiVfioMigrationState instead, so that 'prefix' is
not needed.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/vfio.json | 9 ++++-----
hw/vfio/migration.c | 2 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/qapi/vfio.json b/qapi/vfio.json
index eccca82068..b53b7caecd 100644
--- a/qapi/vfio.json
+++ b/qapi/vfio.json
@@ -7,7 +7,7 @@
##
##
-# @VfioMigrationState:
+# @QapiVfioMigrationState:
#
# An enumeration of the VFIO device migration states.
#
@@ -32,10 +32,9 @@
#
# Since: 9.1
##
-{ 'enum': 'VfioMigrationState',
+{ 'enum': 'QapiVfioMigrationState',
'data': [ 'stop', 'running', 'stop-copy', 'resuming', 'running-p2p',
- 'pre-copy', 'pre-copy-p2p' ],
- 'prefix': 'QAPI_VFIO_MIGRATION_STATE' }
+ 'pre-copy', 'pre-copy-p2p' ] }
##
# @VFIO_MIGRATION:
@@ -63,5 +62,5 @@
'data': {
'device-id': 'str',
'qom-path': 'str',
- 'device-state': 'VfioMigrationState'
+ 'device-state': 'QapiVfioMigrationState'
} }
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 262d42a46e..17199b73ae 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -81,7 +81,7 @@ static const char *mig_state_to_str(enum vfio_device_mig_state state)
}
}
-static VfioMigrationState
+static QapiVfioMigrationState
mig_state_to_qapi_state(enum vfio_device_mig_state state)
{
switch (state) {
--
2.46.0
next prev parent reply other threads:[~2024-09-04 11:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:18 [PATCH v2 00/19] qapi: Reduce use of 'prefix' Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 01/19] qapi: Smarter camel_to_upper() to reduce need for 'prefix' Markus Armbruster
2024-09-04 12:18 ` Daniel P. Berrangé
2024-09-05 5:59 ` Markus Armbruster
2024-09-05 15:52 ` Daniel P. Berrangé
2024-09-05 16:07 ` Peter Xu
2024-09-04 11:18 ` [PATCH v2 02/19] tests/qapi-schema: Drop temporary 'prefix' Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 03/19] qapi/block-core: " Markus Armbruster
2024-09-30 13:23 ` Vladimir Sementsov-Ogievskiy
2024-09-30 13:28 ` Vladimir Sementsov-Ogievskiy
2024-09-04 11:18 ` [PATCH v2 04/19] qapi/common: " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 05/19] qapi/crypto: " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 06/19] qapi/ebpf: " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 07/19] qapi/machine: " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 08/19] qapi/ui: " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 09/19] qapi/machine: Rename CpuS390* to S390Cpu*, and drop 'prefix' Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 10/19] qapi/crypto: Drop unwanted 'prefix' Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 11/19] qapi/crypto: Rename QCryptoHashAlgorithm to *Algo, and drop prefix Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 12/19] qapi/crypto: Rename QCryptoCipherAlgorithm " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 13/19] qapi/crypto: Rename QCryptoIVGenAlgorithm " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 14/19] qapi/crypto: Rename QCryptoAkCipherAlgorithm " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 15/19] qapi/crypto: Rename QCryptoRSAPaddingAlgorithm " Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 16/19] qapi/crypto: Rename QCryptoAFAlg to QCryptoAFAlgo Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 17/19] qapi/cryptodev: Drop unwanted 'prefix' Markus Armbruster
2024-09-04 11:18 ` [PATCH v2 18/19] qapi/cryptodev: Rename QCryptodevBackendAlgType to *Algo, and drop prefix Markus Armbruster
2024-09-04 11:18 ` Markus Armbruster [this message]
2024-09-04 11:59 ` [PATCH v2 19/19] qapi/vfio: Rename VfioMigrationState to Qapi*, " Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904111836.3273842-20-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=andrew@codeconstruct.com.au \
--cc=andrew@daynix.com \
--cc=arei.gonglei@huawei.com \
--cc=avihaih@nvidia.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@kaod.org \
--cc=david@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=idryomov@gmail.com \
--cc=iii@linux.ibm.com \
--cc=jamin_lin@aspeedtech.com \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=jsnow@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=leetroy@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=nsg@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pizhenwei@bytedance.com \
--cc=pl@dlhnet.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=steven_lee@aspeedtech.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=wangyanan55@huawei.com \
--cc=yuri.benditovich@daynix.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).