From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Jason Wang" <jasowang@redhat.com>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Andrew Melnychenko" <andrew@daynix.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 7/7] hw/net: improve tracing of eBPF RSS setup
Date: Thu, 5 Sep 2024 19:13:30 +0100 [thread overview]
Message-ID: <20240905181330.3657590-8-berrange@redhat.com> (raw)
In-Reply-To: <20240905181330.3657590-1-berrange@redhat.com>
This adds more trace events to key eBPF RSS setup operations, and
also distinguishes events from multiple NIC instances.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
hw/net/trace-events | 8 +++++---
hw/net/virtio-net.c | 9 ++++++---
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/net/trace-events b/hw/net/trace-events
index 78efa2ec2c..6cad34aba2 100644
--- a/hw/net/trace-events
+++ b/hw/net/trace-events
@@ -399,9 +399,11 @@ virtio_net_announce_notify(void) ""
virtio_net_announce_timer(int round) "%d"
virtio_net_handle_announce(int round) "%d"
virtio_net_post_load_device(void)
-virtio_net_rss_disable(void)
-virtio_net_rss_error(const char *msg, uint32_t value) "%s, value 0x%08x"
-virtio_net_rss_enable(uint32_t p1, uint16_t p2, uint8_t p3) "hashes 0x%x, table of %d, key of %d"
+virtio_net_rss_load(void *nic, size_t nfds, void *fds) "nic=%p nfds=%zu fds=%p"
+virtio_net_rss_attach_ebpf(void *nic, int prog_fd) "nic=%p prog-fd=%d"
+virtio_net_rss_disable(void *nic) "nic=%p"
+virtio_net_rss_error(void *nic, const char *msg, uint32_t value) "nic=%p msg=%s, value 0x%08x"
+virtio_net_rss_enable(void *nic, uint32_t p1, uint16_t p2, uint8_t p3) "nic=%p hashes 0x%x, table of %d, key of %d"
# tulip.c
tulip_reg_write(uint64_t addr, const char *name, int size, uint64_t val) "addr 0x%02"PRIx64" (%s) size %d value 0x%08"PRIx64
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index f2690390c1..5d26a8e260 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1241,6 +1241,7 @@ static bool virtio_net_attach_ebpf_to_backend(NICState *nic, int prog_fd)
return false;
}
+ trace_virtio_net_rss_attach_ebpf(nic, prog_fd);
return nc->info->set_steering_ebpf(nc, prog_fd);
}
@@ -1297,12 +1298,13 @@ static void virtio_net_commit_rss_config(VirtIONet *n)
}
}
- trace_virtio_net_rss_enable(n->rss_data.hash_types,
+ trace_virtio_net_rss_enable(n,
+ n->rss_data.hash_types,
n->rss_data.indirections_len,
sizeof(n->rss_data.key));
} else {
virtio_net_detach_ebpf_rss(n);
- trace_virtio_net_rss_disable();
+ trace_virtio_net_rss_disable(n);
}
}
@@ -1353,6 +1355,7 @@ static bool virtio_net_load_ebpf(VirtIONet *n, Error **errp)
bool ret = false;
if (virtio_net_attach_ebpf_to_backend(n->nic, -1)) {
+ trace_virtio_net_rss_load(n, n->nr_ebpf_rss_fds, n->ebpf_rss_fds);
if (n->ebpf_rss_fds) {
ret = virtio_net_load_ebpf_fds(n, errp);
} else {
@@ -1484,7 +1487,7 @@ static uint16_t virtio_net_handle_rss(VirtIONet *n,
virtio_net_commit_rss_config(n);
return queue_pairs;
error:
- trace_virtio_net_rss_error(err_msg, err_value);
+ trace_virtio_net_rss_error(n, err_msg, err_value);
virtio_net_disable_rss(n);
return 0;
}
--
2.45.2
next prev parent reply other threads:[~2024-09-05 18:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 18:13 [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 1/7] hw/net: fix typo s/epbf/ebpf/ in virtio-net Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 2/7] ebpf: drop redundant parameter checks in static methods Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 3/7] ebpf: improve error trace events Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 4/7] ebpf: add formal error reporting to all APIs Daniel P. Berrangé
2024-09-06 10:07 ` Philippe Mathieu-Daudé
2024-10-23 3:55 ` Jason Wang
2024-10-23 8:52 ` Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 5/7] hw/net: report errors from failing to use eBPF RSS FDs Daniel P. Berrangé
2024-09-06 10:09 ` Philippe Mathieu-Daudé
2024-09-05 18:13 ` [PATCH v2 6/7] ebpf: improve trace event coverage to all key operations Daniel P. Berrangé
2024-09-06 10:10 ` Philippe Mathieu-Daudé
2024-09-05 18:13 ` Daniel P. Berrangé [this message]
2024-09-06 10:12 ` [PATCH v2 7/7] hw/net: improve tracing of eBPF RSS setup Philippe Mathieu-Daudé
2024-09-06 9:57 ` [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Michael S. Tsirkin
2024-09-09 2:34 ` Jason Wang
2024-10-15 13:50 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905181330.3657590-8-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=andrew@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).