From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: zhiwei_liu@linux.alibaba.com, tangtiancheng.ttc@alibaba-inc.com,
liwei1518@gmail.com, bmeng.cn@gmail.com, qemu-stable@nongnu.org
Subject: [PATCH 01/12] tcg: Fix iteration step in 32-bit gvec operation
Date: Sat, 7 Sep 2024 19:26:21 -0700 [thread overview]
Message-ID: <20240908022632.459477-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240908022632.459477-1-richard.henderson@linaro.org>
From: TANG Tiancheng <tangtiancheng.ttc@alibaba-inc.com>
The loop in the 32-bit case of the vector compare operation
was incorrectly incrementing by 8 bytes per iteration instead
of 4 bytes. This caused the function to process only half of
the intended elements.
Cc: qemu-stable@nongnu.org
Fixes: 9622c697d1 (tcg: Add gvec compare with immediate and scalar operand)
Signed-off-by: TANG Tiancheng <tangtiancheng.ttc@alibaba-inc.com>
Reviewed-by: Liu Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20240904142739.854-2-zhiwei_liu@linux.alibaba.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tcg-op-gvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c
index 0308732d9b..78ee1ced80 100644
--- a/tcg/tcg-op-gvec.c
+++ b/tcg/tcg-op-gvec.c
@@ -3939,7 +3939,7 @@ void tcg_gen_gvec_cmps(TCGCond cond, unsigned vece, uint32_t dofs,
uint32_t i;
tcg_gen_extrl_i64_i32(t1, c);
- for (i = 0; i < oprsz; i += 8) {
+ for (i = 0; i < oprsz; i += 4) {
tcg_gen_ld_i32(t0, tcg_env, aofs + i);
tcg_gen_negsetcond_i32(cond, t0, t0, t1);
tcg_gen_st_i32(t0, tcg_env, dofs + i);
--
2.43.0
next prev parent reply other threads:[~2024-09-08 2:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 2:26 [PATCH 00/12] tcg: Improve support for cmpsel_vec Richard Henderson
2024-09-08 2:26 ` Richard Henderson [this message]
2024-09-10 6:57 ` [PATCH 01/12] tcg: Fix iteration step in 32-bit gvec operation Philippe Mathieu-Daudé
2024-09-10 14:46 ` Richard Henderson
2024-09-08 2:26 ` [PATCH 02/12] tcg: Export vec_gen_6 Richard Henderson
2024-09-10 6:57 ` Philippe Mathieu-Daudé
2024-09-08 2:26 ` [PATCH 03/12] tcg/i386: Split out tcg_out_vex_modrm_type Richard Henderson
2024-09-10 6:59 ` Philippe Mathieu-Daudé
2024-09-08 2:26 ` [PATCH 04/12] tcg/i386: Do not expand cmp_vec early Richard Henderson
2024-09-08 2:26 ` [PATCH 05/12] tcg/i386: Do not expand cmpsel_vec early Richard Henderson
2024-09-08 2:26 ` [PATCH 06/12] tcg/optimize: Fold movcond with true and false values identical Richard Henderson
2024-09-10 7:00 ` Philippe Mathieu-Daudé
2024-09-08 2:26 ` [PATCH 07/12] tcg/optimize: Optimize cmp_vec and cmpsel_vec Richard Henderson
2024-09-08 2:26 ` [PATCH 08/12] tcg/optimize: Optimize bitsel_vec Richard Henderson
2024-09-08 2:26 ` [PATCH 09/12] tcg/i386: Optimize cmpsel with constant 0 arguments Richard Henderson
2024-09-08 2:26 ` [PATCH 10/12] tcg/i386: Implement cmp_vec with avx512 insns Richard Henderson
2024-09-08 2:26 ` [PATCH 11/12] tcg/i386: Add predicate parameters to tcg_out_evex_opc Richard Henderson
2024-09-10 7:04 ` Philippe Mathieu-Daudé
2024-09-08 2:26 ` [PATCH 12/12] tcg/i386: Implement cmpsel_vec with avx512 insns Richard Henderson
2024-09-09 23:37 ` [PATCH 00/12] tcg: Improve support for cmpsel_vec Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240908022632.459477-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=bmeng.cn@gmail.com \
--cc=liwei1518@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=tangtiancheng.ttc@alibaba-inc.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).