qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: zhiwei_liu@linux.alibaba.com, tangtiancheng.ttc@alibaba-inc.com,
	liwei1518@gmail.com, bmeng.cn@gmail.com
Subject: [PATCH 08/12] tcg/optimize: Optimize bitsel_vec
Date: Sat,  7 Sep 2024 19:26:28 -0700	[thread overview]
Message-ID: <20240908022632.459477-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240908022632.459477-1-richard.henderson@linaro.org>

Fold matching true/false operands.
Fold true/false operands with 0/-1 to simpler logicals.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index f11f576fd4..e9ef16b3c6 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -2737,6 +2737,61 @@ static bool fold_xor(OptContext *ctx, TCGOp *op)
     return fold_masks(ctx, op);
 }
 
+static bool fold_bitsel_vec(OptContext *ctx, TCGOp *op)
+{
+    /* If true and false values are the same, eliminate the cmp. */
+    if (args_are_copies(op->args[2], op->args[3])) {
+        return tcg_opt_gen_mov(ctx, op, op->args[0], op->args[2]);
+    }
+
+    if (arg_is_const(op->args[2]) && arg_is_const(op->args[3])) {
+        uint64_t tv = arg_info(op->args[2])->val;
+        uint64_t fv = arg_info(op->args[3])->val;
+
+        if (tv == -1 && fv == 0) {
+            return tcg_opt_gen_mov(ctx, op, op->args[0], op->args[1]);
+        }
+        if (tv == 0 && fv == -1) {
+            if (TCG_TARGET_HAS_not_vec) {
+                op->opc = INDEX_op_not_vec;
+                return fold_not(ctx, op);
+            } else {
+                op->opc = INDEX_op_xor_vec;
+                op->args[2] = arg_new_constant(ctx, -1);
+                return fold_xor(ctx, op);
+            }
+        }
+    }
+    if (arg_is_const(op->args[2])) {
+        uint64_t tv = arg_info(op->args[2])->val;
+        if (tv == -1) {
+            op->opc = INDEX_op_or_vec;
+            op->args[2] = op->args[3];
+            return fold_or(ctx, op);
+        }
+        if (tv == 0 && TCG_TARGET_HAS_andc_vec) {
+            op->opc = INDEX_op_andc_vec;
+            op->args[2] = op->args[1];
+            op->args[1] = op->args[3];
+            return fold_andc(ctx, op);
+        }
+    }
+    if (arg_is_const(op->args[3])) {
+        uint64_t fv = arg_info(op->args[3])->val;
+        if (fv == 0) {
+            op->opc = INDEX_op_and_vec;
+            return fold_and(ctx, op);
+        }
+        if (fv == -1 && TCG_TARGET_HAS_orc_vec) {
+            op->opc = INDEX_op_orc_vec;
+            op->args[2] = op->args[1];
+            op->args[1] = op->args[3];
+            return fold_orc(ctx, op);
+        }
+    }
+    return false;
+}
+
 /* Propagate constants and copies, fold constant expressions. */
 void tcg_optimize(TCGContext *s)
 {
@@ -2964,6 +3019,9 @@ void tcg_optimize(TCGContext *s)
         case INDEX_op_cmpsel_vec:
             done = fold_cmpsel_vec(&ctx, op);
             break;
+        case INDEX_op_bitsel_vec:
+            done = fold_bitsel_vec(&ctx, op);
+            break;
         CASE_OP_32_64(sextract):
             done = fold_sextract(&ctx, op);
             break;
-- 
2.43.0



  parent reply	other threads:[~2024-09-08  2:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-08  2:26 [PATCH 00/12] tcg: Improve support for cmpsel_vec Richard Henderson
2024-09-08  2:26 ` [PATCH 01/12] tcg: Fix iteration step in 32-bit gvec operation Richard Henderson
2024-09-10  6:57   ` Philippe Mathieu-Daudé
2024-09-10 14:46     ` Richard Henderson
2024-09-08  2:26 ` [PATCH 02/12] tcg: Export vec_gen_6 Richard Henderson
2024-09-10  6:57   ` Philippe Mathieu-Daudé
2024-09-08  2:26 ` [PATCH 03/12] tcg/i386: Split out tcg_out_vex_modrm_type Richard Henderson
2024-09-10  6:59   ` Philippe Mathieu-Daudé
2024-09-08  2:26 ` [PATCH 04/12] tcg/i386: Do not expand cmp_vec early Richard Henderson
2024-09-08  2:26 ` [PATCH 05/12] tcg/i386: Do not expand cmpsel_vec early Richard Henderson
2024-09-08  2:26 ` [PATCH 06/12] tcg/optimize: Fold movcond with true and false values identical Richard Henderson
2024-09-10  7:00   ` Philippe Mathieu-Daudé
2024-09-08  2:26 ` [PATCH 07/12] tcg/optimize: Optimize cmp_vec and cmpsel_vec Richard Henderson
2024-09-08  2:26 ` Richard Henderson [this message]
2024-09-08  2:26 ` [PATCH 09/12] tcg/i386: Optimize cmpsel with constant 0 arguments Richard Henderson
2024-09-08  2:26 ` [PATCH 10/12] tcg/i386: Implement cmp_vec with avx512 insns Richard Henderson
2024-09-08  2:26 ` [PATCH 11/12] tcg/i386: Add predicate parameters to tcg_out_evex_opc Richard Henderson
2024-09-10  7:04   ` Philippe Mathieu-Daudé
2024-09-08  2:26 ` [PATCH 12/12] tcg/i386: Implement cmpsel_vec with avx512 insns Richard Henderson
2024-09-09 23:37 ` [PATCH 00/12] tcg: Improve support for cmpsel_vec Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240908022632.459477-9-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=bmeng.cn@gmail.com \
    --cc=liwei1518@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tangtiancheng.ttc@alibaba-inc.com \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).