From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, daniel@0x0f.com
Subject: [PATCH v3 13/26] target/m68k: Split gen_ea_mode for load/store
Date: Mon, 9 Sep 2024 10:28:10 -0700 [thread overview]
Message-ID: <20240909172823.649837-14-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240909172823.649837-1-richard.henderson@linaro.org>
Replace with gen_load_mode and gen_store_mode.
Return bool for success from gen_store_mode,
which makes store_dummy unused.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/translate.c | 155 ++++++++++++++++++++--------------------
1 file changed, 76 insertions(+), 79 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index c6b901ff83..2c0852ac3a 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -59,8 +59,6 @@ static TCGv_i64 cpu_macc[4];
static TCGv NULL_QREG;
#define IS_NULL_QREG(t) (t == NULL_QREG)
-/* Used to distinguish stores from bad addressing modes. */
-static TCGv store_dummy;
void m68k_tcg_init(void)
{
@@ -104,7 +102,6 @@ void m68k_tcg_init(void)
}
NULL_QREG = tcg_global_mem_new(tcg_env, -4, "NULL");
- store_dummy = tcg_global_mem_new(tcg_env, -8, "NULL");
}
/* internal defines */
@@ -338,21 +335,6 @@ typedef enum {
EA_LOADS
} ea_what;
-/*
- * Generate an unsigned load if VAL is 0 a signed load if val is -1,
- * otherwise generate a store.
- */
-static TCGv gen_ldst(DisasContext *s, int opsize, TCGv addr, TCGv val,
- ea_what what, int index)
-{
- if (what == EA_STORE) {
- gen_store(s, opsize, addr, val, index);
- return store_dummy;
- } else {
- return gen_load(s, opsize, addr, what == EA_LOADS, index);
- }
-}
-
/* Read a 16-bit immediate constant */
static inline uint16_t read_im16(CPUM68KState *env, DisasContext *s)
{
@@ -794,9 +776,9 @@ static TCGv gen_lea(CPUM68KState *env, DisasContext *s, uint16_t insn,
* a write otherwise it is a read (0 == sign extend, -1 == zero extend).
* ADDRP is non-null for readwrite operands.
*/
-static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0,
- int opsize, TCGv val, TCGv *addrp, ea_what what,
- int index)
+static TCGv gen_load_mode(CPUM68KState *env, DisasContext *s,
+ int mode, int reg0, int opsize, TCGv *addrp,
+ int sign, int index)
{
TCGv reg, ret, addr = NULL;
int32_t offset;
@@ -804,40 +786,28 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0,
switch (mode) {
case 0: /* Data register direct. */
reg = cpu_dregs[reg0];
- if (what == EA_STORE) {
- gen_partset_reg(opsize, reg, val);
- ret = store_dummy;
- } else {
- ret = gen_extend(s, reg, opsize, what == EA_LOADS);
- }
+ ret = gen_extend(s, reg, opsize, sign);
break;
case 1: /* Address register direct. */
reg = get_areg(s, reg0);
- if (what == EA_STORE) {
- tcg_gen_mov_i32(reg, val);
- ret = store_dummy;
- } else {
- ret = gen_extend(s, reg, opsize, what == EA_LOADS);
- }
+ ret = gen_extend(s, reg, opsize, sign);
break;
case 7: /* Other */
- if (reg0 == 4 && what != EA_STORE) {
+ if (reg0 == 4) {
/* Immediate: sign extend values for consistency. */
switch (opsize) {
case OS_BYTE:
- if (what == EA_LOADS) {
- offset = (int8_t)read_im8(env, s);
- } else {
- offset = read_im8(env, s);
+ offset = read_im8(env, s);
+ if (sign) {
+ offset = (int8_t)offset;
}
break;
case OS_WORD:
- if (what == EA_LOADS) {
- offset = (int16_t)read_im16(env, s);
- } else {
- offset = read_im16(env, s);
+ offset = read_im16(env, s);
+ if (sign) {
+ offset = (int16_t)offset;
}
break;
case OS_LONG:
@@ -856,17 +826,13 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0,
case 4: /* Indirect predecrememnt. */
case 5: /* Indirect displacement. */
case 6: /* Indirect index + displacement. */
- if (what == EA_STORE && addrp && *addrp) {
- addr = *addrp;
- } else {
- addr = gen_lea_mode(env, s, mode, reg0, opsize);
- if (IS_NULL_QREG(addr)) {
- ret = addr;
- addr = NULL;
- break;
- }
+ addr = gen_lea_mode(env, s, mode, reg0, opsize);
+ if (IS_NULL_QREG(addr)) {
+ ret = addr;
+ addr = NULL;
+ break;
}
- ret = gen_ldst(s, opsize, addr, val, what, index);
+ ret = gen_load(s, opsize, addr, sign, index);
break;
default:
@@ -879,6 +845,43 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0,
return ret;
}
+static bool gen_store_mode(CPUM68KState *env, DisasContext *s,
+ int mode, int reg0, int opsize,
+ TCGv val, TCGv addr, int index)
+{
+ TCGv reg;
+
+ switch (mode) {
+ case 0: /* Data register direct. */
+ reg = cpu_dregs[reg0];
+ gen_partset_reg(opsize, reg, val);
+ return true;
+
+ case 1: /* Address register direct. */
+ reg = get_areg(s, reg0);
+ tcg_gen_mov_i32(reg, val);
+ return true;
+
+ case 2: /* Indirect register */
+ case 3: /* Indirect postincrement. */
+ case 4: /* Indirect predecrememnt. */
+ case 5: /* Indirect displacement. */
+ case 6: /* Indirect index + displacement. */
+ case 7: /* Other */
+ if (!addr) {
+ addr = gen_lea_mode(env, s, mode, reg0, opsize);
+ if (IS_NULL_QREG(addr)) {
+ return false;
+ }
+ }
+ gen_store(s, opsize, addr, val, index);
+ return true;
+
+ default:
+ g_assert_not_reached();
+ }
+}
+
static TCGv_ptr gen_fp_ptr(int freg)
{
TCGv_ptr fp = tcg_temp_new_ptr();
@@ -1321,13 +1324,9 @@ static void gen_exit_tb(DisasContext *s)
#define SRC_EA(env, result, opsize, op_sign, addrp) \
do { \
- TCGv *addrp_ = (addrp); \
- if (addrp_) { \
- *addrp_ = NULL; \
- } \
- result = gen_ea_mode(env, s, extract32(insn, 3, 3), \
- REG(insn, 0), opsize, NULL_QREG, addrp_, \
- op_sign ? EA_LOADS : EA_LOADU, IS_USER(s)); \
+ result = gen_load_mode(env, s, extract32(insn, 3, 3), \
+ REG(insn, 0), opsize, addrp, \
+ op_sign, IS_USER(s)); \
if (IS_NULL_QREG(result)) { \
gen_addr_fault(s); \
return; \
@@ -1336,10 +1335,10 @@ static void gen_exit_tb(DisasContext *s)
#define DEST_EA(env, insn, opsize, val, addrp) \
do { \
- TCGv ea_result = gen_ea_mode(env, s, extract32(insn, 3, 3), \
- REG(insn, 0), opsize, val, addrp, \
- EA_STORE, IS_USER(s)); \
- if (IS_NULL_QREG(ea_result)) { \
+ TCGv *addrp_ = (addrp); \
+ if (!gen_store_mode(env, s, extract32(insn, 3, 3), \
+ REG(insn, 0), opsize, val, \
+ addrp_ ? *addrp_ : NULL, IS_USER(s))) { \
gen_addr_fault(s); \
return; \
} \
@@ -1701,15 +1700,14 @@ DISAS_INSN(abcd_mem)
/* Indirect pre-decrement load (mode 4) */
- src = gen_ea_mode(env, s, 4, REG(insn, 0), OS_BYTE,
- NULL_QREG, NULL, EA_LOADU, IS_USER(s));
- dest = gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE,
- NULL_QREG, &addr, EA_LOADU, IS_USER(s));
+ src = gen_load_mode(env, s, 4, REG(insn, 0), OS_BYTE,
+ NULL, false, IS_USER(s));
+ dest = gen_load_mode(env, s, 4, REG(insn, 9), OS_BYTE,
+ &addr, false, IS_USER(s));
bcd_add(dest, src);
- gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, &addr,
- EA_STORE, IS_USER(s));
+ gen_store_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, addr, IS_USER(s));
bcd_flags(dest);
}
@@ -1738,15 +1736,14 @@ DISAS_INSN(sbcd_mem)
/* Indirect pre-decrement load (mode 4) */
- src = gen_ea_mode(env, s, 4, REG(insn, 0), OS_BYTE,
- NULL_QREG, NULL, EA_LOADU, IS_USER(s));
- dest = gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE,
- NULL_QREG, &addr, EA_LOADU, IS_USER(s));
+ src = gen_load_mode(env, s, 4, REG(insn, 0), OS_BYTE,
+ NULL, false, IS_USER(s));
+ dest = gen_load_mode(env, s, 4, REG(insn, 9), OS_BYTE,
+ &addr, false, IS_USER(s));
bcd_sub(dest, src);
- gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, &addr,
- EA_STORE, IS_USER(s));
+ gen_store_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, addr, IS_USER(s));
bcd_flags(dest);
}
@@ -3123,11 +3120,11 @@ DISAS_INSN(cmpm)
TCGv src, dst;
/* Post-increment load (mode 3) from Ay. */
- src = gen_ea_mode(env, s, 3, REG(insn, 0), opsize,
- NULL_QREG, NULL, EA_LOADS, IS_USER(s));
+ src = gen_load_mode(env, s, 3, REG(insn, 0), opsize,
+ NULL, true, IS_USER(s));
/* Post-increment load (mode 3) from Ax. */
- dst = gen_ea_mode(env, s, 3, REG(insn, 9), opsize,
- NULL_QREG, NULL, EA_LOADS, IS_USER(s));
+ dst = gen_load_mode(env, s, 3, REG(insn, 9), opsize,
+ NULL, true, IS_USER(s));
gen_update_cc_cmp(s, dst, src, opsize);
}
--
2.43.0
next prev parent reply other threads:[~2024-09-09 17:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 17:27 [PATCH v3 00/26] target/m68k: fpu improvements Richard Henderson
2024-09-09 17:27 ` [PATCH v3 01/26] target/m68k: Always return a temporary from gen_lea_mode Richard Henderson
2024-09-09 17:27 ` [PATCH v3 02/26] target/m68k: Add FPSR exception bit defines Richard Henderson
2024-09-09 17:28 ` [PATCH v3 03/26] target/m68k: Restore fp rounding mode on vm load Richard Henderson
2024-09-09 21:59 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 04/26] target/m68k: Keep FPSR up-to-date Richard Henderson
2024-09-09 17:28 ` [PATCH v3 05/26] target/m68k: Update FPSR.EXC Richard Henderson
2024-09-09 17:28 ` [PATCH v3 06/26] softfloat: Set QEMU_NO_HARDFLOAT for m68k Richard Henderson
2024-09-09 17:28 ` [PATCH v3 07/26] target/m68k: Invoke update_fpsr for FMOVECR Richard Henderson
2024-09-09 17:28 ` [PATCH v3 08/26] target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL Richard Henderson
2024-09-09 17:28 ` [PATCH v3 09/26] target/m68k: Merge gen_ea into SRC_EA and DEST_EA Richard Henderson
2024-09-09 22:02 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 10/26] target/m68k: Use g_assert_not_reached in gen_lea_mode and gen_ea_mode Richard Henderson
2024-09-09 22:03 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 11/26] target/m68k: Use OS_UNSIZED in LEA, PEA, JMP Richard Henderson
2024-09-09 17:28 ` [PATCH v3 12/26] target/m68k: Move pre-dec/post-inc to gen_lea_mode Richard Henderson
2024-09-09 17:28 ` Richard Henderson [this message]
2024-09-09 17:28 ` [PATCH v3 14/26] target/m68k: Remove env argument to gen_lea_indexed Richard Henderson
2024-09-09 22:05 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 15/26] target/m68k: Remove env argument to gen_lea_mode Richard Henderson
2024-09-09 22:06 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 16/26] target/m68k: Remove env argument to gen_load_mode Richard Henderson
2024-09-09 22:06 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 17/26] target/m68k: Remove env argument to gen_store_mode Richard Henderson
2024-09-09 22:06 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 18/26] target/m68k: Remove env argument to gen_ea_mode_fp Richard Henderson
2024-09-09 22:06 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 19/26] target/m68k: Split gen_ea_mode_fp for load/store Richard Henderson
2024-09-09 22:13 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 20/26] target/m68k: Move gen_addr_fault into gen_{load, store}_mode_fp Richard Henderson
2024-09-09 22:14 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 21/26] target/m68k: Merge gen_load_fp, gen_load_mode_fp Richard Henderson
2024-09-09 22:16 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 22/26] target/m68k: Merge gen_store_fp, gen_store_mode_fp Richard Henderson
2024-09-09 22:16 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 23/26] target/m68k: Implement packed decimal real loads and stores Richard Henderson
2024-09-09 17:28 ` [PATCH v3 24/26] tests/tcg/m68k: Add packed decimal tests Richard Henderson
2024-09-09 17:28 ` [PATCH v3 25/26] target/m68k: Make vmstate variables static Richard Henderson
2024-09-09 22:17 ` Philippe Mathieu-Daudé
2024-09-09 17:28 ` [PATCH v3 26/26] target/m68k: Implement FPIAR Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909172823.649837-14-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=daniel@0x0f.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).