From: "Michael S. Tsirkin" <mst@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, philmd@linaro.org,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Akihiko Odaki <akihiko.odaki@daynix.com>,
Peter Maydell <peter.maydell@linaro.org>,
Bernhard Beschow <shentey@gmail.com>
Subject: Re: [PATCH 0/2] Solve vt82c686 qemu_irq leak.
Date: Tue, 10 Sep 2024 03:10:03 -0400 [thread overview]
Message-ID: <20240910030754-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <cover.1719690591.git.balaton@eik.bme.hu>
On Sat, Jun 29, 2024 at 10:01:52PM +0200, BALATON Zoltan wrote:
> This is an alternative appriach to solve the qemu_irq leak in
> vt82c686. Allowing embedding an irq and init it in place like done
> with other objects may allow cleaner fix for similar issues and I also
> plan to use this for adding qemu_itq to pegasos2 machine state for
> which gpio would not work.
>
> BALATON Zoltan (2):
> hw: Move declaration of IRQState to header and add init function
> hw/isa/vt82c686.c: Embed i8259 irq in device state instead of
> allocating
This looked like a simpler approach to shut up analyzer warnings, so I
picked this one.
> hw/core/irq.c | 25 +++++++++++--------------
> hw/isa/vt82c686.c | 7 ++++---
> include/hw/irq.h | 18 ++++++++++++++++++
> 3 files changed, 33 insertions(+), 17 deletions(-)
>
> --
> 2.30.9
>
>
next prev parent reply other threads:[~2024-09-10 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 20:01 [PATCH 0/2] Solve vt82c686 qemu_irq leak BALATON Zoltan
2024-06-29 20:01 ` [PATCH 1/2] hw: Move declaration of IRQState to header and add init function BALATON Zoltan
2024-07-01 12:52 ` Peter Maydell
2024-06-29 20:01 ` [PATCH 2/2] hw/isa/vt82c686.c: Embed i8259 irq in device state instead of allocating BALATON Zoltan
2024-07-01 12:58 ` Peter Maydell
2024-07-01 18:27 ` BALATON Zoltan
2024-07-01 21:13 ` Mark Cave-Ayland
2024-07-02 18:42 ` Bernhard Beschow
2024-07-02 21:17 ` Bernhard Beschow
2024-07-03 0:09 ` BALATON Zoltan
2024-07-03 7:15 ` Bernhard Beschow
2024-07-03 11:13 ` BALATON Zoltan
2024-07-04 21:06 ` Bernhard Beschow
2024-07-02 18:44 ` Bernhard Beschow
2024-09-10 7:10 ` Michael S. Tsirkin [this message]
2024-09-13 13:00 ` [PATCH 0/2] Solve vt82c686 qemu_irq leak BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910030754-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=balaton@eik.bme.hu \
--cc=jiaxun.yang@flygoat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).