From: "Michael S. Tsirkin" <mst@redhat.com>
To: BillXiang <xiangwencheng@dayudpu.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE
Date: Tue, 10 Sep 2024 10:43:11 -0400 [thread overview]
Message-ID: <20240910104133-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240801124540.38774-1-xiangwencheng@dayudpu.com>
On Thu, Aug 01, 2024 at 08:45:40PM +0800, BillXiang wrote:
> From: BillXiang <xiangwencheng@dayudpu.com>
>
> Currently, we have added VHOST_USER_SET_LOG_BASE to
> vhost_user_per_device_request in commit 7c211eb078c4
> ("vhost-user: Skip unnecessary duplicated VHOST_USER_SET_LOG_BASE requests"),
> as a result, VHOST_USER_SET_LOG_BASE will be sent only once
> when 'vq_index == 0'.
> In this patch we add the check of 'vq_index == 0' before
> vhost_user_read, such that we do not wait for reply for not
> sent VHOST_USER_SET_LOG_BASE.
>
> Signed-off-by: BillXiang <xiangwencheng@dayudpu.com>
If you still want this in, pls rewrite the commit log to make
it clear wat is going on: e.g. "cleanup X which does not do
Y with Z, which does" and repost.
> ---
> hw/virtio/vhost-user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 00561daa06..fd12992d15 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -460,7 +460,7 @@ static int vhost_user_set_log_base(struct vhost_dev *dev, uint64_t base,
> return ret;
> }
>
> - if (shmfd) {
> + if (shmfd && (dev->vq_index == 0)) {
> msg.hdr.size = 0;
> ret = vhost_user_read(dev, &msg);
> if (ret < 0) {
> --
> 2.30.0
prev parent reply other threads:[~2024-09-10 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 12:45 [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE BillXiang
2024-08-01 14:12 ` Michael S. Tsirkin
2024-08-01 15:01 ` BillXiang
2024-08-27 11:06 ` Prasad Pandit
2024-08-27 11:20 ` BillXiang
2024-08-27 12:36 ` Prasad Pandit
2024-08-27 13:00 ` BillXiang
2024-08-27 20:55 ` Michael S. Tsirkin
2024-09-10 14:43 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910104133-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiangwencheng@dayudpu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).