qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	qemu-arm@nongnu.org, devel@lists.libvirt.org,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Gustavo Romero" <gustavo.romero@linaro.org>
Subject: [PATCH v2 07/10] gdbstub: Add support for MTE in system mode
Date: Tue, 10 Sep 2024 18:38:57 +0100	[thread overview]
Message-ID: <20240910173900.4154726-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240910173900.4154726-1-alex.bennee@linaro.org>

From: Gustavo Romero <gustavo.romero@linaro.org>

This commit makes handle_q_memtag, handle_q_isaddresstagged, and
handle_Q_memtag stubs build for system mode, allowing all GDB
'memory-tag' subcommands to work with QEMU gdbstub on aarch64 system
mode.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/620
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240906143316.657436-3-gustavo.romero@linaro.org>
[AJB: add #ifdef CONFIG_TCG guards]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v2
  - while we enable system mode it is still TCG only so added guards
  to handle the --disable-tcg case (native KVM and Xen builds)
---
 target/arm/gdbstub64.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c
index 85a19c14c7..1a4dbec567 100644
--- a/target/arm/gdbstub64.c
+++ b/target/arm/gdbstub64.c
@@ -430,7 +430,9 @@ int aarch64_gdb_set_tag_ctl_reg(CPUState *cs, uint8_t *buf, int reg)
     return 0;
 #endif
 }
+#endif /* CONFIG_USER_ONLY */
 
+#ifdef CONFIG_TCG
 static void handle_q_memtag(GArray *params, void *user_ctx)
 {
     ARMCPU *cpu = ARM_CPU(user_ctx);
@@ -600,13 +602,13 @@ static const GdbCmdParseEntry cmd_handler_table[NUM_CMDS] = {
         .need_cpu_context = true
     },
 };
-#endif /* CONFIG_USER_ONLY */
+#endif /* CONFIG_TCG */
 
 void aarch64_cpu_register_gdb_commands(ARMCPU *cpu, GString *qsupported,
                                        GPtrArray *qtable, GPtrArray *stable)
 {
-#ifdef CONFIG_USER_ONLY
     /* MTE */
+#ifdef CONFIG_TCG
     if (cpu_isar_feature(aa64_mte, cpu)) {
         g_string_append(qsupported, ";memory-tagging+");
 
-- 
2.39.2



  parent reply	other threads:[~2024-09-10 17:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 17:38 [PATCH v2 00/10] Maintainer updates (testing, gdbstub) pre-PR Alex Bennée
2024-09-10 17:38 ` [PATCH v2 01/10] tests/docker: remove debian-armel-cross Alex Bennée
2024-09-10 18:16   ` Philippe Mathieu-Daudé
2024-09-10 20:41   ` Richard Henderson
2024-09-10 17:38 ` [PATCH v2 02/10] tests/docker: update debian i686 and mipsel images to bookworm Alex Bennée
2024-09-10 20:42   ` Richard Henderson
2024-09-10 17:38 ` [PATCH v2 03/10] tests/docker: use debian-all-test-cross for mips64el tests Alex Bennée
2024-09-10 20:43   ` Richard Henderson
2024-09-10 17:38 ` [PATCH v2 04/10] docs/devel: fix duplicate line Alex Bennée
2024-09-10 17:38 ` [PATCH v2 05/10] scripts/ci: update the gitlab-runner playbook Alex Bennée
2024-09-10 17:38 ` [PATCH v2 06/10] gdbstub: Use specific MMU index when probing MTE addresses Alex Bennée
2024-09-10 17:38 ` Alex Bennée [this message]
2024-09-10 17:38 ` [PATCH v2 08/10] tests/guest-debug: Support passing arguments to the GDB test script Alex Bennée
2024-09-10 17:38 ` [PATCH v2 09/10] tests/tcg/aarch64: Improve linker script organization Alex Bennée
2024-09-10 17:39 ` [PATCH v2 10/10] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910173900.4154726-8-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=gustavo.romero@linaro.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=ma.mandourr@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).