From: "Michael S. Tsirkin" <mst@redhat.com>
To: Prasad Pandit <ppandit@redhat.com>
Cc: qemu-devel@nongnu.org, farosas@suse.de, jasowang@redhat.com,
mcoqueli@redhat.com, peterx@redhat.com,
Prasad Pandit <pjp@fedoraproject.org>
Subject: Re: [PATCH v2 0/2] Postcopy migration and vhost-user errors
Date: Wed, 11 Sep 2024 05:46:03 -0400 [thread overview]
Message-ID: <20240911054259-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAE8KmOypfY1695Z5EgWeU2gCc=aF6qQESeiosgfkzZ7E6EEzqA@mail.gmail.com>
On Wed, Sep 11, 2024 at 12:44:59PM +0530, Prasad Pandit wrote:
> Hello Michael,
>
> On Tue, 10 Sept 2024 at 22:40, Michael S. Tsirkin <mst@redhat.com> wrote:
> > So are we going to see a version with BQL?
>
> ===
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index cdf9af4a4b..96ac0ed93b 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -2079,6 +2079,7 @@ static int vhost_user_postcopy_end(struct
> vhost_dev *dev, Error **errp)
>
> trace_vhost_user_postcopy_end_entry();
>
> + BQL_LOCK_GUARD();
> ret = vhost_user_write(dev, &msg, NULL, 0);
> if (ret < 0) {
> error_setg(errp, "Failed to send postcopy_end to vhost");
> --
> 2.43.5
> ===
>
> * We ran the test with the above BQL patch, but it did not help to fix
> race errors. I'm continuing to debug it, will update here soon.
>
> Thank you.
> ---
> - Prasad
Thanks! I have a suspicion there's a path where we wait for the
migration thread until BQL.
--
MST
prev parent reply other threads:[~2024-09-11 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 10:09 [PATCH v2 0/2] Postcopy migration and vhost-user errors Prasad Pandit
2024-08-28 10:09 ` [PATCH v2 1/2] vhost: fail device start if iotlb update fails Prasad Pandit
2024-08-28 10:09 ` [PATCH v2 2/2] vhost-user: add a request-reply lock Prasad Pandit
2024-08-28 11:15 ` Michael S. Tsirkin
2024-08-29 5:39 ` Prasad Pandit
2024-08-29 6:23 ` Michael S. Tsirkin
2024-08-29 7:42 ` Michael S. Tsirkin
2024-08-29 9:15 ` Prasad Pandit
2024-08-29 9:21 ` Michael S. Tsirkin
2024-08-29 14:29 ` Peter Xu
2024-08-29 15:05 ` Michael S. Tsirkin
2024-08-29 20:29 ` Peter Xu
2024-09-10 17:10 ` [PATCH v2 0/2] Postcopy migration and vhost-user errors Michael S. Tsirkin
2024-09-11 7:14 ` Prasad Pandit
2024-09-11 9:46 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911054259-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=peterx@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).