qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Deepak Gupta <debug@rivosinc.com>
To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com, bmeng.cn@gmail.com,
	liwei1518@gmail.com, dbarboza@ventanamicro.com,
	zhiwei_liu@linux.alibaba.com, jim.shu@sifive.com,
	andy.chiu@sifive.com, kito.cheng@sifive.com,
	Deepak Gupta <debug@rivosinc.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Alistair Francis <alistair.francis@wdc.com>
Subject: [PATCH v14 01/20] target/riscv: expose *envcfg csr and priv to qemu-user as well
Date: Thu, 12 Sep 2024 16:53:01 -0700	[thread overview]
Message-ID: <20240912235320.3768582-2-debug@rivosinc.com> (raw)
In-Reply-To: <20240912235320.3768582-1-debug@rivosinc.com>

Execution environment config CSR controlling user env and current
privilege state shouldn't be limited to qemu-system only. *envcfg
CSRs control enabling of features in next lesser mode. In some cases
bits *envcfg CSR can be lit up by kernel as part of kernel policy or
software (user app) can choose to opt-in by issuing a system call
(e.g. prctl). In case of qemu-user, it should be no different because
qemu is providing underlying execution environment facility and thus
either should provide some default value in *envcfg CSRs or react to
system calls (prctls) initiated from application. priv is set to PRV_U
and menvcfg/senvcfg set to 0 for qemu-user on reest.

`henvcfg` has been left for qemu-system only because it is not expected
that someone will use qemu-user where application is expected to have
hypervisor underneath which is controlling its execution environment. If
such a need arises then `henvcfg` could be exposed as well.

Relevant discussion:
https://lore.kernel.org/all/CAKmqyKOTVWPFep2msTQVdUmJErkH+bqCcKEQ4hAnyDFPdWKe0Q@mail.gmail.com/

Signed-off-by: Deepak Gupta <debug@rivosinc.com>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
---
 target/riscv/cpu.c | 5 +++++
 target/riscv/cpu.h | 9 +++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index cb675f0278..3538c2ae2e 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -1024,7 +1024,12 @@ static void riscv_cpu_reset_hold(Object *obj, ResetType type)
     }
 
     pmp_unlock_entries(env);
+#else
+    env->priv = PRV_U;
+    env->senvcfg = 0;
+    env->menvcfg = 0;
 #endif
+
     env->xl = riscv_cpu_mxl(env);
     riscv_cpu_update_mask(env);
     cs->exception_index = RISCV_EXCP_NONE;
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 1619c3acb6..2623f6cf75 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -234,8 +234,12 @@ struct CPUArchState {
     uint32_t elf_flags;
 #endif
 
-#ifndef CONFIG_USER_ONLY
     target_ulong priv;
+    /* CSRs for execution environment configuration */
+    uint64_t menvcfg;
+    target_ulong senvcfg;
+
+#ifndef CONFIG_USER_ONLY
     /* This contains QEMU specific information about the virt state. */
     bool virt_enabled;
     target_ulong geilen;
@@ -445,12 +449,9 @@ struct CPUArchState {
     target_ulong upmmask;
     target_ulong upmbase;
 
-    /* CSRs for execution environment configuration */
-    uint64_t menvcfg;
     uint64_t mstateen[SMSTATEEN_MAX_COUNT];
     uint64_t hstateen[SMSTATEEN_MAX_COUNT];
     uint64_t sstateen[SMSTATEEN_MAX_COUNT];
-    target_ulong senvcfg;
     uint64_t henvcfg;
 #endif
     target_ulong cur_pmmask;
-- 
2.45.0



  reply	other threads:[~2024-09-12 23:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 23:53 [PATCH v14 00/20] riscv support for control flow integrity extensions Deepak Gupta
2024-09-12 23:53 ` Deepak Gupta [this message]
2024-09-12 23:53 ` [PATCH v14 02/20] target/riscv: Add zicfilp extension Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 03/20] target/riscv: Introduce elp state and enabling controls for zicfilp Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 04/20] target/riscv: save and restore elp state on priv transitions Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 05/20] target/riscv: additional code information for sw check Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 06/20] target/riscv: tracking indirect branches (fcfi) for zicfilp Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 07/20] target/riscv: zicfilp `lpad` impl and branch tracking Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 08/20] disas/riscv: enable `lpad` disassembly Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 09/20] target/riscv: Expose zicfilp extension as a cpu property Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 10/20] target/riscv: Add zicfiss extension Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 11/20] target/riscv: introduce ssp and enabling controls for zicfiss Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 12/20] target/riscv: tb flag for shadow stack instructions Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 13/20] target/riscv: mmu changes for zicfiss shadow stack protection Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 14/20] target/riscv: AMO operations always raise store/AMO fault Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 15/20] target/riscv: update `decode_save_opc` to store extra word2 Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 16/20] target/riscv: implement zicfiss instructions Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 17/20] target/riscv: compressed encodings for sspush and sspopchk Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 18/20] disas/riscv: enable disassembly for zicfiss instructions Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 19/20] disas/riscv: enable disassembly for compressed sspush/sspopchk Deepak Gupta
2024-09-12 23:53 ` [PATCH v14 20/20] target/riscv: Expose zicfiss extension as a cpu property Deepak Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240912235320.3768582-2-debug@rivosinc.com \
    --to=debug@rivosinc.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=andy.chiu@sifive.com \
    --cc=bmeng.cn@gmail.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=jim.shu@sifive.com \
    --cc=kito.cheng@sifive.com \
    --cc=liwei1518@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).