From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E634FA3753 for ; Fri, 13 Sep 2024 13:27:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sp6KP-000592-Cp; Fri, 13 Sep 2024 09:27:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp6KM-0004wl-Di; Fri, 13 Sep 2024 09:27:10 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp6KK-0004Kp-2E; Fri, 13 Sep 2024 09:27:09 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4X4w3w1s5xz6J7LG; Fri, 13 Sep 2024 21:23:24 +0800 (CST) Received: from frapeml500003.china.huawei.com (unknown [7.182.85.28]) by mail.maildlp.com (Postfix) with ESMTPS id 8579E140A70; Fri, 13 Sep 2024 21:27:04 +0800 (CST) Received: from localhost (10.48.155.189) by frapeml500003.china.huawei.com (7.182.85.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 13 Sep 2024 15:27:03 +0200 Date: Fri, 13 Sep 2024 14:26:58 +0100 To: Jonathan Cameron CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 2/5] i386/cpu: add IsDefined flag to smp-cache property Message-ID: <20240913142658.00002da4@huawei.com> In-Reply-To: <20240913112128.0000074c@Huawei.com> References: <20240912133829.400-1-alireza.sanaee@huawei.com> <20240912133829.400-3-alireza.sanaee@huawei.com> <20240913112128.0000074c@Huawei.com> Organization: Huawei X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.155.189] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To frapeml500003.china.huawei.com (7.182.85.28) Received-SPF: pass client-ip=185.176.79.56; envelope-from=alireza.sanaee@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Alireza Sanaee From: Alireza Sanaee via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 13 Sep 2024 11:21:28 +0100 Jonathan Cameron wrote: > On Thu, 12 Sep 2024 14:38:26 +0100 > Alireza Sanaee wrote: > > > This commit adds IsDefined flag to the object and this helps in > > avoiding extra checks for every single layer of caches in both x86 > > and ARM. > Hi Ali, > > You mention x86 here, but no code changes to support that? > > Jonathan > Hi Jonathan, I used this flag in Patch 4 in build_pptt function. This flag is one of the todos Liu put as comment on his patch as well, and it is useful for me too. Thanks, Alireza > > > > Signed-off-by: Alireza Sanaee > > --- > > hw/core/machine-smp.c | 2 ++ > > include/hw/boards.h | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c > > index 9a28194676..5a02bbf584 100644 > > --- a/hw/core/machine-smp.c > > +++ b/hw/core/machine-smp.c > > @@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms, > > return false; > > } > > > > + ms->smp_cache.IsDefined = true; > > + > > return true; > > } > > > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > index db2aa2b706..2883a57084 100644 > > --- a/include/hw/boards.h > > +++ b/include/hw/boards.h > > @@ -373,6 +373,7 @@ typedef struct CpuTopology { > > > > typedef struct SmpCache { > > SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX]; > > + bool IsDefined; > > } SmpCache; > > > > /** >