From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: qemu-devel@nongnu.org,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Andrew Melnychenko <andrew@daynix.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Cc: Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH RFC v3 01/11] qdev-properties: DEFINE_PROP_ON_OFF_AUTO_BIT()
Date: Sun, 15 Sep 2024 10:23:42 +0900 [thread overview]
Message-ID: <20240915-hash-v3-1-79cb08d28647@daynix.com> (raw)
In-Reply-To: <20240915-hash-v3-0-79cb08d28647@daynix.com>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
include/hw/qdev-properties.h | 18 ++++++++++++
hw/core/qdev-properties.c | 66 +++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 83 insertions(+), 1 deletion(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 09aa04ca1e27..678837569784 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -43,10 +43,21 @@ struct PropertyInfo {
ObjectPropertyRelease *release;
};
+/**
+ * struct OnOffAutoBit - OnOffAuto storage with 64 elements.
+ * @on_bits: Bitmap of elements with "on".
+ * @auto_bits: Bitmap of elements with "auto".
+ */
+typedef struct OnOffAutoBit {
+ uint32_t on_bits;
+ uint32_t auto_bits;
+} OnOffAutoBit;
+
/*** qdev-properties.c ***/
extern const PropertyInfo qdev_prop_bit;
+extern const PropertyInfo qdev_prop_on_off_auto_bit;
extern const PropertyInfo qdev_prop_bit64;
extern const PropertyInfo qdev_prop_bool;
extern const PropertyInfo qdev_prop_enum;
@@ -86,6 +97,13 @@ extern const PropertyInfo qdev_prop_link;
.set_default = true, \
.defval.u = (bool)_defval)
+#define DEFINE_PROP_ON_OFF_AUTO_BIT(_name, _state, _field, _bit, _defval) \
+ DEFINE_PROP(_name, _state, _field, qdev_prop_on_off_auto_bit, \
+ OnOffAutoBit, \
+ .bitnr = (_bit), \
+ .set_default = true, \
+ .defval.i = (OnOffAuto)_defval)
+
#define DEFINE_PROP_UNSIGNED(_name, _state, _field, _defval, _prop, _type) \
DEFINE_PROP(_name, _state, _field, _prop, _type, \
.set_default = true, \
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 86a583574dd0..e1ff992e7177 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -133,7 +133,8 @@ const PropertyInfo qdev_prop_enum = {
static uint32_t qdev_get_prop_mask(Property *prop)
{
- assert(prop->info == &qdev_prop_bit);
+ assert(prop->info == &qdev_prop_bit ||
+ prop->info == &qdev_prop_on_off_auto_bit);
return 0x1 << prop->bitnr;
}
@@ -183,6 +184,69 @@ const PropertyInfo qdev_prop_bit = {
.set_default_value = set_default_value_bool,
};
+static void prop_get_on_off_auto_bit(Object *obj, Visitor *v,
+ const char *name, void *opaque,
+ Error **errp)
+{
+ Property *prop = opaque;
+ OnOffAutoBit *p = object_field_prop_ptr(obj, prop);
+ int value;
+ uint32_t mask = qdev_get_prop_mask(prop);
+
+ if (p->auto_bits & mask) {
+ value = ON_OFF_AUTO_AUTO;
+ } else if (p->on_bits & mask) {
+ value = ON_OFF_AUTO_ON;
+ } else {
+ value = ON_OFF_AUTO_OFF;
+ }
+
+ visit_type_enum(v, name, &value, &OnOffAuto_lookup, errp);
+}
+
+static void prop_set_on_off_auto_bit(Object *obj, Visitor *v,
+ const char *name, void *opaque,
+ Error **errp)
+{
+ Property *prop = opaque;
+ OnOffAutoBit *p = object_field_prop_ptr(obj, prop);
+ bool bool_value;
+ int value;
+ uint32_t mask = qdev_get_prop_mask(prop);
+
+ if (visit_type_bool(v, name, &bool_value, NULL)) {
+ value = bool_value ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF;
+ } else if (!visit_type_enum(v, name, &value, &OnOffAuto_lookup, errp)) {
+ return;
+ }
+
+ switch (value) {
+ case ON_OFF_AUTO_AUTO:
+ p->on_bits &= ~mask;
+ p->auto_bits |= mask;
+ break;
+
+ case ON_OFF_AUTO_ON:
+ p->on_bits |= mask;
+ p->auto_bits &= ~mask;
+ break;
+
+ case ON_OFF_AUTO_OFF:
+ p->on_bits &= ~mask;
+ p->auto_bits &= ~mask;
+ break;
+ }
+}
+
+const PropertyInfo qdev_prop_on_off_auto_bit = {
+ .name = "OnOffAuto",
+ .description = "on/off/auto",
+ .enum_table = &OnOffAuto_lookup,
+ .get = prop_get_on_off_auto_bit,
+ .set = prop_set_on_off_auto_bit,
+ .set_default_value = qdev_propinfo_set_default_value_enum,
+};
+
/* Bit64 */
static uint64_t qdev_get_prop_mask64(Property *prop)
--
2.46.0
next prev parent reply other threads:[~2024-09-15 1:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 1:23 [PATCH RFC v3 00/11] virtio-net: Offload hashing without eBPF Akihiko Odaki
2024-09-15 1:23 ` Akihiko Odaki [this message]
2024-09-15 1:23 ` [PATCH RFC v3 02/11] net/vhost-vdpa: Report hashing capability Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 03/11] virtio-net: Move virtio_net_get_features() down Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 04/11] virtio-net: Retrieve peer hashing capability Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 05/11] net/vhost-vdpa: Remove dummy SetSteeringEBPF Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 06/11] virtio-net: Add hash type options Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 07/11] net: Allow configuring virtio hashing Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 08/11] virtio-net: Use qemu_set_vnet_hash() Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 09/11] virtio-net: Offload hashing without vhost Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 10/11] tap: Report virtio-net hashing support on Linux Akihiko Odaki
2024-09-15 1:23 ` [PATCH RFC v3 11/11] docs/devel/ebpf_rss.rst: Update for peer RSS Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915-hash-v3-1-79cb08d28647@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).