From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dorjoy Chowdhury <dorjoychy111@gmail.com>
Cc: qemu-devel@nongnu.org, graf@amazon.com, agraf@csgraf.de,
stefanha@redhat.com, pbonzini@redhat.com, slp@redhat.com,
richard.henderson@linaro.org, eduardo@habkost.net,
marcel.apfelbaum@gmail.com, berrange@redhat.com,
philmd@linaro.org
Subject: Re: [PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device
Date: Sun, 15 Sep 2024 16:11:05 -0400 [thread overview]
Message-ID: <20240915160953-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240905195735.16911-6-dorjoychy111@gmail.com>
On Fri, Sep 06, 2024 at 01:57:32AM +0600, Dorjoy Chowdhury wrote:
> +const struct nsm_cmd nsm_cmds[] = {
> + { "GetRandom", CBOR_ROOT_TYPE_STRING, handle_GetRandom },
> + { "DescribeNSM", CBOR_ROOT_TYPE_STRING, handle_DescribeNSM },
> + { "DescribePCR", CBOR_ROOT_TYPE_MAP, handle_DescribePCR },
> + { "ExtendPCR", CBOR_ROOT_TYPE_MAP, handle_ExtendPCR },
> + { "LockPCR", CBOR_ROOT_TYPE_MAP, handle_LockPCR },
> + { "LockPCRs", CBOR_ROOT_TYPE_MAP, handle_LockPCRs },
> + { "Attestation", CBOR_ROOT_TYPE_MAP, handle_Attestation },
> +};
I think we should stick to the coding style and avoid camel case
for functions. I know, it is tempting to stick to what
some spec says, but they are all inconsistent. Put the spec
name in a code comment before the function, should be
good enough.
next prev parent reply other threads:[~2024-09-15 20:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 19:57 [PATCH v6 0/8] AWS Nitro Enclave emulation support Dorjoy Chowdhury
2024-09-05 19:57 ` [PATCH v6 1/8] crypto: Define macros for hash algorithm digest lengths Dorjoy Chowdhury
2024-09-05 19:57 ` [PATCH v6 2/8] crypto: Support SHA384 hash when using glib Dorjoy Chowdhury
2024-09-05 19:57 ` [PATCH v6 3/8] crypto: Introduce x509 utils Dorjoy Chowdhury
2024-09-06 13:50 ` Daniel P. Berrangé
2024-09-06 14:07 ` Dorjoy Chowdhury
2024-09-06 14:48 ` Philippe Mathieu-Daudé
2024-09-05 19:57 ` [PATCH v6 4/8] tests/lcitool: Update libvirt-ci and add libcbor dependency Dorjoy Chowdhury
2024-09-05 19:57 ` [PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device Dorjoy Chowdhury
2024-09-15 19:26 ` Michael S. Tsirkin
2024-09-15 19:46 ` Dorjoy Chowdhury
2024-09-15 20:09 ` Michael S. Tsirkin
2024-09-15 20:11 ` Michael S. Tsirkin [this message]
2024-09-05 19:57 ` [PATCH v6 6/8] hw/core: Add Enclave Image Format (EIF) related helpers Dorjoy Chowdhury
2024-09-05 19:57 ` [PATCH v6 7/8] machine/nitro-enclave: New machine type for AWS Nitro Enclaves Dorjoy Chowdhury
2024-09-05 19:57 ` [PATCH v6 8/8] docs/nitro-enclave: Documentation for nitro-enclave machine type Dorjoy Chowdhury
2024-09-06 13:53 ` [PATCH v6 0/8] AWS Nitro Enclave emulation support Daniel P. Berrangé
2024-09-15 18:26 ` Dorjoy Chowdhury
2024-09-22 9:51 ` Dorjoy Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915160953-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=agraf@csgraf.de \
--cc=berrange@redhat.com \
--cc=dorjoychy111@gmail.com \
--cc=eduardo@habkost.net \
--cc=graf@amazon.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).