qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] block: Remove unused aio_task_pool_empty
@ 2024-09-17  0:20 dave
  2024-09-27 19:49 ` Vladimir Sementsov-Ogievskiy
  0 siblings, 1 reply; 2+ messages in thread
From: dave @ 2024-09-17  0:20 UTC (permalink / raw)
  To: jsnow, vsementsov, kwolf, hreitz
  Cc: qemu-block, qemu-devel, Dr. David Alan Gilbert

From: "Dr. David Alan Gilbert" <dave@treblig.org>

aio_task_pool_empty has been unused since it was added in
  6e9b225f73 ("block: introduce aio task pool")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
 block/aio_task.c         | 5 -----
 include/block/aio_task.h | 2 --
 2 files changed, 7 deletions(-)

diff --git a/block/aio_task.c b/block/aio_task.c
index 9bd17ea2c1..bb5c05f455 100644
--- a/block/aio_task.c
+++ b/block/aio_task.c
@@ -119,8 +119,3 @@ int aio_task_pool_status(AioTaskPool *pool)
 
     return pool->status;
 }
-
-bool aio_task_pool_empty(AioTaskPool *pool)
-{
-    return pool->busy_tasks == 0;
-}
diff --git a/include/block/aio_task.h b/include/block/aio_task.h
index 18a9c41f4e..c81d637617 100644
--- a/include/block/aio_task.h
+++ b/include/block/aio_task.h
@@ -40,8 +40,6 @@ void aio_task_pool_free(AioTaskPool *);
 /* error code of failed task or 0 if all is OK */
 int aio_task_pool_status(AioTaskPool *pool);
 
-bool aio_task_pool_empty(AioTaskPool *pool);
-
 /* User provides filled @task, however task->pool will be set automatically */
 void coroutine_fn aio_task_pool_start_task(AioTaskPool *pool, AioTask *task);
 
-- 
2.46.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] block: Remove unused aio_task_pool_empty
  2024-09-17  0:20 [PATCH] block: Remove unused aio_task_pool_empty dave
@ 2024-09-27 19:49 ` Vladimir Sementsov-Ogievskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2024-09-27 19:49 UTC (permalink / raw)
  To: dave, jsnow, kwolf, hreitz; +Cc: qemu-block, qemu-devel

On 17.09.24 03:20, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert"<dave@treblig.org>
> 
> aio_task_pool_empty has been unused since it was added in
>    6e9b225f73 ("block: introduce aio task pool")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert<dave@treblig.org>

Thanks, applied to my block branch.

-- 
Best regards,
Vladimir



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-27 19:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-17  0:20 [PATCH] block: Remove unused aio_task_pool_empty dave
2024-09-27 19:49 ` Vladimir Sementsov-Ogievskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).