qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
	"Corvin Köhne" <corvin.koehne@gmail.com>,
	"Corvin Köhne" <c.koehne@beckhoff.com>
Subject: [PULL 2/8] vfio/igd: return an invalid generation for unknown devices
Date: Tue, 17 Sep 2024 12:32:23 +0200	[thread overview]
Message-ID: <20240917103229.876515-3-clg@redhat.com> (raw)
In-Reply-To: <20240917103229.876515-1-clg@redhat.com>

From: Corvin Köhne <corvin.koehne@gmail.com>

Intel changes it's specification quite often e.g. the location and size
of the BDSM register has change for gen 11 devices and later. This
causes our emulation to fail on those devices. So, it's impossible for
us to use a suitable default value for unknown devices. Instead of
returning a random generation value and hoping that everthing works
fine, we should verify that different devices are working and add them
to our list of known devices.

Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/vfio/igd.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index d320d032a7f3b19df0d055178f6fefe4bdfd8668..650a323ddaac746de780103ca857256709c0e0aa 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -90,7 +90,11 @@ static int igd_gen(VFIOPCIDevice *vdev)
         return 8;
     }
 
-    return 8; /* Assume newer is compatible */
+    /*
+     * Unfortunately, Intel changes it's specification quite often. This makes
+     * it impossible to use a suitable default value for unknown devices.
+     */
+    return -1;
 }
 
 typedef struct VFIOIGDQuirk {
-- 
2.46.0



  parent reply	other threads:[~2024-09-17 10:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-17 10:32 [PULL 0/8] vfio queue Cédric Le Goater
2024-09-17 10:32 ` [PULL 1/8] hw/vfio/pci.c: Use correct type in trace_vfio_msix_early_setup() Cédric Le Goater
2024-09-17 10:32 ` Cédric Le Goater [this message]
2024-09-17 10:32 ` [PULL 3/8] vfio/igd: support legacy mode for all known generations Cédric Le Goater
2024-09-17 10:32 ` [PULL 4/8] vfio/igd: use new BDSM register location and size for gen 11 and later Cédric Le Goater
2024-09-17 10:32 ` [PULL 5/8] vfio/igd: add new bar0 quirk to emulate BDSM mirror Cédric Le Goater
2024-09-17 10:32 ` [PULL 6/8] vfio/igd: add ID's for ElkhartLake and TigerLake Cédric Le Goater
2024-09-17 10:32 ` [PULL 7/8] vfio/igd: don't set stolen memory size to zero Cédric Le Goater
2024-09-17 10:32 ` [PULL 8/8] vfio/igd: correctly calculate stolen memory size for gen 9 and later Cédric Le Goater
2024-09-17 14:48 ` [PULL 0/8] vfio queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240917103229.876515-3-clg@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=c.koehne@beckhoff.com \
    --cc=corvin.koehne@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).