From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
"Corvin Köhne" <corvin.koehne@gmail.com>,
"Corvin Köhne" <c.koehne@beckhoff.com>
Subject: [PULL 3/8] vfio/igd: support legacy mode for all known generations
Date: Tue, 17 Sep 2024 12:32:24 +0200 [thread overview]
Message-ID: <20240917103229.876515-4-clg@redhat.com> (raw)
In-Reply-To: <20240917103229.876515-1-clg@redhat.com>
From: Corvin Köhne <corvin.koehne@gmail.com>
We're soon going to add support for legacy mode to ElkhartLake and
TigerLake devices. Those are gen 11 and 12 devices. At the moment, all
devices identified by our igd_gen function do support legacy mode. This
won't change when adding our new devices of gen 11 and 12. Therefore, it
makes more sense to accept legacy mode for all known devices instead of
maintaining a long list of known good generations. If we add a new
generation to igd_gen which doesn't support legacy mode for some reason,
it'll be easy to advance the check to reject legacy mode for this
specific generation.
Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/vfio/igd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index 650a323ddaac746de780103ca857256709c0e0aa..d5e57656a8b7bb207b421977f9a2c76943d4a899 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -416,7 +416,7 @@ void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)
* devices maintain compatibility with generation 8.
*/
gen = igd_gen(vdev);
- if (gen != 6 && gen != 8) {
+ if (gen == -1) {
error_report("IGD device %s is unsupported in legacy mode, "
"try SandyBridge or newer", vdev->vbasedev.name);
return;
--
2.46.0
next prev parent reply other threads:[~2024-09-17 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 10:32 [PULL 0/8] vfio queue Cédric Le Goater
2024-09-17 10:32 ` [PULL 1/8] hw/vfio/pci.c: Use correct type in trace_vfio_msix_early_setup() Cédric Le Goater
2024-09-17 10:32 ` [PULL 2/8] vfio/igd: return an invalid generation for unknown devices Cédric Le Goater
2024-09-17 10:32 ` Cédric Le Goater [this message]
2024-09-17 10:32 ` [PULL 4/8] vfio/igd: use new BDSM register location and size for gen 11 and later Cédric Le Goater
2024-09-17 10:32 ` [PULL 5/8] vfio/igd: add new bar0 quirk to emulate BDSM mirror Cédric Le Goater
2024-09-17 10:32 ` [PULL 6/8] vfio/igd: add ID's for ElkhartLake and TigerLake Cédric Le Goater
2024-09-17 10:32 ` [PULL 7/8] vfio/igd: don't set stolen memory size to zero Cédric Le Goater
2024-09-17 10:32 ` [PULL 8/8] vfio/igd: correctly calculate stolen memory size for gen 9 and later Cédric Le Goater
2024-09-17 14:48 ` [PULL 0/8] vfio queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917103229.876515-4-clg@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=c.koehne@beckhoff.com \
--cc=corvin.koehne@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).