From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Pierrick Bouvier <pierrick.bouvier@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>
Subject: [PULL 09/17] tests/unit: replace assert(0) with g_assert_not_reached()
Date: Tue, 17 Sep 2024 12:35:32 +0200 [thread overview]
Message-ID: <20240917103540.149144-10-thuth@redhat.com> (raw)
In-Reply-To: <20240917103540.149144-1-thuth@redhat.com>
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20240912073921.453203-14-pierrick.bouvier@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/unit/test-xs-node.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c
index ac94e7ed6c..2f447a73fb 100644
--- a/tests/unit/test-xs-node.c
+++ b/tests/unit/test-xs-node.c
@@ -212,7 +212,7 @@ static void compare_tx(gpointer key, gpointer val, gpointer opaque)
printf("Comparison failure in TX %u after serdes:\n", tx_id);
dump_ref("Original", t1->root, 0);
dump_ref("Deserialised", t2->root, 0);
- g_assert(0);
+ g_assert_not_reached();
}
g_assert(t1->nr_nodes == t2->nr_nodes);
}
@@ -257,7 +257,7 @@ static void check_serdes(XenstoreImplState *s)
printf("Comparison failure in main tree after serdes:\n");
dump_ref("Original", s->root, 0);
dump_ref("Deserialised", s2->root, 0);
- g_assert(0);
+ g_assert_not_reached();
}
nr_transactions1 = g_hash_table_size(s->transactions);
--
2.46.0
next prev parent reply other threads:[~2024-09-17 10:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 10:35 [PULL 00/17] s390x and test patches Thomas Huth
2024-09-17 10:35 ` [PULL 01/17] tests/qtest/cdrom-test: Improve the machine detection in the cdrom test Thomas Huth
2024-09-17 10:35 ` [PULL 02/17] tests/qtest/boot-order-test: Make the machine name mandatory in this test Thomas Huth
2024-09-17 10:35 ` [PULL 03/17] tests/qtest/hd-geo-test: Check for availability of "pc" machine before using it Thomas Huth
2024-09-17 10:35 ` [PULL 04/17] tests/qtest/meson.build: Add more CONFIG switches checks for the x86 tests Thomas Huth
2024-09-17 10:35 ` [PULL 05/17] tests/qtest: Disable numa-test if the default machine is not available Thomas Huth
2024-09-17 10:35 ` [PULL 06/17] .gitlab-ci.d/buildtest: Build most targets in the build-without-defaults job Thomas Huth
2024-09-17 10:35 ` [PULL 07/17] gitlab: fix logic for changing docker tag on stable branches Thomas Huth
2024-09-17 10:35 ` [PULL 08/17] tests/qtest: replace assert(0) with g_assert_not_reached() Thomas Huth
2024-09-17 10:35 ` Thomas Huth [this message]
2024-09-17 10:35 ` [PULL 10/17] include/hw/s390x: replace assert(false) " Thomas Huth
2024-09-17 10:35 ` [PULL 11/17] tests/qtest: " Thomas Huth
2024-09-17 10:35 ` [PULL 12/17] tests/qtest: remove break after g_assert_not_reached() Thomas Huth
2024-09-17 10:35 ` [PULL 13/17] system: Sort QEMU_ARCH_VIRTIO_PCI definition Thomas Huth
2024-09-17 10:35 ` [PULL 14/17] system: Enable the device aliases for or1k, too Thomas Huth
2024-09-17 10:35 ` [PULL 15/17] docs/fuzz: fix outdated mention to enable-sanitizers Thomas Huth
2024-09-17 10:35 ` [PULL 16/17] tests/functional: Move the mips64el fuloong2e test into the thorough category Thomas Huth
2024-09-17 10:35 ` [PULL 17/17] .gitlab-ci.d/crossbuilds.yml: Force 'make check' to -j2 for cross-i686-tci Thomas Huth
2024-09-17 14:48 ` [PULL 00/17] s390x and test patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917103540.149144-10-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).