From: dave@treblig.org
To: peterx@redhat.com, farosas@suse.de, eblake@redhat.com, armbru@redhat.com
Cc: qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dave@treblig.org>
Subject: [PATCH 3/3] migration: Remove unused socket_send_channel_create_sync
Date: Wed, 18 Sep 2024 01:02:07 +0100 [thread overview]
Message-ID: <20240918000207.182683-4-dave@treblig.org> (raw)
In-Reply-To: <20240918000207.182683-1-dave@treblig.org>
From: "Dr. David Alan Gilbert" <dave@treblig.org>
socket_send_channel_create_sync only use was removed by
d0edb8a173 ("migration: Create the postcopy preempt channel asynchronously")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
migration/socket.c | 18 ------------------
migration/socket.h | 1 -
2 files changed, 19 deletions(-)
diff --git a/migration/socket.c b/migration/socket.c
index 9ab89b1e08..5ec65b8c03 100644
--- a/migration/socket.c
+++ b/migration/socket.c
@@ -42,24 +42,6 @@ void socket_send_channel_create(QIOTaskFunc f, void *data)
f, data, NULL, NULL);
}
-QIOChannel *socket_send_channel_create_sync(Error **errp)
-{
- QIOChannelSocket *sioc = qio_channel_socket_new();
-
- if (!outgoing_args.saddr) {
- object_unref(OBJECT(sioc));
- error_setg(errp, "Initial sock address not set!");
- return NULL;
- }
-
- if (qio_channel_socket_connect_sync(sioc, outgoing_args.saddr, errp) < 0) {
- object_unref(OBJECT(sioc));
- return NULL;
- }
-
- return QIO_CHANNEL(sioc);
-}
-
struct SocketConnectData {
MigrationState *s;
char *hostname;
diff --git a/migration/socket.h b/migration/socket.h
index 46c233ecd2..04ebbe95a1 100644
--- a/migration/socket.h
+++ b/migration/socket.h
@@ -22,7 +22,6 @@
#include "qemu/sockets.h"
void socket_send_channel_create(QIOTaskFunc f, void *data);
-QIOChannel *socket_send_channel_create_sync(Error **errp);
void socket_start_incoming_migration(SocketAddress *saddr, Error **errp);
--
2.46.0
next prev parent reply other threads:[~2024-09-18 0:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 0:02 [PATCH 0/3] Migration deadcode removal dave
2024-09-18 0:02 ` [PATCH 1/3] migration: Remove migrate_cap_set dave
2024-09-19 12:12 ` Fabiano Rosas
2024-09-18 0:02 ` [PATCH 2/3] migration: Remove unused zero-blocks capability dave
2024-09-18 5:52 ` Markus Armbruster
2024-09-18 16:27 ` Peter Xu
2024-09-19 10:39 ` Markus Armbruster
2024-09-19 12:57 ` Fabiano Rosas
2024-09-19 13:00 ` Dr. David Alan Gilbert
2024-09-19 13:43 ` Peter Xu
2024-09-18 0:02 ` dave [this message]
2024-09-19 12:12 ` [PATCH 3/3] migration: Remove unused socket_send_channel_create_sync Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918000207.182683-4-dave@treblig.org \
--to=dave@treblig.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).