qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: [PULL 11/18] tests/tcg: only read/write 64 bit words on 64 bit systems
Date: Wed, 18 Sep 2024 22:07:05 +0100	[thread overview]
Message-ID: <20240918210712.2336854-12-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240918210712.2336854-1-alex.bennee@linaro.org>

While the compilers will generally happily synthesise a 64 bit value
for you on 32 bit systems it doesn't exercise anything on QEMU. It
also makes it hard to accurately compare the accesses to test_data
when instrumenting.

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240916085400.1046925-12-alex.bennee@linaro.org>

diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c
index 8f2371975d..28080767b2 100644
--- a/tests/tcg/multiarch/system/memory.c
+++ b/tests/tcg/multiarch/system/memory.c
@@ -163,6 +163,7 @@ static void init_test_data_u32(int offset)
     ml_printf("done %d @ %p\n", i, ptr);
 }
 
+#if __SIZEOF_POINTER__ >= 8
 static void init_test_data_u64(int offset)
 {
     uint8_t count = 0;
@@ -187,6 +188,7 @@ static void init_test_data_u64(int offset)
     }
     ml_printf("done %d @ %p\n", i, ptr);
 }
+#endif
 
 static bool read_test_data_u16(int offset)
 {
@@ -254,6 +256,7 @@ static bool read_test_data_u32(int offset)
     return true;
 }
 
+#if __SIZEOF_POINTER__ >= 8
 static bool read_test_data_u64(int offset)
 {
     uint64_t word, *ptr = (uint64_t *)&test_data[offset];
@@ -307,11 +310,16 @@ static bool read_test_data_u64(int offset)
     ml_printf("done %d @ %p\n", i, ptr);
     return true;
 }
+#endif
 
 /* Read the test data and verify at various offsets */
-read_ufn read_ufns[] = { read_test_data_u16,
-                         read_test_data_u32,
-                         read_test_data_u64 };
+read_ufn read_ufns[] = {
+    read_test_data_u16,
+    read_test_data_u32,
+#if __SIZEOF_POINTER__ >= 8
+    read_test_data_u64
+#endif
+};
 
 bool do_unsigned_reads(int start_off)
 {
@@ -476,10 +484,14 @@ bool do_signed_reads(bool neg_first)
     return ok;
 }
 
-init_ufn init_ufns[] = { init_test_data_u8,
-                         init_test_data_u16,
-                         init_test_data_u32,
-                         init_test_data_u64 };
+init_ufn init_ufns[] = {
+    init_test_data_u8,
+    init_test_data_u16,
+    init_test_data_u32,
+#if __SIZEOF_POINTER__ >= 8
+    init_test_data_u64
+#endif
+};
 
 int main(void)
 {
-- 
2.39.5



  parent reply	other threads:[~2024-09-18 21:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 21:06 [PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins) Alex Bennée
2024-09-18 21:06 ` [PULL 01/18] deprecation: don't enable TCG plugins by default on 32 bit hosts Alex Bennée
2024-09-18 21:06 ` [PULL 02/18] deprecation: don't enable TCG plugins by default with TCI Alex Bennée
2024-09-18 21:06 ` [PULL 03/18] contrib/plugins: control flow plugin Alex Bennée
2024-09-18 21:06 ` [PULL 04/18] plugins: save value during memory accesses Alex Bennée
2024-09-18 21:06 ` [PULL 05/18] plugins: extend API to get latest memory value accessed Alex Bennée
2024-09-18 21:07 ` [PULL 06/18] tests/tcg: add mechanism to run specific tests with plugins Alex Bennée
2024-09-18 21:07 ` [PULL 07/18] tests/tcg: allow to check output of plugins Alex Bennée
2024-09-18 21:07 ` [PULL 08/18] tests/tcg/plugins/mem: add option to print memory accesses Alex Bennée
2024-09-18 21:07 ` [PULL 09/18] tests/tcg/multiarch: add test for plugin memory access Alex Bennée
2024-09-18 21:07 ` [PULL 10/18] tests/tcg: clean up output of memory system test Alex Bennée
2024-09-18 21:07 ` Alex Bennée [this message]
2024-09-18 21:07 ` [PULL 12/18] tests/tcg: ensure s390x-softmmu output redirected Alex Bennée
2024-09-18 21:07 ` [PULL 13/18] tests/tcg: add a system test to check memory instrumentation Alex Bennée
2024-09-18 21:07 ` [PULL 14/18] util/timer: avoid deadlock when shutting down Alex Bennée
2024-09-18 21:07 ` [PULL 15/18] contrib/plugins: Add a plugin to generate basic block vectors Alex Bennée
2024-09-18 21:07 ` [PULL 16/18] plugins: add plugin API to read guest memory Alex Bennée
2024-09-18 21:07 ` [PULL 17/18] plugins: add option to dump write argument to syscall plugin Alex Bennée
2024-09-18 21:07 ` [PULL 18/18] contrib/plugins: avoid hanging program Alex Bennée
2024-09-19  9:50 ` [PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins) Peter Maydell
2024-09-19 13:11   ` Alex Bennée
2024-09-19 13:14     ` Peter Maydell
2024-09-19 14:33       ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240918210712.2336854-12-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).