Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

[Igor Mammedov <imammedo@redhat.com>]

On Thu, 19 Sep 2024 13:34:54 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On Tue, 10 Sept 2024 at 10:38, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Tue, 10 Sept 2024 at 10:03, Igor Mammedov <imammedo@redhat.com> wrote:  
> > >
> > > On Mon, 19 Aug 2024 15:43:03 +0100
> > > Peter Maydell <peter.maydell@linaro.org> wrote:  
> > > > @@ -83,34 +83,32 @@ vCPU hotplug
> > > >
> > > >        (QEMU) query-cpus-fast
> > > >        {
> > > > -          "execute": "query-cpus-fast",
> > > >            "arguments": {}
> > > > +          "execute": "query-cpus-fast",
> > > >        }
> > > >        {
> > > >            "return": [
> > > >                {
> > > > -                  "qom-path": "/machine/unattached/device[0]",
> > > > -                  "target": "x86_64",
> > > > -                  "thread-id": 11534,
> > > >                    "cpu-index": 0,
> > > >                    "props": {
> > > > -                      "socket-id": 0,
> > > >                        "core-id": 0,
> > > > +                      "socket-id": 0,
> > > >                        "thread-id": 0
> > > >                    },
> > > > -                  "arch": "x86"
> > > > +                  "qom-path": "/machine/unattached/device[0]",
> > > > +                  "target": "x86_64",
> > > > +                  "thread-id": 28957
> > > >                },
> > > >                {
> > > > -                  "qom-path": "/machine/peripheral/cpu-2",
> > > > -                  "target": "x86_64",
> > > > -                  "thread-id": 12106,
> > > >                    "cpu-index": 1,
> > > >                    "props": {
> > > > -                      "socket-id": 1,
> > > > -                      "core-id": 0,
> > > > +                      "core-id": 1,
> > > > +                      "socket-id": 0,
> > > >                        "thread-id": 0
> > > >                    },
> > > > -                  "arch": "x86"
> > > > +                  "qom-path": "/machine/peripheral/cpu-2",
> > > > +                  "target": "x86_64",
> > > > +                  "thread-id": 29095
> > > >                }  
> > >
> > > beside reordering, which seems fine, this hunk also introduces target change
> > > perhaps a separate patch for that?  
> >
> > What target change? It all says "target": "x86_64" both before
> > and after. 

my mistake,
I should've said  '"arch": "x86"' instead, which is gone after the patch

> 
> Hi Igor, would you mind clarifying what you meant here?
> I'm happy to respin, but I don't understand what change you're
> asking for.
> 
> thanks
> -- PMM
>