qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Julia Suvorova <jusual@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Song Gao" <gaosong@loongson.cn>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Julia Suvorova" <jusual@redhat.com>
Subject: [PATCH v2 0/2] kvm: Improve register failure reports for migration
Date: Fri, 27 Sep 2024 12:47:39 +0200	[thread overview]
Message-ID: <20240927104743.218468-1-jusual@redhat.com> (raw)

There were a few bugs with silent cpu failures during migrations [1].
The failures are no longer silent thanks to [2], but still
indistinguishable, making diagnostics difficult.

This patchset reworks kvm_arch_get/put_registers to handle Error** and
return a correct message, with x86_64 as a start.

[1] https://issues.redhat.com/browse/RHEL-7558
[2] 7191f24c7fcf "accel/kvm/kvm-all: Handle register access errors"

--
v2:
    * made all reports as error_reportf_err() and fixed prefixes [Peter]

Julia Suvorova (2):
  kvm: Allow kvm_arch_get/put_registers to accept Error**
  target/i386/kvm: Report which action failed in
    kvm_arch_put/get_registers

 accel/kvm/kvm-all.c        | 41 +++++++++++++++++++++++++++++---------
 include/sysemu/kvm.h       |  4 ++--
 target/arm/kvm.c           |  4 ++--
 target/i386/kvm/kvm.c      | 27 +++++++++++++++++++++++--
 target/loongarch/kvm/kvm.c |  4 ++--
 target/mips/kvm.c          |  4 ++--
 target/ppc/kvm.c           |  2 +-
 target/riscv/kvm/kvm-cpu.c |  4 ++--
 target/s390x/kvm/kvm.c     |  4 ++--
 9 files changed, 70 insertions(+), 24 deletions(-)

-- 
2.45.0



             reply	other threads:[~2024-09-27 10:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 10:47 Julia Suvorova [this message]
2024-09-27 10:47 ` [PATCH v2 1/2] kvm: Allow kvm_arch_get/put_registers to accept Error** Julia Suvorova
2024-09-27 10:47 ` [PATCH v2 2/2] target/i386/kvm: Report which action failed in kvm_arch_put/get_registers Julia Suvorova
2024-10-02 11:06 ` [PATCH v2 0/2] kvm: Improve register failure reports for migration Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927104743.218468-1-jusual@redhat.com \
    --to=jusual@redhat.com \
    --cc=alistair.francis@wdc.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=danielhb413@gmail.com \
    --cc=gaosong@loongson.cn \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).