* [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object
@ 2024-09-27 21:32 Philippe Mathieu-Daudé
2024-09-27 21:32 ` [PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-27 21:32 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Jiaxun Yang, Song Gao, Philippe Mathieu-Daudé
LoongArch fw_cfg.c doesn't use target specific declarations,
build it as common object.
Philippe Mathieu-Daudé (2):
hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion
hw/loongarch/fw_cfg: Build in common_ss[]
include/hw/loongarch/virt.h | 1 -
hw/loongarch/meson.build | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
--
2.45.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion
2024-09-27 21:32 [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object Philippe Mathieu-Daudé
@ 2024-09-27 21:32 ` Philippe Mathieu-Daudé
2024-09-30 8:01 ` Thomas Huth
2024-09-27 21:32 ` [PATCH 2/2] hw/loongarch/fw_cfg: Build in common_ss[] Philippe Mathieu-Daudé
2024-09-29 8:15 ` [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object gaosong
2 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-27 21:32 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Jiaxun Yang, Song Gao, Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/loongarch/virt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
index c373e48f27..9ba47793ef 100644
--- a/include/hw/loongarch/virt.h
+++ b/include/hw/loongarch/virt.h
@@ -8,7 +8,6 @@
#ifndef HW_LOONGARCH_H
#define HW_LOONGARCH_H
-#include "target/loongarch/cpu.h"
#include "hw/boards.h"
#include "qemu/queue.h"
#include "hw/block/flash.h"
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion
2024-09-27 21:32 ` [PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion Philippe Mathieu-Daudé
@ 2024-09-30 8:01 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2024-09-30 8:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Jiaxun Yang, Song Gao, QEMU Trivial
On 27/09/2024 23.32, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/loongarch/virt.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
> index c373e48f27..9ba47793ef 100644
> --- a/include/hw/loongarch/virt.h
> +++ b/include/hw/loongarch/virt.h
> @@ -8,7 +8,6 @@
> #ifndef HW_LOONGARCH_H
> #define HW_LOONGARCH_H
>
> -#include "target/loongarch/cpu.h"
> #include "hw/boards.h"
> #include "qemu/queue.h"
> #include "hw/block/flash.h"
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] hw/loongarch/fw_cfg: Build in common_ss[]
2024-09-27 21:32 [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object Philippe Mathieu-Daudé
2024-09-27 21:32 ` [PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion Philippe Mathieu-Daudé
@ 2024-09-27 21:32 ` Philippe Mathieu-Daudé
2024-09-30 8:02 ` Thomas Huth
2024-09-29 8:15 ` [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object gaosong
2 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-27 21:32 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Jiaxun Yang, Song Gao, Philippe Mathieu-Daudé
Nothing in LoongArch fw_cfg.c requires target specific definitions.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/loongarch/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/loongarch/meson.build b/hw/loongarch/meson.build
index bce7ebac97..005f017e21 100644
--- a/hw/loongarch/meson.build
+++ b/hw/loongarch/meson.build
@@ -1,8 +1,8 @@
loongarch_ss = ss.source_set()
loongarch_ss.add(files(
- 'fw_cfg.c',
'boot.c',
))
+common_ss.add(when: 'CONFIG_LOONGARCH_VIRT', if_true: files('fw_cfg.c'))
loongarch_ss.add(when: 'CONFIG_LOONGARCH_VIRT', if_true: files('virt.c'))
loongarch_ss.add(when: 'CONFIG_ACPI', if_true: files('acpi-build.c'))
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] hw/loongarch/fw_cfg: Build in common_ss[]
2024-09-27 21:32 ` [PATCH 2/2] hw/loongarch/fw_cfg: Build in common_ss[] Philippe Mathieu-Daudé
@ 2024-09-30 8:02 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2024-09-30 8:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Jiaxun Yang, Song Gao
On 27/09/2024 23.32, Philippe Mathieu-Daudé wrote:
> Nothing in LoongArch fw_cfg.c requires target specific definitions.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/loongarch/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/loongarch/meson.build b/hw/loongarch/meson.build
> index bce7ebac97..005f017e21 100644
> --- a/hw/loongarch/meson.build
> +++ b/hw/loongarch/meson.build
> @@ -1,8 +1,8 @@
> loongarch_ss = ss.source_set()
> loongarch_ss.add(files(
> - 'fw_cfg.c',
> 'boot.c',
> ))
> +common_ss.add(when: 'CONFIG_LOONGARCH_VIRT', if_true: files('fw_cfg.c'))
> loongarch_ss.add(when: 'CONFIG_LOONGARCH_VIRT', if_true: files('virt.c'))
> loongarch_ss.add(when: 'CONFIG_ACPI', if_true: files('acpi-build.c'))
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object
2024-09-27 21:32 [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object Philippe Mathieu-Daudé
2024-09-27 21:32 ` [PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion Philippe Mathieu-Daudé
2024-09-27 21:32 ` [PATCH 2/2] hw/loongarch/fw_cfg: Build in common_ss[] Philippe Mathieu-Daudé
@ 2024-09-29 8:15 ` gaosong
2 siblings, 0 replies; 6+ messages in thread
From: gaosong @ 2024-09-29 8:15 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Thomas Huth, Jiaxun Yang
在 2024/9/28 上午5:32, Philippe Mathieu-Daudé 写道:
> LoongArch fw_cfg.c doesn't use target specific declarations,
> build it as common object.
>
> Philippe Mathieu-Daudé (2):
> hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion
> hw/loongarch/fw_cfg: Build in common_ss[]
>
> include/hw/loongarch/virt.h | 1 -
> hw/loongarch/meson.build | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Applied to loongarch-next.
Thanks.
Song Gao
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-30 8:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-27 21:32 [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object Philippe Mathieu-Daudé
2024-09-27 21:32 ` [PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion Philippe Mathieu-Daudé
2024-09-30 8:01 ` Thomas Huth
2024-09-27 21:32 ` [PATCH 2/2] hw/loongarch/fw_cfg: Build in common_ss[] Philippe Mathieu-Daudé
2024-09-30 8:02 ` Thomas Huth
2024-09-29 8:15 ` [PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object gaosong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).