From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, "Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Jason Wang" <jasowang@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 3/4] hw/ppc/vof: Simplify LD/ST API uses
Date: Fri, 27 Sep 2024 23:45:30 +0200 [thread overview]
Message-ID: <20240927214531.20242-4-philmd@linaro.org> (raw)
In-Reply-To: <20240927214531.20242-1-philmd@linaro.org>
Directly call ldn_be_p once instead of be32_to_cpu / ldq_be_p.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/ppc/vof.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c
index b5b6514d79..fb152efbe0 100644
--- a/hw/ppc/vof.c
+++ b/hw/ppc/vof.c
@@ -645,11 +645,7 @@ static void vof_dt_memory_available(void *fdt, GArray *claimed, uint64_t base)
mem0_reg = fdt_getprop(fdt, offset, "reg", &proplen);
g_assert(mem0_reg && proplen == sizeof(uint32_t) * (ac + sc));
- if (sc == 2) {
- mem0_end = ldq_be_p(mem0_reg + sizeof(uint32_t) * ac);
- } else {
- mem0_end = be32_to_cpu(*(uint32_t *)(mem0_reg + sizeof(uint32_t) * ac));
- }
+ mem0_end = ldn_be_p(mem0_reg + sizeof(uint32_t) * ac, 4 * sc);
g_array_sort(claimed, of_claimed_compare_func);
vof_claimed_dump(claimed);
--
2.45.2
next prev parent reply other threads:[~2024-09-27 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 21:45 [PATCH 0/4] hw/ppc & net: Simplify LD/ST API uses Philippe Mathieu-Daudé
2024-09-27 21:45 ` [PATCH 1/4] hw/ppc/spapr_nvdimm: " Philippe Mathieu-Daudé
2024-09-27 21:45 ` [PATCH 2/4] hw/ppc/spapr_vof: " Philippe Mathieu-Daudé
2024-09-27 21:45 ` Philippe Mathieu-Daudé [this message]
2024-09-27 21:45 ` [PATCH 4/4] net/l2tpv3: " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240927214531.20242-4-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=aik@ozlabs.ru \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).