From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, mst@redhat.com, jasowang@redhat.com,
qemu-devel@nongnu.org
Subject: [PATCH v2 3/3] virtio_net: Add the 3rd acceptable situation for Mac setup.
Date: Sun, 29 Sep 2024 23:59:57 +0800 [thread overview]
Message-ID: <20240929160045.2133423-4-lulu@redhat.com> (raw)
In-Reply-To: <20240929160045.2133423-1-lulu@redhat.com>
While the hardware MAC address is 0 and the MAC address in
the QEMU command line is also 0, this configuration is
acceptable.
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
hw/net/virtio-net.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 5c610d8078..668fbed9f2 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3620,6 +3620,17 @@ static bool virtio_net_check_vdpa_mac(NetClientState *nc, VirtIONet *n,
return true;
}
}
+ /*
+ * 3.The hardware MAC address is 0,
+ * and the MAC address in the QEMU command line is also 0.
+ * In this situation, qemu will use random mac address
+ */
+ if ((memcmp(&hwcfg.mac, &zero, sizeof(MACAddr)) == 0) &&
+ (memcmp(cmdline_mac, &zero, sizeof(MACAddr)) == 0)) {
+ memcpy(&n->mac[0], &n->nic_conf.macaddr, sizeof(n->mac));
+
+ return true;
+ }
error_setg(errp,
"vDPA device's mac %02x:%02x:%02x:%02x:%02x:%02x"
--
2.45.0
next prev parent reply other threads:[~2024-09-29 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 15:59 [PATCH v2 0/3] virtio_net: Add the check for vdpa's mac address Cindy Lu
2024-09-29 15:59 ` [PATCH v2 1/3] " Cindy Lu
2024-10-09 8:28 ` Jason Wang
2024-09-29 15:59 ` [PATCH v2 2/3] virtio_net: Add the 2rd acceptable situation for Mac setup Cindy Lu
2024-10-09 8:29 ` Jason Wang
2024-10-14 1:50 ` Cindy Lu
2024-09-29 15:59 ` Cindy Lu [this message]
2024-10-09 8:30 ` [PATCH v2 3/3] virtio_net: Add the 3rd " Jason Wang
2024-10-14 1:50 ` Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240929160045.2133423-4-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).