From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Prasad Pandit <ppandit@redhat.com>,
Julia Suvorova <jusual@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
peterx@redhat.com, Fabiano Rosas <farosas@suse.de>,
Juraj Marcin <jmarcin@redhat.com>,
"Dr . David Alan Gilbert" <dave@treblig.org>
Subject: [PATCH 0/7] migration: query-migrationthreads enhancements and cleanups
Date: Mon, 30 Sep 2024 15:58:30 -0400 [thread overview]
Message-ID: <20240930195837.825728-1-peterx@redhat.com> (raw)
Prasad reported a misalignment issue with query-migrationthreads v.s. the
recently migration thread name changes. So I prepared patch 1, which will
make the main thread on src be named the same way reported either in
pthread or QMP query-migrationthreads API.
Then I found quite something missing around query-migrationthreads. E.g.,
it so far only accounts multifd sender threads, while it ignored too many
other kinds of migration threads (either postcopy ones, destination multifd
threads, temporary threads etc.). It means even if an admin can get TIDs
on src QEMU and does pinning (assuming that was the goal of the original
API), it won't be able to do the same for dest QEMUs, which seems to lose
its purpose.
HMP is also missing, I added it too, as thread IDs can definitely be good
candidates during debugging. If we have QMP ready, it sounds like it
should naturally fit the HMP one too.
I did some cleanups here and there all around. Feel free to have a look,
thanks.
CI: https://gitlab.com/peterx/qemu/-/pipelines/1475958754
Peter Xu (7):
migration: Unify names of migration src main thread
migration: Put thread names together with macros
migration: Remove thread_id in migration_threads_add()
migration: Simplify migration-threads API
migration: Add all threads with QMP query-migrationthreads
migration: Remove MigrationThread and threadinfo.h
hmp: Add "info migrationthreads"
include/monitor/hmp.h | 1 +
migration/migration.h | 17 ++++++++++
migration/threadinfo.h | 25 --------------
migration/colo.c | 10 ++++--
migration/dirtyrate.c | 13 ++++++--
migration/migration-hmp-cmds.c | 25 ++++++++++++++
migration/migration.c | 19 ++++++-----
migration/multifd.c | 18 ++++++----
migration/postcopy-ram.c | 16 ++++++---
migration/savevm.c | 13 +++++---
migration/threadinfo.c | 61 ++++++++++++++++++++--------------
hmp-commands-info.hx | 13 ++++++++
12 files changed, 150 insertions(+), 81 deletions(-)
delete mode 100644 migration/threadinfo.h
--
2.45.0
next reply other threads:[~2024-09-30 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 19:58 Peter Xu [this message]
2024-09-30 19:58 ` [PATCH 1/7] migration: Unify names of migration src main thread Peter Xu
2024-09-30 19:58 ` [PATCH 2/7] migration: Put thread names together with macros Peter Xu
2024-09-30 19:58 ` [PATCH 3/7] migration: Remove thread_id in migration_threads_add() Peter Xu
2024-09-30 19:58 ` [PATCH 4/7] migration: Simplify migration-threads API Peter Xu
2024-09-30 19:58 ` [PATCH 5/7] migration: Add all threads with QMP query-migrationthreads Peter Xu
2024-09-30 19:58 ` [PATCH 6/7] migration: Remove MigrationThread and threadinfo.h Peter Xu
2024-09-30 19:58 ` [PATCH 7/7] hmp: Add "info migrationthreads" Peter Xu
2024-09-30 23:43 ` Dr. David Alan Gilbert
2024-10-01 5:46 ` [PATCH 0/7] migration: query-migrationthreads enhancements and cleanups Markus Armbruster
2024-10-01 14:25 ` Daniel P. Berrangé
2024-10-01 15:06 ` Peter Xu
2024-10-02 5:58 ` Markus Armbruster
2024-10-10 19:46 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930195837.825728-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=jmarcin@redhat.com \
--cc=jusual@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).