qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: npiggin@gmail.com, danielhb413@gmail.com, clg@kaod.org
Subject: [PATCH v2 09/11] ppc/spapr: remove deprecated machine pseries-2.9
Date: Tue,  1 Oct 2024 14:59:08 +0530	[thread overview]
Message-ID: <20241001092910.1030913-10-harshpb@linux.ibm.com> (raw)
In-Reply-To: <20241001092910.1030913-1-harshpb@linux.ibm.com>

Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.9 specific code with this patch for now.

Suggested-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
---
 target/ppc/cpu.h      |  1 -
 hw/ppc/spapr.c        | 20 --------------------
 target/ppc/cpu_init.c |  2 --
 target/ppc/machine.c  |  2 +-
 4 files changed, 1 insertion(+), 24 deletions(-)

diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index cab4a46fc1..74a0ab768d 100644
--- a/target/ppc/cpu.h
+++ b/target/ppc/cpu.h
@@ -1456,7 +1456,6 @@ struct ArchCPU {
     opc_handler_t *opcodes[PPC_CPU_OPCODES_LEN];
 
     /* Fields related to migration compatibility hacks */
-    bool pre_2_10_migration;
     bool pre_3_0_migration;
     int32_t mig_slb_nr;
 };
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 97ab253fcc..84da4ece77 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -5184,26 +5184,6 @@ static void spapr_machine_2_10_class_options(MachineClass *mc)
 
 DEFINE_SPAPR_MACHINE(2, 10);
 
-/*
- * pseries-2.9
- */
-
-static void spapr_machine_2_9_class_options(MachineClass *mc)
-{
-    SpaprMachineClass *smc = SPAPR_MACHINE_CLASS(mc);
-    static GlobalProperty compat[] = {
-        { TYPE_POWERPC_CPU, "pre-2.10-migration", "on" },
-    };
-
-    spapr_machine_2_10_class_options(mc);
-    compat_props_add(mc->compat_props, hw_compat_2_9, hw_compat_2_9_len);
-    compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat));
-    smc->pre_2_10_has_unused_icps = true;
-    smc->resize_hpt_default = SPAPR_RESIZE_HPT_DISABLED;
-}
-
-DEFINE_SPAPR_MACHINE(2, 9);
-
 static void spapr_machine_register_types(void)
 {
     type_register_static(&spapr_machine_info);
diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
index 7768392986..39c19e6674 100644
--- a/target/ppc/cpu_init.c
+++ b/target/ppc/cpu_init.c
@@ -7452,8 +7452,6 @@ static void ppc_disas_set_info(CPUState *cs, disassemble_info *info)
 }
 
 static Property ppc_cpu_properties[] = {
-    DEFINE_PROP_BOOL("pre-2.10-migration", PowerPCCPU, pre_2_10_migration,
-                     false),
     DEFINE_PROP_BOOL("pre-3.0-migration", PowerPCCPU, pre_3_0_migration,
                      false),
     DEFINE_PROP_END_OF_LIST(),
diff --git a/target/ppc/machine.c b/target/ppc/machine.c
index 21bed7c7c8..47495b68b1 100644
--- a/target/ppc/machine.c
+++ b/target/ppc/machine.c
@@ -630,7 +630,7 @@ static bool compat_needed(void *opaque)
     PowerPCCPU *cpu = opaque;
 
     assert(!(cpu->compat_pvr && !cpu->vhyp));
-    return !cpu->pre_2_10_migration && cpu->compat_pvr != 0;
+    return cpu->compat_pvr != 0;
 }
 
 static const VMStateDescription vmstate_compat = {
-- 
2.45.2



  parent reply	other threads:[~2024-10-01 14:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01  9:28 [PATCH v2 00/11] ppc/spapr: remove deprecated machines specific code Harsh Prateek Bora
2024-10-01  9:29 ` [PATCH v2 01/11] ppc/spapr: remove deprecated machine pseries-2.1 Harsh Prateek Bora
2024-10-02  6:32   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 02/11] ppc/spapr: remove deprecated machine pseries-2.2 Harsh Prateek Bora
2024-10-02  6:34   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 03/11] ppc/spapr: remove deprecated machine pseries-2.3 Harsh Prateek Bora
2024-10-02  6:36   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 04/11] ppc/spapr: remove deprecated machine pseries-2.4 Harsh Prateek Bora
2024-10-02  6:38   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 05/11] ppc/spapr: remove deprecated machine pseries-2.5 Harsh Prateek Bora
2024-10-02  6:44   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 06/11] ppc/spapr: remove deprecated machine pseries-2.6 Harsh Prateek Bora
2024-10-02  6:49   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 07/11] ppc/spapr: remove deprecated machine pseries-2.7 Harsh Prateek Bora
2024-10-02  6:51   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 08/11] ppc/spapr: remove deprecated machine pseries-2.8 Harsh Prateek Bora
2024-10-02  6:51   ` Cédric Le Goater
2024-10-01  9:29 ` Harsh Prateek Bora [this message]
2024-10-02  6:53   ` [PATCH v2 09/11] ppc/spapr: remove deprecated machine pseries-2.9 Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 10/11] ppc/spapr: remove deprecated machine pseries-2.10 Harsh Prateek Bora
2024-10-02  6:54   ` Cédric Le Goater
2024-10-01  9:29 ` [PATCH v2 11/11] ppc/spapr: remove deprecated machine pseries-2.11 Harsh Prateek Bora
2024-10-02  6:54   ` Cédric Le Goater
2024-10-02  6:56 ` [PATCH v2 00/11] ppc/spapr: remove deprecated machines specific code Cédric Le Goater
2024-10-03  5:16   ` Harsh Prateek Bora
2024-10-03  5:56     ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001092910.1030913-10-harshpb@linux.ibm.com \
    --to=harshpb@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).