From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 542C4CFA74C for ; Fri, 4 Oct 2024 10:00:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swf61-0002jb-2G; Fri, 04 Oct 2024 05:59:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swf5z-0002jR-Sq for qemu-devel@nongnu.org; Fri, 04 Oct 2024 05:59:35 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swf5x-0002HD-S0 for qemu-devel@nongnu.org; Fri, 04 Oct 2024 05:59:35 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XKkXl2rGwz67D3k; Fri, 4 Oct 2024 17:59:19 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 852281402C6; Fri, 4 Oct 2024 17:59:22 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 4 Oct 2024 11:59:21 +0200 Date: Fri, 4 Oct 2024 10:59:20 +0100 To: Yicong Yang CC: , , , , , , , , , , Subject: Re: [PATCH 0/5] Building PPTT with root node and identical implementation flag Message-ID: <20241004105920.00007797@Huawei.com> In-Reply-To: <20240926113323.55991-1-yangyicong@huawei.com> References: <20240926113323.55991-1-yangyicong@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To frapeml500008.china.huawei.com (7.182.85.71) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 26 Sep 2024 19:33:18 +0800 Yicong Yang wrote: > From: Yicong Yang > > OS like Linux is using PPTT processor node's identical implementation > flag [1] to infer whether the whole system or a certain CPU cluster is > homogeneous or not [2]. QEMU currently only support building homogeneous > system, set the flag to indicate the fact. Build a root node in PPTT > for indicates the identical implementation which is needed for a > multi-socket system. Update the related PPTT tables as well. > > Since we'll update the test PPTT table data, upgrade the revision of PPTT > we build to revision 3 by handy. > > [1] ACPI 6.5 Table 5.158: Processor Structure Flags > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/pptt.c?h=v6.11-rc1#n810 > > Yicong Yang (5): > tests: virt: Allow changes to PPTT test table > hw/acpi/aml-build: Set identical implementation flag for PPTT > processor nodes > hw/acpi/aml-build: Build a root node in the PPTT table > hw/acpi/aml-build: Update the revision of PPTT table > tests: virt: Update expected ACPI tables for virt test > > hw/acpi/aml-build.c | 26 ++++++++++++++---- > tests/data/acpi/aarch64/virt/PPTT | Bin 76 -> 96 bytes > .../data/acpi/aarch64/virt/PPTT.acpihmatvirt | Bin 156 -> 176 bytes > tests/data/acpi/aarch64/virt/PPTT.topology | Bin 336 -> 356 bytes > 4 files changed, 21 insertions(+), 5 deletions(-) > Maybe some ASCII art makes sense? Mine you it's pretty simple conceptually so perhaps not worth bothering. Patches look good to me. Reviewed-by: Jonathan Cameron Ali, probably sensible to rebase your series on top of this if you haven't already. Jonathan