* [PATCH] tests/functional: Fix hash validation
@ 2024-10-04 13:02 Thomas Huth
2024-10-04 17:53 ` Manos Pitsidianakis
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2024-10-04 13:02 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Philippe Mathieu-Daudé, Brian Cain
The _check() function is supposed to check whether the hash of the
downloaded file matches the expected one. Unfortunately, during the
last rework of this function, the check was accidentally turned into
returning the hash value itself instead of a True/False value,
effectively accepting each hash as valid. Let's do a proper check
again now.
Fixes:05e303210d ("tests/functional/qemu_test: Use Python hashlib ...")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/functional/qemu_test/asset.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
index 3ec429217e..e47bfac035 100644
--- a/tests/functional/qemu_test/asset.py
+++ b/tests/functional/qemu_test/asset.py
@@ -57,7 +57,7 @@ def _check(self, cache_file):
break
hl.update(chunk)
- return hl.hexdigest()
+ return self.hash == hl.hexdigest()
def valid(self):
return self.cache_file.exists() and self._check(self.cache_file)
--
2.46.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tests/functional: Fix hash validation
2024-10-04 13:02 [PATCH] tests/functional: Fix hash validation Thomas Huth
@ 2024-10-04 17:53 ` Manos Pitsidianakis
0 siblings, 0 replies; 2+ messages in thread
From: Manos Pitsidianakis @ 2024-10-04 17:53 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: qemu-trivial, Philippe Mathieu-Daudé , Brian Cain
On Fri, 04 Oct 2024 16:02, Thomas Huth <thuth@redhat.com> wrote:
>The _check() function is supposed to check whether the hash of the
>downloaded file matches the expected one. Unfortunately, during the
>last rework of this function, the check was accidentally turned into
>returning the hash value itself instead of a True/False value,
>effectively accepting each hash as valid. Let's do a proper check
>again now.
>
>Fixes:05e303210d ("tests/functional/qemu_test: Use Python hashlib ...")
>Signed-off-by: Thomas Huth <thuth@redhat.com>
>---
> tests/functional/qemu_test/asset.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
>index 3ec429217e..e47bfac035 100644
>--- a/tests/functional/qemu_test/asset.py
>+++ b/tests/functional/qemu_test/asset.py
>@@ -57,7 +57,7 @@ def _check(self, cache_file):
> break
> hl.update(chunk)
>
>- return hl.hexdigest()
>+ return self.hash == hl.hexdigest()
>
> def valid(self):
> return self.cache_file.exists() and self._check(self.cache_file)
>--
>2.46.1
>
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-04 17:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04 13:02 [PATCH] tests/functional: Fix hash validation Thomas Huth
2024-10-04 17:53 ` Manos Pitsidianakis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).