From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Aurelien Jarno" <aurelien@aurel32.net>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-ppc@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Aleksandar Rikalo" <arikalo@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
qemu-arm@nongnu.org, "Zhao Liu" <zhao1.liu@intel.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: [PATCH 2/8] hw/core/cpu: Introduce CPUClass::is_big_endian() handler
Date: Fri, 4 Oct 2024 13:21:12 -0300 [thread overview]
Message-ID: <20241004162118.84570-3-philmd@linaro.org> (raw)
In-Reply-To: <20241004162118.84570-1-philmd@linaro.org>
Introduce the CPUClass::is_big_endian() handler and its
common default.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/core/cpu.h | 3 ++-
hw/core/cpu-common.c | 7 +++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index 04e9ad49968..22ef7a44e86 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -150,6 +150,7 @@ struct CPUClass {
ObjectClass *(*class_by_name)(const char *cpu_model);
void (*parse_features)(const char *typename, char *str, Error **errp);
+ bool (*is_big_endian)(CPUState *cpu);
bool (*has_work)(CPUState *cpu);
int (*mmu_index)(CPUState *cpu, bool ifetch);
int (*memory_rw_debug)(CPUState *cpu, vaddr addr,
@@ -749,7 +750,7 @@ int cpu_asidx_from_attrs(CPUState *cpu, MemTxAttrs attrs);
*/
bool cpu_virtio_is_big_endian(CPUState *cpu);
-#endif /* CONFIG_USER_ONLY */
+#endif /* !CONFIG_USER_ONLY */
/**
* cpu_list_add:
diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c
index 7982ecd39a5..aa5ea9761e4 100644
--- a/hw/core/cpu-common.c
+++ b/hw/core/cpu-common.c
@@ -26,6 +26,7 @@
#include "qemu/main-loop.h"
#include "exec/log.h"
#include "exec/gdbstub.h"
+#include "exec/tswap.h"
#include "sysemu/tcg.h"
#include "hw/boards.h"
#include "hw/qdev-properties.h"
@@ -138,6 +139,11 @@ static void cpu_common_reset_hold(Object *obj, ResetType type)
cpu_exec_reset_hold(cpu);
}
+static bool cpu_common_is_big_endian(CPUState *cs)
+{
+ return target_words_bigendian();
+}
+
static bool cpu_common_has_work(CPUState *cs)
{
return false;
@@ -306,6 +312,7 @@ static void cpu_common_class_init(ObjectClass *klass, void *data)
k->parse_features = cpu_common_parse_features;
k->get_arch_id = cpu_common_get_arch_id;
+ k->is_big_endian = cpu_common_is_big_endian;
k->has_work = cpu_common_has_work;
k->gdb_read_register = cpu_common_gdb_read_register;
k->gdb_write_register = cpu_common_gdb_write_register;
--
2.45.2
next prev parent reply other threads:[~2024-10-04 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 16:21 [PATCH 0/8] hw/core/cpu: Expose cpu_is_big_endian() method Philippe Mathieu-Daudé
2024-10-04 16:21 ` [PATCH 1/8] exec/tswap: Massage target_needs_bswap() definition Philippe Mathieu-Daudé
2024-10-04 16:21 ` Philippe Mathieu-Daudé [this message]
2024-10-04 16:41 ` [PATCH 2/8] hw/core/cpu: Introduce CPUClass::is_big_endian() handler Peter Maydell
2024-10-04 16:53 ` Philippe Mathieu-Daudé
2024-10-04 17:01 ` Peter Maydell
2024-10-04 16:21 ` [PATCH 3/8] target/arm: Implement CPUClass::is_big_endian Philippe Mathieu-Daudé
2024-10-04 16:21 ` [PATCH 4/8] target/microblaze: " Philippe Mathieu-Daudé
2024-10-04 16:21 ` [PATCH 5/8] target/mips: Declare mips_env_is_bigendian() in 'internal.h' Philippe Mathieu-Daudé
2024-10-04 16:21 ` [PATCH 6/8] target/mips: Implement CPUClass::is_big_endian Philippe Mathieu-Daudé
2024-10-04 16:21 ` [PATCH 7/8] target/ppc: Register CPUClass::is_big_endian Philippe Mathieu-Daudé
2024-10-04 16:21 ` [PATCH 8/8] hw/core/cpu: Expose cpu_is_big_endian() method Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004162118.84570-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=arikalo@gmail.com \
--cc=aurelien@aurel32.net \
--cc=danielhb413@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=jiaxun.yang@flygoat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=npiggin@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).