From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
qemu-ppc@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 17/25] hw/m68k: Use explicit big-endian LD/ST API
Date: Fri, 4 Oct 2024 13:30:33 -0300 [thread overview]
Message-ID: <20241004163042.85922-18-philmd@linaro.org> (raw)
In-Reply-To: <20241004163042.85922-1-philmd@linaro.org>
The M68K architecture uses big endianness. Directly use
the big-endian LD/ST API.
Mechanical change using:
$ end=be; \
for acc in uw w l q tul; do \
sed -i -e "s/ld${acc}_p(/ld${acc}_${end}_p(/" \
-e "s/st${acc}_p(/st${acc}_${end}_p(/" \
$(git grep -wlE '(ld|st)t?u?[wlq]_p' hw/m68k/); \
done
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/m68k/bootinfo.h | 28 ++++++++++++++--------------
hw/m68k/mcf5208.c | 2 +-
hw/m68k/next-cube.c | 2 +-
hw/m68k/q800.c | 4 ++--
4 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/hw/m68k/bootinfo.h b/hw/m68k/bootinfo.h
index 70c1dc0e8c3..0b3e7c4ea01 100644
--- a/hw/m68k/bootinfo.h
+++ b/hw/m68k/bootinfo.h
@@ -14,39 +14,39 @@
#define BOOTINFO0(base, id) \
do { \
- stw_p(base, id); \
+ stw_be_p(base, id); \
base += 2; \
- stw_p(base, sizeof(struct bi_record)); \
+ stw_be_p(base, sizeof(struct bi_record)); \
base += 2; \
} while (0)
#define BOOTINFO1(base, id, value) \
do { \
- stw_p(base, id); \
+ stw_be_p(base, id); \
base += 2; \
- stw_p(base, sizeof(struct bi_record) + 4); \
+ stw_be_p(base, sizeof(struct bi_record) + 4); \
base += 2; \
- stl_p(base, value); \
+ stl_be_p(base, value); \
base += 4; \
} while (0)
#define BOOTINFO2(base, id, value1, value2) \
do { \
- stw_p(base, id); \
+ stw_be_p(base, id); \
base += 2; \
- stw_p(base, sizeof(struct bi_record) + 8); \
+ stw_be_p(base, sizeof(struct bi_record) + 8); \
base += 2; \
- stl_p(base, value1); \
+ stl_be_p(base, value1); \
base += 4; \
- stl_p(base, value2); \
+ stl_be_p(base, value2); \
base += 4; \
} while (0)
#define BOOTINFOSTR(base, id, string) \
do { \
- stw_p(base, id); \
+ stw_be_p(base, id); \
base += 2; \
- stw_p(base, \
+ stw_be_p(base, \
(sizeof(struct bi_record) + strlen(string) + \
1 /* null termination */ + 3 /* padding */) & ~3); \
base += 2; \
@@ -59,13 +59,13 @@
#define BOOTINFODATA(base, id, data, len) \
do { \
- stw_p(base, id); \
+ stw_be_p(base, id); \
base += 2; \
- stw_p(base, \
+ stw_be_p(base, \
(sizeof(struct bi_record) + len + \
2 /* length field */ + 3 /* padding */) & ~3); \
base += 2; \
- stw_p(base, len); \
+ stw_be_p(base, len); \
base += 2; \
for (unsigned i_ = 0; i_ < len; ++i_) { \
stb_p(base++, data[i_]); \
diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
index b6677ad6bc3..e37cd50d189 100644
--- a/hw/m68k/mcf5208.c
+++ b/hw/m68k/mcf5208.c
@@ -359,7 +359,7 @@ static void mcf5208evb_init(MachineState *machine)
/* Initial PC is always at offset 4 in firmware binaries */
ptr = rom_ptr(0x4, 4);
assert(ptr != NULL);
- env->pc = ldl_p(ptr);
+ env->pc = ldl_be_p(ptr);
}
/* Load kernel. */
diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index 9b78767ea8e..9832213e7ec 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -1036,7 +1036,7 @@ static void next_cube_init(MachineState *machine)
/* Initial PC is always at offset 4 in firmware binaries */
ptr = rom_ptr(0x01000004, 4);
g_assert(ptr != NULL);
- env->pc = ldl_p(ptr);
+ env->pc = ldl_be_p(ptr);
if (env->pc >= 0x01020000) {
error_report("'%s' does not seem to be a valid firmware image.",
bios_name);
diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
index fa7683bf76f..556604e1dcf 100644
--- a/hw/m68k/q800.c
+++ b/hw/m68k/q800.c
@@ -684,9 +684,9 @@ static void q800_machine_init(MachineState *machine)
ptr = rom_ptr(MACROM_ADDR, bios_size);
assert(ptr != NULL);
- stl_phys(cs->as, 0, ldl_p(ptr)); /* reset initial SP */
+ stl_phys(cs->as, 0, ldl_be_p(ptr)); /* reset initial SP */
stl_phys(cs->as, 4,
- MACROM_ADDR + ldl_p(ptr + 4)); /* reset initial PC */
+ MACROM_ADDR + ldl_be_p(ptr + 4)); /* reset initial PC */
}
}
}
--
2.45.2
next prev parent reply other threads:[~2024-10-04 16:42 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 16:30 [PATCH v2 00/25] misc: Use explicit endian LD/ST API Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 01/25] gdbstub/helpers: Have ldtul_p() definition use ldn_p() Philippe Mathieu-Daudé
2024-10-05 1:10 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 02/25] target/hexagon: Replace ldtul_p() -> ldl_p() Philippe Mathieu-Daudé
2024-10-05 1:08 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 03/25] target/alpha: Replace ldtul_p() -> ldq_p() Philippe Mathieu-Daudé
2024-10-05 1:10 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 04/25] target/s390x: " Philippe Mathieu-Daudé
2024-10-05 1:11 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 05/25] gdbstub/helpers: Introduce ldtul_$endian_p() helpers Philippe Mathieu-Daudé
2024-10-05 1:13 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 06/25] target/alpha: Use explicit little-endian LD/ST API Philippe Mathieu-Daudé
2024-10-05 1:13 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 07/25] target/hexagon: " Philippe Mathieu-Daudé
2024-10-05 1:16 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 08/25] hw/i386: " Philippe Mathieu-Daudé
2024-10-05 1:17 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 09/25] target/i386: " Philippe Mathieu-Daudé
2024-10-05 1:18 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 10/25] target/avr: " Philippe Mathieu-Daudé
2024-10-05 1:18 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 11/25] linux-user/i386: " Philippe Mathieu-Daudé
2024-10-05 1:19 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 12/25] target/loongarch: " Philippe Mathieu-Daudé
2024-10-05 1:22 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 13/25] target/sh4: " Philippe Mathieu-Daudé
2024-10-07 19:59 ` Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 14/25] target/tricore: " Philippe Mathieu-Daudé
2024-10-05 1:24 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 15/25] target/rx: " Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 16/25] target/riscv: " Philippe Mathieu-Daudé
2024-10-04 16:30 ` Philippe Mathieu-Daudé [this message]
2024-10-04 16:40 ` [PATCH v2 17/25] hw/m68k: Use explicit big-endian " Philippe Mathieu-Daudé
2024-10-05 1:29 ` Richard Henderson
2024-10-04 16:30 ` [PATCH v2 18/25] target/m68k: " Philippe Mathieu-Daudé
2024-10-04 16:41 ` Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 19/25] hw/sparc: " Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 20/25] target/sparc: " Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 21/25] target/hppa: " Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 22/25] hw/s390x: " Philippe Mathieu-Daudé
2024-10-07 5:54 ` Thomas Huth
2024-10-04 16:30 ` [PATCH v2 23/25] target/s390x: " Philippe Mathieu-Daudé
2024-10-07 5:57 ` Thomas Huth
2024-10-04 16:30 ` [PATCH v2 24/25] target/openrisc: " Philippe Mathieu-Daudé
2024-10-04 16:30 ` [PATCH v2 25/25] hw/ppc/e500: " Philippe Mathieu-Daudé
2024-10-04 16:39 ` [PATCH v2 00/25] misc: Use explicit endian " Philippe Mathieu-Daudé
2024-10-05 1:39 ` Richard Henderson
2024-10-07 7:52 ` Pierre Muller
2024-10-07 14:40 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004163042.85922-18-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).