From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Lei Wang <lei4.wang@intel.com>, Xin Li <xin3.li@intel.com>,
"Xin Li (Intel)" <xin@zytor.com>
Subject: [PULL 03/23] target/i386: Raise the highest index value used for any VMCS encoding
Date: Fri, 4 Oct 2024 18:33:55 +0200 [thread overview]
Message-ID: <20241004163415.951106-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20241004163415.951106-1-pbonzini@redhat.com>
From: Lei Wang <lei4.wang@intel.com>
Because the index value of the VMCS field encoding of FRED injected-event
data (one of the newly added VMCS fields for FRED transitions), 0x52, is
larger than any existing index value, raise the highest index value used
for any VMCS encoding to 0x52.
Because the index value of the VMCS field encoding of Secondary VM-exit
controls, 0x44, is larger than any existing index value, raise the highest
index value used for any VMCS encoding to 0x44.
Co-developed-by: Xin Li <xin3.li@intel.com>
Signed-off-by: Xin Li <xin3.li@intel.com>
Signed-off-by: Lei Wang <lei4.wang@intel.com>
Signed-off-by: Xin Li (Intel) <xin@zytor.com>
Link: https://lore.kernel.org/r/20240807081813.735158-4-xin@zytor.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.h | 1 +
target/i386/kvm/kvm.c | 9 ++++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 2bf37dd15e0..9c39384ac0a 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1186,6 +1186,7 @@ uint64_t x86_cpu_get_supported_feature_word(X86CPU *cpu, FeatureWord w);
#define VMX_VM_EXIT_PT_CONCEAL_PIP 0x01000000
#define VMX_VM_EXIT_CLEAR_IA32_RTIT_CTL 0x02000000
#define VMX_VM_EXIT_LOAD_IA32_PKRS 0x20000000
+#define VMX_VM_EXIT_ACTIVATE_SECONDARY_CONTROLS 0x80000000
#define VMX_VM_ENTRY_LOAD_DEBUG_CONTROLS 0x00000004
#define VMX_VM_ENTRY_IA32E_MODE 0x00000200
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index c8056ef83d7..27a3d7626cf 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -3694,7 +3694,14 @@ static void kvm_msr_entry_add_vmx(X86CPU *cpu, FeatureWordArray f)
kvm_msr_entry_add(cpu, MSR_IA32_VMX_CR4_FIXED0,
CR4_VMXE_MASK);
- if (f[FEAT_VMX_SECONDARY_CTLS] & VMX_SECONDARY_EXEC_TSC_SCALING) {
+ if (f[FEAT_7_1_EAX] & CPUID_7_1_EAX_FRED) {
+ /* FRED injected-event data (0x2052). */
+ kvm_msr_entry_add(cpu, MSR_IA32_VMX_VMCS_ENUM, 0x52);
+ } else if (f[FEAT_VMX_EXIT_CTLS] &
+ VMX_VM_EXIT_ACTIVATE_SECONDARY_CONTROLS) {
+ /* Secondary VM-exit controls (0x2044). */
+ kvm_msr_entry_add(cpu, MSR_IA32_VMX_VMCS_ENUM, 0x44);
+ } else if (f[FEAT_VMX_SECONDARY_CTLS] & VMX_SECONDARY_EXEC_TSC_SCALING) {
/* TSC multiplier (0x2032). */
kvm_msr_entry_add(cpu, MSR_IA32_VMX_VMCS_ENUM, 0x32);
} else {
--
2.46.1
next prev parent reply other threads:[~2024-10-04 16:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 16:33 [PULL 00/23] Misc patches for 2024-10-04 Paolo Bonzini
2024-10-04 16:33 ` [PULL 01/23] target/i386: Delete duplicated macro definition CR4_FRED_MASK Paolo Bonzini
2024-10-04 16:33 ` [PULL 02/23] target/i386: Add VMX control bits for nested FRED support Paolo Bonzini
2024-10-04 16:33 ` Paolo Bonzini [this message]
2024-10-04 16:33 ` [PULL 04/23] tests/unit: remove block layer code from test-nested-aio-poll Paolo Bonzini
2024-10-04 16:33 ` [PULL 05/23] hw/i386/pc: Add a description for the i8042 property Paolo Bonzini
2024-10-04 16:33 ` [PULL 06/23] kvm/i386: make kvm_filter_msr() and related definitions private to kvm module Paolo Bonzini
2024-10-04 16:33 ` [PULL 07/23] kvm/i386: fix return values of is_host_cpu_intel() Paolo Bonzini
2024-10-04 16:34 ` [PULL 08/23] kvm: replace fprintf with error_report()/printf() in kvm_init() Paolo Bonzini
2024-10-04 16:34 ` [PULL 09/23] kvm/i386: refactor kvm_arch_init and split it into smaller functions Paolo Bonzini
2024-10-04 16:34 ` [PULL 10/23] kvm/i386: replace identity_base variable with a constant Paolo Bonzini
2024-10-04 16:34 ` [PULL 11/23] kvm: refactor core virtual machine creation into its own function Paolo Bonzini
2024-10-04 16:34 ` [PULL 12/23] target/i386: Expose IBPB-BRTYPE and SBPB CPUID bits to the guest Paolo Bonzini
2024-10-04 16:34 ` [PULL 13/23] hw: Remove unused inclusion of hw/char/serial.h Paolo Bonzini
2024-10-04 16:34 ` [PULL 14/23] hw/char/serial.h: Extract serial-isa.h Paolo Bonzini
2024-10-04 16:34 ` [PULL 15/23] hw/char: Extract serial-mm Paolo Bonzini
2024-10-04 16:34 ` [PULL 16/23] 9p: remove 'proxy' filesystem backend driver Paolo Bonzini
2024-10-04 16:34 ` [PULL 17/23] minikconf: print error entirely on stderr Paolo Bonzini
2024-10-04 16:34 ` [PULL 18/23] accel/kvm: refactor dirty ring setup Paolo Bonzini
2024-10-04 16:34 ` [PULL 19/23] kvm: Allow kvm_arch_get/put_registers to accept Error** Paolo Bonzini
2024-10-04 16:34 ` [PULL 20/23] target/i386/kvm: Report which action failed in kvm_arch_put/get_registers Paolo Bonzini
2024-10-04 16:34 ` [PULL 21/23] qom: rename object_resolve_path_type() "ambiguousp" Paolo Bonzini
2024-10-04 16:34 ` [PULL 22/23] qom: set *ambiguous on all paths Paolo Bonzini
2024-10-04 16:34 ` [PULL 23/23] qom: update object_resolve_path*() documentation Paolo Bonzini
2024-10-06 14:10 ` [PULL 00/23] Misc patches for 2024-10-04 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004163415.951106-4-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=lei4.wang@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=xin3.li@intel.com \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).