qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ani Sinha <anisinha@redhat.com>, philmd@linaro.org
Subject: [PULL 06/23] kvm/i386: make kvm_filter_msr() and related definitions private to kvm module
Date: Fri,  4 Oct 2024 18:33:58 +0200	[thread overview]
Message-ID: <20241004163415.951106-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20241004163415.951106-1-pbonzini@redhat.com>

From: Ani Sinha <anisinha@redhat.com>

kvm_filer_msr() is only used from i386 kvm module. Make it static so that its
easy for developers to understand that its not used anywhere else.
Same for QEMURDMSRHandler, QEMUWRMSRHandler and KVMMSRHandlers definitions.

CC: philmd@linaro.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Link: https://lore.kernel.org/r/20240903140045.41167-1-anisinha@redhat.com
[Make struct unnamed. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/i386/kvm/kvm_i386.h | 11 -----------
 target/i386/kvm/kvm.c      | 12 +++++++++++-
 2 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h
index 34fc60774b8..9de9c0d3038 100644
--- a/target/i386/kvm/kvm_i386.h
+++ b/target/i386/kvm/kvm_i386.h
@@ -66,17 +66,6 @@ uint64_t kvm_swizzle_msi_ext_dest_id(uint64_t address);
 void kvm_update_msi_routes_all(void *private, bool global,
                                uint32_t index, uint32_t mask);
 
-typedef bool QEMURDMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t *val);
-typedef bool QEMUWRMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t val);
-typedef struct kvm_msr_handlers {
-    uint32_t msr;
-    QEMURDMSRHandler *rdmsr;
-    QEMUWRMSRHandler *wrmsr;
-} KVMMSRHandlers;
-
-bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
-                    QEMUWRMSRHandler *wrmsr);
-
 #endif /* CONFIG_KVM */
 
 void kvm_pc_setup_irq_routing(bool pci_enabled);
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 27a3d7626cf..94fdf3cb304 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -92,7 +92,17 @@
  * 255 kvm_msr_entry structs */
 #define MSR_BUF_SIZE 4096
 
+typedef bool QEMURDMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t *val);
+typedef bool QEMUWRMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t val);
+typedef struct {
+    uint32_t msr;
+    QEMURDMSRHandler *rdmsr;
+    QEMUWRMSRHandler *wrmsr;
+} KVMMSRHandlers;
+
 static void kvm_init_msrs(X86CPU *cpu);
+static bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
+                           QEMUWRMSRHandler *wrmsr);
 
 const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
     KVM_CAP_INFO(SET_TSS_ADDR),
@@ -5736,7 +5746,7 @@ static bool kvm_install_msr_filters(KVMState *s)
     return true;
 }
 
-bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
+static bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
                     QEMUWRMSRHandler *wrmsr)
 {
     int i;
-- 
2.46.1



  parent reply	other threads:[~2024-10-04 16:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 16:33 [PULL 00/23] Misc patches for 2024-10-04 Paolo Bonzini
2024-10-04 16:33 ` [PULL 01/23] target/i386: Delete duplicated macro definition CR4_FRED_MASK Paolo Bonzini
2024-10-04 16:33 ` [PULL 02/23] target/i386: Add VMX control bits for nested FRED support Paolo Bonzini
2024-10-04 16:33 ` [PULL 03/23] target/i386: Raise the highest index value used for any VMCS encoding Paolo Bonzini
2024-10-04 16:33 ` [PULL 04/23] tests/unit: remove block layer code from test-nested-aio-poll Paolo Bonzini
2024-10-04 16:33 ` [PULL 05/23] hw/i386/pc: Add a description for the i8042 property Paolo Bonzini
2024-10-04 16:33 ` Paolo Bonzini [this message]
2024-10-04 16:33 ` [PULL 07/23] kvm/i386: fix return values of is_host_cpu_intel() Paolo Bonzini
2024-10-04 16:34 ` [PULL 08/23] kvm: replace fprintf with error_report()/printf() in kvm_init() Paolo Bonzini
2024-10-04 16:34 ` [PULL 09/23] kvm/i386: refactor kvm_arch_init and split it into smaller functions Paolo Bonzini
2024-10-04 16:34 ` [PULL 10/23] kvm/i386: replace identity_base variable with a constant Paolo Bonzini
2024-10-04 16:34 ` [PULL 11/23] kvm: refactor core virtual machine creation into its own function Paolo Bonzini
2024-10-04 16:34 ` [PULL 12/23] target/i386: Expose IBPB-BRTYPE and SBPB CPUID bits to the guest Paolo Bonzini
2024-10-04 16:34 ` [PULL 13/23] hw: Remove unused inclusion of hw/char/serial.h Paolo Bonzini
2024-10-04 16:34 ` [PULL 14/23] hw/char/serial.h: Extract serial-isa.h Paolo Bonzini
2024-10-04 16:34 ` [PULL 15/23] hw/char: Extract serial-mm Paolo Bonzini
2024-10-04 16:34 ` [PULL 16/23] 9p: remove 'proxy' filesystem backend driver Paolo Bonzini
2024-10-04 16:34 ` [PULL 17/23] minikconf: print error entirely on stderr Paolo Bonzini
2024-10-04 16:34 ` [PULL 18/23] accel/kvm: refactor dirty ring setup Paolo Bonzini
2024-10-04 16:34 ` [PULL 19/23] kvm: Allow kvm_arch_get/put_registers to accept Error** Paolo Bonzini
2024-10-04 16:34 ` [PULL 20/23] target/i386/kvm: Report which action failed in kvm_arch_put/get_registers Paolo Bonzini
2024-10-04 16:34 ` [PULL 21/23] qom: rename object_resolve_path_type() "ambiguousp" Paolo Bonzini
2024-10-04 16:34 ` [PULL 22/23] qom: set *ambiguous on all paths Paolo Bonzini
2024-10-04 16:34 ` [PULL 23/23] qom: update object_resolve_path*() documentation Paolo Bonzini
2024-10-06 14:10 ` [PULL 00/23] Misc patches for 2024-10-04 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004163415.951106-7-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).