From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Corey Minyard" <cminyard@mvista.com>,
"Bernhard Beschow" <shentey@gmail.com>,
qemu-ppc@nongnu.org,
"Alex Williamson" <alex.williamson@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
qemu-block@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v2 10/23] hw/i2c/mpc_i2c: Convert DPRINTF to trace events for register access
Date: Sat, 5 Oct 2024 21:45:50 +0200 [thread overview]
Message-ID: <20241005194603.23139-11-shentey@gmail.com> (raw)
In-Reply-To: <20241005194603.23139-1-shentey@gmail.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/i2c/mpc_i2c.c | 9 +++++----
hw/i2c/trace-events | 5 +++++
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c
index 2467d1a9aa..3d79c15653 100644
--- a/hw/i2c/mpc_i2c.c
+++ b/hw/i2c/mpc_i2c.c
@@ -24,6 +24,7 @@
#include "hw/sysbus.h"
#include "migration/vmstate.h"
#include "qom/object.h"
+#include "trace.h"
/* #define DEBUG_I2C */
@@ -224,8 +225,8 @@ static uint64_t mpc_i2c_read(void *opaque, hwaddr addr, unsigned size)
break;
}
- DPRINTF("%s: addr " HWADDR_FMT_plx " %02" PRIx32 "\n", __func__,
- addr, value);
+ trace_mpc_i2c_read(addr, value);
+
return (uint64_t)value;
}
@@ -234,8 +235,8 @@ static void mpc_i2c_write(void *opaque, hwaddr addr,
{
MPCI2CState *s = opaque;
- DPRINTF("%s: addr " HWADDR_FMT_plx " val %08" PRIx64 "\n", __func__,
- addr, value);
+ trace_mpc_i2c_write(addr, value);
+
switch (addr) {
case MPC_I2C_ADR:
s->adr = value & CADR_MASK;
diff --git a/hw/i2c/trace-events b/hw/i2c/trace-events
index 6900e06eda..f708a7ace1 100644
--- a/hw/i2c/trace-events
+++ b/hw/i2c/trace-events
@@ -35,6 +35,11 @@ aspeed_i2c_bus_write(uint32_t busid, uint64_t offset, unsigned size, uint64_t va
aspeed_i2c_bus_send(const char *mode, int i, int count, uint8_t byte) "%s send %d/%d 0x%02x"
aspeed_i2c_bus_recv(const char *mode, int i, int count, uint8_t byte) "%s recv %d/%d 0x%02x"
+# mpc_i2c.c
+
+mpc_i2c_read(uint64_t addr, uint32_t value) "[0x%" PRIx64 "] -> 0x%02" PRIx32
+mpc_i2c_write(uint64_t addr, uint32_t value) "[0x%" PRIx64 "] <- 0x%02" PRIx32
+
# npcm7xx_smbus.c
npcm7xx_smbus_read(const char *id, uint64_t offset, uint64_t value, unsigned size) "%s offset: 0x%04" PRIx64 " value: 0x%02" PRIx64 " size: %u"
--
2.46.2
next prev parent reply other threads:[~2024-10-05 19:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 19:45 [PATCH v2 00/23] E500 Cleanup Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 01/23] hw/ppc/e500: Do not leak struct boot_info Bernhard Beschow
2024-10-06 16:56 ` BALATON Zoltan
2024-10-07 8:36 ` Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 02/23] hw/ppc/e500: Remove firstenv variable Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 03/23] hw/ppc/e500: Prefer QOM cast Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 04/23] hw/ppc/e500: Remove unused "irqs" parameter Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 05/23] hw/ppc/e500: Add missing device tree properties to i2c controller node Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 06/23] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 07/23] hw/ppc/e500: Extract ppce500_ccsr.c Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 08/23] hw/ppc/ppce500_ccsr: Log access to unimplemented registers Bernhard Beschow
2024-10-06 17:12 ` BALATON Zoltan
2024-10-12 13:48 ` Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 09/23] hw/ppc/mpc8544_guts: Populate POR PLL ratio status register Bernhard Beschow
2024-10-06 17:23 ` BALATON Zoltan
2024-10-05 19:45 ` Bernhard Beschow [this message]
2024-10-05 19:45 ` [PATCH v2 11/23] hw/i2c/mpc_i2c: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 12/23] hw/pci-host/ppce500: Reuse TYPE_PPC_E500_PCI_BRIDGE define Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 13/23] hw/pci-host/ppce500: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 14/23] hw/gpio/mpc8xxx: " Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 15/23] hw/ppc/mpc8544_guts: " Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 16/23] hw/net/fsl_etsec/etsec: " Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 17/23] hw/intc: Guard openpic_kvm.c by dedicated OPENPIC_KVM Kconfig switch Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 18/23] hw/sd/sdhci: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 19/23] hw/block/pflash_cfi01: " Bernhard Beschow
2024-10-18 13:28 ` Kevin Wolf
2024-10-05 19:46 ` [PATCH v2 20/23] hw/i2c/smbus_eeprom: " Bernhard Beschow
2024-10-05 19:46 ` [PATCH v2 21/23] hw/rtc/ds1338: " Bernhard Beschow
2024-10-05 19:46 ` [PATCH v2 22/23] hw/usb/hcd-ehci-sysbus: " Bernhard Beschow
2024-10-05 19:46 ` [PATCH v2 23/23] hw/vfio/platform: Let vfio_start_eventfd_injection() take VFIOPlatformDevice pointer Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241005194603.23139-11-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=clg@redhat.com \
--cc=cminyard@mvista.com \
--cc=danielhb413@gmail.com \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).