qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Corey Minyard" <cminyard@mvista.com>,
	"Bernhard Beschow" <shentey@gmail.com>,
	qemu-ppc@nongnu.org,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	qemu-block@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v2 08/23] hw/ppc/ppce500_ccsr: Log access to unimplemented registers
Date: Sat,  5 Oct 2024 21:45:48 +0200	[thread overview]
Message-ID: <20241005194603.23139-9-shentey@gmail.com> (raw)
In-Reply-To: <20241005194603.23139-1-shentey@gmail.com>

The CCSR space is just a container which is meant to be covered by platform
device memory regions. However, QEMU only implements a subset of these devices.
Add some logging to see which devices a guest attempts to access.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/ppc/ppce500_ccsr.c | 32 +++++++++++++++++++++++++++++++-
 hw/ppc/trace-events   |  3 +++
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/ppce500_ccsr.c b/hw/ppc/ppce500_ccsr.c
index 5d0e1e0e89..6659560674 100644
--- a/hw/ppc/ppce500_ccsr.c
+++ b/hw/ppc/ppce500_ccsr.c
@@ -13,12 +13,42 @@
 
 #include "qemu/osdep.h"
 #include "ppce500_ccsr.h"
+#include "qemu/log.h"
+#include "trace.h"
+
+static uint64_t ppce500_ccsr_io_read(void *opaque, hwaddr addr, unsigned size)
+{
+    uint64_t value = 0;
+
+    trace_ppce500_ccsr_io_read(addr, value, size);
+    qemu_log_mask(LOG_UNIMP,
+                  "%s: unimplemented [0x%" HWADDR_PRIx "] -> 0\n",
+                  __func__, addr);
+
+    return value;
+}
+
+static void ppce500_ccsr_io_write(void *opaque, hwaddr addr, uint64_t value,
+                                  unsigned size)
+{
+    trace_ppce500_ccsr_io_write(addr, value, size);
+    qemu_log_mask(LOG_UNIMP,
+                  "%s: unimplemented [0x%" HWADDR_PRIx "] <- 0x%" PRIx32 "\n",
+                  __func__, addr, (uint32_t)value);
+}
+
+static const MemoryRegionOps ppce500_ccsr_ops = {
+    .read = ppce500_ccsr_io_read,
+    .write = ppce500_ccsr_io_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
+};
 
 static void ppce500_ccsr_init(Object *obj)
 {
     PPCE500CCSRState *s = CCSR(obj);
 
-    memory_region_init(&s->ccsr_space, obj, "e500-ccsr", MPC85XX_CCSRBAR_SIZE);
+    memory_region_init_io(&s->ccsr_space, obj, &ppce500_ccsr_ops, obj,
+                          "e500-ccsr", MPC85XX_CCSRBAR_SIZE);
     sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->ccsr_space);
 }
 
diff --git a/hw/ppc/trace-events b/hw/ppc/trace-events
index 1f125ce841..ca4c231c9f 100644
--- a/hw/ppc/trace-events
+++ b/hw/ppc/trace-events
@@ -143,6 +143,9 @@ ppc_irq_cpu(const char *action) "%s"
 ppc_dcr_read(uint32_t addr, uint32_t val) "DRCN[0x%x] -> 0x%x"
 ppc_dcr_write(uint32_t addr, uint32_t val) "DRCN[0x%x] <- 0x%x"
 
+ppce500_ccsr_io_read(uint32_t index, uint32_t val, uint8_t size) "[0x%" PRIx32 "] -> 0x%08x (size: 0x%" PRIu8 ")"
+ppce500_ccsr_io_write(uint32_t index, uint32_t val, uint8_t size) "[0x%" PRIx32 "] <- 0x%08x (size: 0x%" PRIu8 ")"
+
 # prep_systemio.c
 prep_systemio_read(uint32_t addr, uint32_t val) "read addr=0x%x val=0x%x"
 prep_systemio_write(uint32_t addr, uint32_t val) "write addr=0x%x val=0x%x"
-- 
2.46.2



  parent reply	other threads:[~2024-10-05 19:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-05 19:45 [PATCH v2 00/23] E500 Cleanup Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 01/23] hw/ppc/e500: Do not leak struct boot_info Bernhard Beschow
2024-10-06 16:56   ` BALATON Zoltan
2024-10-07  8:36     ` Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 02/23] hw/ppc/e500: Remove firstenv variable Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 03/23] hw/ppc/e500: Prefer QOM cast Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 04/23] hw/ppc/e500: Remove unused "irqs" parameter Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 05/23] hw/ppc/e500: Add missing device tree properties to i2c controller node Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 06/23] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 07/23] hw/ppc/e500: Extract ppce500_ccsr.c Bernhard Beschow
2024-10-05 19:45 ` Bernhard Beschow [this message]
2024-10-06 17:12   ` [PATCH v2 08/23] hw/ppc/ppce500_ccsr: Log access to unimplemented registers BALATON Zoltan
2024-10-12 13:48     ` Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 09/23] hw/ppc/mpc8544_guts: Populate POR PLL ratio status register Bernhard Beschow
2024-10-06 17:23   ` BALATON Zoltan
2024-10-05 19:45 ` [PATCH v2 10/23] hw/i2c/mpc_i2c: Convert DPRINTF to trace events for register access Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 11/23] hw/i2c/mpc_i2c: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 12/23] hw/pci-host/ppce500: Reuse TYPE_PPC_E500_PCI_BRIDGE define Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 13/23] hw/pci-host/ppce500: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 14/23] hw/gpio/mpc8xxx: " Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 15/23] hw/ppc/mpc8544_guts: " Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 16/23] hw/net/fsl_etsec/etsec: " Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 17/23] hw/intc: Guard openpic_kvm.c by dedicated OPENPIC_KVM Kconfig switch Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 18/23] hw/sd/sdhci: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-10-05 19:45 ` [PATCH v2 19/23] hw/block/pflash_cfi01: " Bernhard Beschow
2024-10-18 13:28   ` Kevin Wolf
2024-10-05 19:46 ` [PATCH v2 20/23] hw/i2c/smbus_eeprom: " Bernhard Beschow
2024-10-05 19:46 ` [PATCH v2 21/23] hw/rtc/ds1338: " Bernhard Beschow
2024-10-05 19:46 ` [PATCH v2 22/23] hw/usb/hcd-ehci-sysbus: " Bernhard Beschow
2024-10-05 19:46 ` [PATCH v2 23/23] hw/vfio/platform: Let vfio_start_eventfd_injection() take VFIOPlatformDevice pointer Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241005194603.23139-9-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=clg@redhat.com \
    --cc=cminyard@mvista.com \
    --cc=danielhb413@gmail.com \
    --cc=hreitz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).