qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
	qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Bernhard Beschow <shentey@gmail.com>
Subject: [PATCH 0/4] Consolidate lan9118 phy implementations
Date: Sat,  5 Oct 2024 22:57:44 +0200	[thread overview]
Message-ID: <20241005205748.29203-1-shentey@gmail.com> (raw)

hw/net/imx_fec and hw/net/lan9118 implement the same Ethernet PHY with similar
but not quite the same code. This series consolidates the implementations into
one to fix code duplication. It then continues to make the code more readable by
reusing some existing constants.

Having a dedicated module for the PHY allows it to be reused in even further
device models.

Bernhard Beschow (4):
  hw/net/lan9118: Extract lan9118_phy
  hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations
  hw/net/lan9118_phy: Reuse MII constants
  hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement

 include/hw/net/imx_fec.h     |   7 +-
 include/hw/net/lan9118_phy.h |  31 +++++++
 include/hw/net/mii.h         |   6 ++
 hw/net/imx_fec.c             | 141 +++--------------------------
 hw/net/lan9118.c             | 133 +++++----------------------
 hw/net/lan9118_phy.c         | 168 +++++++++++++++++++++++++++++++++++
 hw/net/Kconfig               |   5 ++
 hw/net/meson.build           |   1 +
 hw/net/trace-events          |  10 ++-
 9 files changed, 254 insertions(+), 248 deletions(-)
 create mode 100644 include/hw/net/lan9118_phy.h
 create mode 100644 hw/net/lan9118_phy.c

-- 
2.46.2



             reply	other threads:[~2024-10-05 20:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-05 20:57 Bernhard Beschow [this message]
2024-10-05 20:57 ` [PATCH 1/4] hw/net/lan9118: Extract lan9118_phy Bernhard Beschow
2024-10-14 12:47   ` Peter Maydell
2024-10-14 18:38     ` Bernhard Beschow
2024-10-15  9:27       ` Peter Maydell
2024-10-15 16:49         ` Bernhard Beschow
2024-10-16 21:44         ` Bernhard Beschow
2024-10-05 20:57 ` [PATCH 2/4] hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations Bernhard Beschow
2024-10-05 20:57 ` [PATCH 3/4] hw/net/lan9118_phy: Reuse MII constants Bernhard Beschow
2024-10-14 12:56   ` Peter Maydell
2024-10-05 20:57 ` [PATCH 4/4] hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement Bernhard Beschow
2024-10-14 12:52   ` Peter Maydell
2024-10-12 14:07 ` [PATCH 0/4] Consolidate lan9118 phy implementations Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241005205748.29203-1-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).