From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Bernhard Beschow <shentey@gmail.com>
Subject: [PATCH 4/4] hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement
Date: Sat, 5 Oct 2024 22:57:48 +0200 [thread overview]
Message-ID: <20241005205748.29203-5-shentey@gmail.com> (raw)
In-Reply-To: <20241005205748.29203-1-shentey@gmail.com>
The real device advertises this mode and the device model already advertises
100 mbps half duplex and 10 mbps full+half duplex. So advertise this mode to
make the model more realistic.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/net/lan9118_phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/lan9118_phy.c b/hw/net/lan9118_phy.c
index 1c2f30c81a..4815a4da35 100644
--- a/hw/net/lan9118_phy.c
+++ b/hw/net/lan9118_phy.c
@@ -145,8 +145,8 @@ void lan9118_phy_write(Lan9118PhyState *s, int reg, uint32_t val)
break;
case MII_ANAR:
s->advertise = (val & (MII_ANAR_RFAULT | MII_ANAR_PAUSE_ASYM |
- MII_ANAR_PAUSE | MII_ANAR_10FD | MII_ANAR_10 |
- MII_ANAR_SELECT))
+ MII_ANAR_PAUSE | MII_ANAR_TXFD | MII_ANAR_10FD |
+ MII_ANAR_10 | MII_ANAR_SELECT))
| MII_ANAR_TX;
break;
case 30: /* Interrupt mask */
--
2.46.2
next prev parent reply other threads:[~2024-10-05 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 20:57 [PATCH 0/4] Consolidate lan9118 phy implementations Bernhard Beschow
2024-10-05 20:57 ` [PATCH 1/4] hw/net/lan9118: Extract lan9118_phy Bernhard Beschow
2024-10-14 12:47 ` Peter Maydell
2024-10-14 18:38 ` Bernhard Beschow
2024-10-15 9:27 ` Peter Maydell
2024-10-15 16:49 ` Bernhard Beschow
2024-10-16 21:44 ` Bernhard Beschow
2024-10-05 20:57 ` [PATCH 2/4] hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations Bernhard Beschow
2024-10-05 20:57 ` [PATCH 3/4] hw/net/lan9118_phy: Reuse MII constants Bernhard Beschow
2024-10-14 12:56 ` Peter Maydell
2024-10-05 20:57 ` Bernhard Beschow [this message]
2024-10-14 12:52 ` [PATCH 4/4] hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement Peter Maydell
2024-10-12 14:07 ` [PATCH 0/4] Consolidate lan9118 phy implementations Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241005205748.29203-5-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).