From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-devel@nongnu.org, berrange@redhat.com
Cc: kris.conklin@seagate.com, jonathan.henze@seagate.com,
evan.burgess@seagate.com, peter.maydell@linaro.org,
"Alejandro Zeise" <alejandro.zeise@seagate.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v5 13/16] crypto/hash-nettle: Remove old hash API functions
Date: Tue, 8 Oct 2024 09:57:20 +0200 [thread overview]
Message-ID: <20241008075724.2772149-14-clg@redhat.com> (raw)
In-Reply-To: <20241008075724.2772149-1-clg@redhat.com>
From: Alejandro Zeise <alejandro.zeise@seagate.com>
Removes old hash implementation in the nettle hash driver.
Signed-off-by: Alejandro Zeise <alejandro.zeise@seagate.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
[ clg: - Fixed spelling in commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
crypto/hash-nettle.c | 53 --------------------------------------------
1 file changed, 53 deletions(-)
diff --git a/crypto/hash-nettle.c b/crypto/hash-nettle.c
index 07e18ce26cba..570ce8a6456b 100644
--- a/crypto/hash-nettle.c
+++ b/crypto/hash-nettle.c
@@ -104,58 +104,6 @@ gboolean qcrypto_hash_supports(QCryptoHashAlgo alg)
return false;
}
-
-static int
-qcrypto_nettle_hash_bytesv(QCryptoHashAlgo alg,
- const struct iovec *iov,
- size_t niov,
- uint8_t **result,
- size_t *resultlen,
- Error **errp)
-{
- size_t i;
- union qcrypto_hash_ctx ctx;
-
- if (!qcrypto_hash_supports(alg)) {
- error_setg(errp,
- "Unknown hash algorithm %d",
- alg);
- return -1;
- }
-
- qcrypto_hash_alg_map[alg].init(&ctx);
-
- for (i = 0; i < niov; i++) {
- /* Some versions of nettle have functions
- * declared with 'int' instead of 'size_t'
- * so to be safe avoid writing more than
- * UINT_MAX bytes at a time
- */
- size_t len = iov[i].iov_len;
- uint8_t *base = iov[i].iov_base;
- while (len) {
- size_t shortlen = MIN(len, UINT_MAX);
- qcrypto_hash_alg_map[alg].write(&ctx, len, base);
- len -= shortlen;
- base += len;
- }
- }
-
- if (*resultlen == 0) {
- *resultlen = qcrypto_hash_alg_map[alg].len;
- *result = g_new0(uint8_t, *resultlen);
- } else if (*resultlen != qcrypto_hash_alg_map[alg].len) {
- error_setg(errp,
- "Result buffer size %zu is smaller than hash %zu",
- *resultlen, qcrypto_hash_alg_map[alg].len);
- return -1;
- }
-
- qcrypto_hash_alg_map[alg].result(&ctx, *resultlen, *result);
-
- return 0;
-}
-
static
QCryptoHash *qcrypto_nettle_hash_new(QCryptoHashAlgo alg, Error **errp)
{
@@ -223,7 +171,6 @@ int qcrypto_nettle_hash_finalize(QCryptoHash *hash,
}
QCryptoHashDriver qcrypto_hash_lib_driver = {
- .hash_bytesv = qcrypto_nettle_hash_bytesv,
.hash_new = qcrypto_nettle_hash_new,
.hash_update = qcrypto_nettle_hash_update,
.hash_finalize = qcrypto_nettle_hash_finalize,
--
2.46.2
next prev parent reply other threads:[~2024-10-08 7:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 7:57 [PATCH v5 00/16] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calculations Cédric Le Goater
2024-10-08 7:57 ` [PATCH v5 01/16] crypto: accumulative hashing API Cédric Le Goater
2024-10-10 10:09 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 02/16] crypto/hash-glib: Implement new hash API Cédric Le Goater
2024-10-10 10:11 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 03/16] crypto/hash-gcrypt: " Cédric Le Goater
2024-10-10 10:29 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 04/16] crypto/hash-gnutls: " Cédric Le Goater
2024-10-10 10:36 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 05/16] crypto/hash-nettle: " Cédric Le Goater
2024-10-10 10:49 ` Daniel P. Berrangé
2024-10-10 11:43 ` Daniel P. Berrangé
2024-10-10 12:01 ` Cédric Le Goater
2024-10-08 7:57 ` [PATCH v5 06/16] util/iov: Introduce iov_send_recv_with_flags() Cédric Le Goater
2024-10-10 10:51 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 07/16] crypto/hash-afalg: Implement new hash API Cédric Le Goater
2024-10-10 11:16 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 08/16] crypto/hash: Implement and use " Cédric Le Goater
2024-10-10 11:21 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 09/16] tests/unit/test-crypto-hash: accumulative hashing Cédric Le Goater
2024-10-10 11:22 ` Daniel P. Berrangé
2024-10-08 7:57 ` [PATCH v5 10/16] crypto/hash-glib: Remove old hash API functions Cédric Le Goater
2024-10-08 7:57 ` [PATCH v5 11/16] crypto/hash-gcrypt: " Cédric Le Goater
2024-10-08 7:57 ` [PATCH v5 12/16] crypto/hash-gnutls: " Cédric Le Goater
2024-10-08 7:57 ` Cédric Le Goater [this message]
2024-10-08 7:57 ` [PATCH v5 14/16] crypto/hash-afalg: " Cédric Le Goater
2024-10-08 7:57 ` [PATCH v5 15/16] crypto/hashpriv: Remove old hash API function Cédric Le Goater
2024-10-08 7:57 ` [PATCH v5 16/16] hw/misc/aspeed_hace: Fix SG Accumulative hashing Cédric Le Goater
2024-10-10 11:25 ` Daniel P. Berrangé
2024-10-08 8:01 ` [PATCH v5 00/16] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calculations Cédric Le Goater
2024-10-10 11:28 ` Daniel P. Berrangé
2024-10-10 11:40 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008075724.2772149-14-clg@redhat.com \
--to=clg@redhat.com \
--cc=alejandro.zeise@seagate.com \
--cc=berrange@redhat.com \
--cc=evan.burgess@seagate.com \
--cc=jonathan.henze@seagate.com \
--cc=kris.conklin@seagate.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).