* [PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s
@ 2024-10-08 14:13 Peter Maydell
2024-10-08 14:16 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2024-10-08 14:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth
The qmp-cmd-test test takes typically about 15s on my local machine.
On the k8s runners it takes usually 20s but sometimes about 60s,
because the k8s runners have wildly variable execution time. If
they're running slow, we hit the default timeout. Bump the
qmp-cmd-test timeout to 120s to avoid this.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
tests/qtest/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 2b90abf0007..b207e386965 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -7,6 +7,7 @@ slow_qtests = {
'migration-test' : 480,
'npcm7xx_pwm-test': 300,
'npcm7xx_watchdog_timer-test': 120,
+ 'qmp-cmd-test' : 120,
'qom-test' : 900,
'stm32l4x5_usart-test' : 600,
'test-hmp' : 240,
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s
2024-10-08 14:13 [PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s Peter Maydell
@ 2024-10-08 14:16 ` Thomas Huth
2024-10-09 19:11 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2024-10-08 14:16 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
On 08/10/2024 16.13, Peter Maydell wrote:
> The qmp-cmd-test test takes typically about 15s on my local machine.
> On the k8s runners it takes usually 20s but sometimes about 60s,
> because the k8s runners have wildly variable execution time. If
> they're running slow, we hit the default timeout. Bump the
> qmp-cmd-test timeout to 120s to avoid this.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> tests/qtest/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 2b90abf0007..b207e386965 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -7,6 +7,7 @@ slow_qtests = {
> 'migration-test' : 480,
> 'npcm7xx_pwm-test': 300,
> 'npcm7xx_watchdog_timer-test': 120,
> + 'qmp-cmd-test' : 120,
> 'qom-test' : 900,
> 'stm32l4x5_usart-test' : 600,
> 'test-hmp' : 240,
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s
2024-10-08 14:16 ` Thomas Huth
@ 2024-10-09 19:11 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2024-10-09 19:11 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel
On Tue, 8 Oct 2024 at 15:16, Thomas Huth <thuth@redhat.com> wrote:
>
> On 08/10/2024 16.13, Peter Maydell wrote:
> > The qmp-cmd-test test takes typically about 15s on my local machine.
> > On the k8s runners it takes usually 20s but sometimes about 60s,
> > because the k8s runners have wildly variable execution time. If
> > they're running slow, we hit the default timeout. Bump the
> > qmp-cmd-test timeout to 120s to avoid this.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > tests/qtest/meson.build | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> > index 2b90abf0007..b207e386965 100644
> > --- a/tests/qtest/meson.build
> > +++ b/tests/qtest/meson.build
> > @@ -7,6 +7,7 @@ slow_qtests = {
> > 'migration-test' : 480,
> > 'npcm7xx_pwm-test': 300,
> > 'npcm7xx_watchdog_timer-test': 120,
> > + 'qmp-cmd-test' : 120,
> > 'qom-test' : 900,
> > 'stm32l4x5_usart-test' : 600,
> > 'test-hmp' : 240,
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Applied directly to hopefully reduce CI flakiness.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 19:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-08 14:13 [PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s Peter Maydell
2024-10-08 14:16 ` Thomas Huth
2024-10-09 19:11 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).