From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: npiggin@gmail.com, balaton@eik.bme.hu, danielhb413@gmail.com
Subject: [PATCH v4 3/9] target/ppc: optimize hreg_compute_pmu_hflags_value
Date: Thu, 10 Oct 2024 11:17:34 +0530 [thread overview]
Message-ID: <20241010054740.1106997-4-harshpb@linux.ibm.com> (raw)
In-Reply-To: <20241010054740.1106997-1-harshpb@linux.ibm.com>
The second if-condition can be true only if the first one above is true.
Enclose the latter into the former to avoid un-necessary check if first
condition fails.
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
---
target/ppc/helper_regs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c
index 7b23e5ef0e..42c681ca4a 100644
--- a/target/ppc/helper_regs.c
+++ b/target/ppc/helper_regs.c
@@ -102,9 +102,9 @@ static uint32_t hreg_compute_pmu_hflags_value(CPUPPCState *env)
#ifndef CONFIG_USER_ONLY
if (env->pmc_ins_cnt) {
hflags |= 1 << HFLAGS_INSN_CNT;
- }
- if (env->pmc_ins_cnt & 0x1e) {
- hflags |= 1 << HFLAGS_PMC_OTHER;
+ if (env->pmc_ins_cnt & 0x1e) {
+ hflags |= 1 << HFLAGS_PMC_OTHER;
+ }
}
#endif
#endif
--
2.45.2
next prev parent reply other threads:[~2024-10-10 5:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 5:47 [PATCH v4 0/9] misc ppc improvements/optimizations Harsh Prateek Bora
2024-10-10 5:47 ` [PATCH v4 1/9] target/ppc: use locally stored msr and avoid indirect access Harsh Prateek Bora
2024-10-10 5:47 ` [PATCH v4 2/9] target/ppc: optimize hreg_compute_pmu_hflags_value Harsh Prateek Bora
2024-10-10 5:47 ` Harsh Prateek Bora [this message]
2024-10-10 5:47 ` [PATCH v4 4/9] target/ppc: optimize p9 exception handling routines Harsh Prateek Bora
2024-10-10 5:47 ` [PATCH v4 5/9] target/ppc: optimize p8 " Harsh Prateek Bora
2024-10-10 5:47 ` [PATCH v4 6/9] target/ppc: optimize p7 " Harsh Prateek Bora
2024-10-10 5:47 ` [PATCH v4 7/9] target/ppc: simplify var usage in ppc_next_unmasked_interrupt Harsh Prateek Bora
2024-10-10 5:47 ` [PATCH v4 8/9] target/ppc: combine multiple ail checks into one Harsh Prateek Bora
2024-10-10 5:47 ` [PATCH v4 9/9] target/ppc: reduce duplicate code between init_proc_POWER{9, 10} Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010054740.1106997-4-harshpb@linux.ibm.com \
--to=harshpb@linux.ibm.com \
--cc=balaton@eik.bme.hu \
--cc=danielhb413@gmail.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).