From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH 1/4] gdbstub: Make gdb_get_char() static
Date: Thu, 10 Oct 2024 11:26:56 +0200 [thread overview]
Message-ID: <20241010092938.226868-2-iii@linux.ibm.com> (raw)
In-Reply-To: <20241010092938.226868-1-iii@linux.ibm.com>
It's user-only since commit a7e0f9bd2ace ("gdbstub: abstract target
specific details from gdb_put_packet_binary").
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
gdbstub/internals.h | 2 --
gdbstub/user.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/gdbstub/internals.h b/gdbstub/internals.h
index bf5a5c63029..5acc36846f3 100644
--- a/gdbstub/internals.h
+++ b/gdbstub/internals.h
@@ -142,8 +142,6 @@ void gdb_create_default_process(GDBState *s);
int gdb_signal_to_target(int sig);
int gdb_target_signal_to_gdb(int sig);
-int gdb_get_char(void); /* user only */
-
/**
* gdb_continue() - handle continue in mode specific way.
*/
diff --git a/gdbstub/user.c b/gdbstub/user.c
index 0b4bfa9c488..1fef5201f4e 100644
--- a/gdbstub/user.c
+++ b/gdbstub/user.c
@@ -103,7 +103,7 @@ typedef struct {
static GDBUserState gdbserver_user_state;
-int gdb_get_char(void)
+static int gdb_get_char(void)
{
uint8_t ch;
int ret;
--
2.46.2
next prev parent reply other threads:[~2024-10-10 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 9:26 [PATCH 0/4] Minor gdbstub cleanups Ilya Leoshkevich
2024-10-10 9:26 ` Ilya Leoshkevich [this message]
2024-10-10 9:26 ` [PATCH 2/4] gdbstub: Move phy_memory_mode to GDBSystemState Ilya Leoshkevich
2024-10-10 9:26 ` [PATCH 3/4] gdbstub: Move gdb_syscall_mode to GDBSyscallState Ilya Leoshkevich
2024-10-10 9:26 ` [PATCH 4/4] gdbstub: Factor out gdb_try_stop() Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010092938.226868-2-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).