From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH 2/4] gdbstub: Move phy_memory_mode to GDBSystemState
Date: Thu, 10 Oct 2024 11:26:57 +0200 [thread overview]
Message-ID: <20241010092938.226868-3-iii@linux.ibm.com> (raw)
In-Reply-To: <20241010092938.226868-1-iii@linux.ibm.com>
Follow the convention that all the pieces of the global stub state must
be inside a single struct. While at it, convert phy_memory_mode to
bool.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
gdbstub/system.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdbstub/system.c b/gdbstub/system.c
index c9f236e94f7..2e31e42f7dd 100644
--- a/gdbstub/system.c
+++ b/gdbstub/system.c
@@ -35,6 +35,7 @@
typedef struct {
CharBackend chr;
Chardev *mon_chr;
+ bool phy_memory_mode;
} GDBSystemState;
GDBSystemState gdbserver_system_state;
@@ -445,14 +446,12 @@ void gdb_qemu_exit(int code)
/*
* Memory access
*/
-static int phy_memory_mode;
-
int gdb_target_memory_rw_debug(CPUState *cpu, hwaddr addr,
uint8_t *buf, int len, bool is_write)
{
CPUClass *cc;
- if (phy_memory_mode) {
+ if (gdbserver_system_state.phy_memory_mode) {
if (is_write) {
cpu_physical_memory_write(addr, buf, len);
} else {
@@ -491,7 +490,8 @@ bool gdb_can_reverse(void)
void gdb_handle_query_qemu_phy_mem_mode(GArray *params,
void *ctx)
{
- g_string_printf(gdbserver_state.str_buf, "%d", phy_memory_mode);
+ g_string_printf(gdbserver_state.str_buf, "%d",
+ gdbserver_system_state.phy_memory_mode);
gdb_put_strbuf();
}
@@ -503,9 +503,9 @@ void gdb_handle_set_qemu_phy_mem_mode(GArray *params, void *ctx)
}
if (!gdb_get_cmd_param(params, 0)->val_ul) {
- phy_memory_mode = 0;
+ gdbserver_system_state.phy_memory_mode = false;
} else {
- phy_memory_mode = 1;
+ gdbserver_system_state.phy_memory_mode = true;
}
gdb_put_packet("OK");
}
--
2.46.2
next prev parent reply other threads:[~2024-10-10 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 9:26 [PATCH 0/4] Minor gdbstub cleanups Ilya Leoshkevich
2024-10-10 9:26 ` [PATCH 1/4] gdbstub: Make gdb_get_char() static Ilya Leoshkevich
2024-10-10 9:26 ` Ilya Leoshkevich [this message]
2024-10-10 9:26 ` [PATCH 3/4] gdbstub: Move gdb_syscall_mode to GDBSyscallState Ilya Leoshkevich
2024-10-10 9:26 ` [PATCH 4/4] gdbstub: Factor out gdb_try_stop() Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010092938.226868-3-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).