From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH 3/4] gdbstub: Move gdb_syscall_mode to GDBSyscallState
Date: Thu, 10 Oct 2024 11:26:58 +0200 [thread overview]
Message-ID: <20241010092938.226868-4-iii@linux.ibm.com> (raw)
In-Reply-To: <20241010092938.226868-1-iii@linux.ibm.com>
Follow the convention that all the pieces of the global stub state must
be inside a single struct.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
gdbstub/syscalls.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c
index 4ddd5cae067..bf6a6c01b4f 100644
--- a/gdbstub/syscalls.c
+++ b/gdbstub/syscalls.c
@@ -24,6 +24,11 @@
typedef struct {
char syscall_buf[256];
gdb_syscall_complete_cb current_syscall_cb;
+ enum {
+ GDB_SYS_UNKNOWN,
+ GDB_SYS_ENABLED,
+ GDB_SYS_DISABLED,
+ } mode;
} GDBSyscallState;
static GDBSyscallState gdbserver_syscall_state;
@@ -37,12 +42,6 @@ static bool gdb_attached(void)
return gdbserver_state.init && gdbserver_state.c_cpu;
}
-static enum {
- GDB_SYS_UNKNOWN,
- GDB_SYS_ENABLED,
- GDB_SYS_DISABLED,
-} gdb_syscall_mode;
-
/* Decide if either remote gdb syscalls or native file IO should be used. */
int use_gdb_syscalls(void)
{
@@ -57,16 +56,17 @@ int use_gdb_syscalls(void)
/* -semihosting-config target=auto */
/* On the first call check if gdb is connected and remember. */
- if (gdb_syscall_mode == GDB_SYS_UNKNOWN) {
- gdb_syscall_mode = gdb_attached() ? GDB_SYS_ENABLED : GDB_SYS_DISABLED;
+ if (gdbserver_syscall_state.mode == GDB_SYS_UNKNOWN) {
+ gdbserver_syscall_state.mode = gdb_attached() ? GDB_SYS_ENABLED :
+ GDB_SYS_DISABLED;
}
- return gdb_syscall_mode == GDB_SYS_ENABLED;
+ return gdbserver_syscall_state.mode == GDB_SYS_ENABLED;
}
/* called when the stub detaches */
void gdb_disable_syscalls(void)
{
- gdb_syscall_mode = GDB_SYS_DISABLED;
+ gdbserver_syscall_state.mode = GDB_SYS_DISABLED;
}
void gdb_syscall_reset(void)
--
2.46.2
next prev parent reply other threads:[~2024-10-10 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 9:26 [PATCH 0/4] Minor gdbstub cleanups Ilya Leoshkevich
2024-10-10 9:26 ` [PATCH 1/4] gdbstub: Make gdb_get_char() static Ilya Leoshkevich
2024-10-10 9:26 ` [PATCH 2/4] gdbstub: Move phy_memory_mode to GDBSystemState Ilya Leoshkevich
2024-10-10 9:26 ` Ilya Leoshkevich [this message]
2024-10-10 9:26 ` [PATCH 4/4] gdbstub: Factor out gdb_try_stop() Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010092938.226868-4-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).